Page MenuHomePhabricator

Don't force std::set for SmallSet
AcceptedPublic

Authored by espindola on Nov 15 2015, 5:43 PM.

Details

Summary

It is a bit surprising that MapVector uses a DenseMap but SetVector uses a std::set.

Diff Detail

Event Timeline

rafael updated this revision to Diff 40241.Nov 15 2015, 5:43 PM
rafael retitled this revision from to Don't force std::set for SmallSet.
rafael updated this object.
rafael added a reviewer: chandlerc.
rafael set the repository for this revision to rL LLVM.
rafael added a subscriber: llvm-commits.
tstellarAMD accepted this revision.Dec 1 2015, 8:49 AM
tstellarAMD edited edge metadata.

I'm OK with the AMDGPU changes.

This revision is now accepted and ready to land.Dec 1 2015, 8:49 AM
chandlerc added inline comments.Dec 2 2015, 11:42 AM
lib/Analysis/AliasAnalysisEvaluator.cpp
149

Why do we want a std::set here?

utils/TableGen/AsmMatcherEmitter.cpp
1724

Why not let this use DenseSet?

espindola commandeered this revision.Mar 14 2018, 4:45 PM
espindola added a reviewer: rafael.
nhaehnle removed a subscriber: nhaehnle.Mar 17 2018, 5:22 AM