This is an archive of the discontinued LLVM Phabricator instance.

[clang-format] NFC Format.h and ClangFormatStyleOptions.rst are out of date
ClosedPublic

Authored by MyDeveloperDay on Mar 23 2023, 2:43 AM.

Diff Detail

Event Timeline

MyDeveloperDay created this revision.Mar 23 2023, 2:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 23 2023, 2:43 AM
MyDeveloperDay requested review of this revision.Mar 23 2023, 2:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 23 2023, 2:43 AM

This is a missed change as part of D144170: [clang-format] Add simple macro replacements in formatting. and as this is NFC and its blocking other reviews I'm going to go ahead and commit, but I'm passing this by your eyes and I'm happy to make adjustments D125171: [clang-format] Add a new clang-format option AlwaysBreakBeforeFunctionParameters

This revision was not accepted when it landed; it landed in state Needs Review.Mar 23 2023, 2:48 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
MyDeveloperDay updated this revision to Diff 507666.EditedMar 23 2023, 3:00 AM

Ok it seems a fix has already been landed but its not correct (missing version), modifying for better rst

This comment was removed by MyDeveloperDay.
MyDeveloperDay reopened this revision.Mar 23 2023, 3:03 AM

I've got out of practice... correct the diff properly

klimek accepted this revision.Mar 23 2023, 3:47 AM

Thank you!! Sorry for forgetting that I needed to do this, <shamecube>

This revision is now accepted and ready to land.Mar 23 2023, 3:47 AM
This revision was landed with ongoing or failed builds.Mar 24 2023, 2:27 AM
This revision was automatically updated to reflect the committed changes.