This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Module fixes for __synth_three_way.
ClosedPublic

Authored by Mordante on Mar 21 2023, 10:07 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG9c0efc8a0384: [libc++] Module fixes for __synth_three_way.
Summary

These changes make it possible to use __synth_three_way in modules. The
change from a lambda to a function is a Clang issue.

The change is list was needed since the compiler couldn't deduce the
comparison template argument.

Adds a few missing includes too.

Diff Detail

Event Timeline

Mordante created this revision.Mar 21 2023, 10:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 21 2023, 10:07 AM
Mordante requested review of this revision.Mar 21 2023, 10:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 21 2023, 10:07 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Mordante updated this revision to Diff 507068.Mar 21 2023, 11:32 AM

CI fixes, __synth_three_way is used in more places now.

ldionne accepted this revision.Mar 28 2023, 8:35 AM
ldionne added a subscriber: ldionne.
ldionne added inline comments.
libcxx/include/__compare/synth_three_way.h
28–48

Do we have a clang bug report for that? If not, let's make one and link it here.

This revision is now accepted and ready to land.Mar 28 2023, 8:35 AM
Mordante marked an inline comment as done.Apr 7 2023, 9:53 AM
Mordante added inline comments.
libcxx/include/__compare/synth_three_way.h
28–48
This revision was landed with ongoing or failed builds.Apr 7 2023, 9:54 AM
This revision was automatically updated to reflect the committed changes.
Mordante marked an inline comment as done.