Page MenuHomePhabricator
Differential D146366

[libc++] Use the stdlib=<LIB> Lit feature instead of use_system_cxx_lib
AcceptedPublic
Actions

Authored by ldionne on Sat, Mar 18, 1:31 PM.

Details

Reviewers
Mordante
MaskRay
EricWF
Group Reviewers
Restricted Project
Restricted Project
Restricted Project
Summary

The use_system_cxx_lib Lit feature was only used for back-deployment
testing. However, one immense hole in that setup was that we didn't
have a proper way to test Apple's own libc++ outside of back-deployment,
which was embodied by the fact that we needed to define _LIBCPP_DISABLE_AVAILABILITY
when testing (see change in libcxx/utils/libcxx/test/params.py).

This led to the apple-system testing configuration not checking for
availability markup, which is obviously quite bad since the library
we ship actually has availability markup.

Using stdlib=<VENDOR>-libc++ instead to encode back-deployment restrictions
on tests is simpler and it makes it possible to naturally support tests
such as availability markup checking even in the tip-of-trunk Apple-libc++
configuration.

Diff Detail

Event Timeline

ldionne created this revision.Sat, Mar 18, 1:31 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptSat, Mar 18, 1:31 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added subscribers: libcxx-commits, mikhail.ramalho, jdoerfert, arichardson. · View Herald Transcript
ldionne requested review of this revision.Sat, Mar 18, 1:31 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptSat, Mar 18, 1:31 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a reviewer: Restricted Project. · View Herald Transcript
Harbormaster completed remote builds in B220237: Diff 506315.Sat, Mar 18, 1:31 PM
ldionne added a parent revision: D146365: [libc++] Also support target triples that end with .0 in backdeployment tests.Sat, Mar 18, 1:31 PM
ldionne updated this revision to Diff 506317.Sat, Mar 18, 1:36 PM

Trigger CI with parent diff.

Harbormaster completed remote builds in B220239: Diff 506317.Sat, Mar 18, 1:37 PM
Mordante accepted this revision.Sun, Mar 19, 11:26 AM
Mordante added a subscriber: Mordante.

Thanks, I really like this patch! LGTM when the CI passes,

libcxx/utils/ci/apple-install-libcxx.sh
114

Is there a LLVM or rdar bug report we can link to?

libcxx/utils/libcxx/test/features.py
339

I see this modifies the same line again, but this time I agree with a separate patch.

MaskRay accepted this revision.Mon, Mar 20, 9:58 AM
EricWF accepted this revision.Mon, Mar 20, 11:47 AM
This revision is now accepted and ready to land.Mon, Mar 20, 11:47 AM
ldionne updated this revision to Diff 508983.Tue, Mar 28, 6:19 AM
ldionne marked 2 inline comments as done.

Add reference to bug

libcxx/utils/ci/apple-install-libcxx.sh
114

https://llvm.org/PR61762 I'll add it in the comment.

Harbormaster completed remote builds in B222224: Diff 508983.Tue, Mar 28, 7:47 AM

Revision Contents
Changeset List

PathSize
libcxx/
test/
libcxx/
language.support/
2 lines
thread/
thread.condition/
2 lines
thread.threads/
thread.thread.this/
2 lines
2 lines
std/
depr/
depr.c.headers/
2 lines
diagnostics/
syserr/
syserr.errcat/
syserr.errcat.objects/
2 lines
2 lines
input.output/
filesystems/
class.directory_entry/
directory_entry.mods/
2 lines
directory_entry.obs/
2 lines
2 lines
2 lines
fs.op.funcs/
fs.op.copy_file/
2 lines
fs.op.create_directories/
2 lines
fs.op.create_directory/
2 lines
2 lines
fs.op.file_size/
2 lines
fs.op.last_write_time/
2 lines
fs.op.remove_all/
6 lines
iostream.format/
input.streams/
istream.formatted/
istream.formatted.arithmetic/
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
istream_extractors/
2 lines
istream.unformatted/
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
output.streams/
ostream.formatted/
ostream.inserters.arithmetic/
2 lines
2 lines
iostreams.base/
ios.base/
ios.types/
ios_Init/
2 lines
language.support/
support.dynamic/
new.delete/
new.delete.array/
2 lines
new.delete.single/
2 lines
support.exception/
uncaught/
4 lines
support.runtime/
2 lines
2 lines
localization/
locale.categories/
category.ctype/
facet.ctype.special/
facet.ctype.char.statics/
4 lines
category.numeric/
locale.num.get/
facet.num.get.members/
2 lines
numerics/
rand/
rand.device/
2 lines
strings/
basic.string/
string.capacity/
4 lines
thread/
futures/
futures.async/
2 lines
futures.future_error/
2 lines
thread.condition/
4 lines
utilities/
memory/
temporary.buffer/
2 lines
utils/
ci/
11 lines
2 lines
libcxx/
test/
37 lines
33 lines
libcxxabi/
test/
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
4 lines
2 lines
4 lines
4 lines
2 lines
2 lines
2 lines
2 lines
libunwind/
test/
2 lines

Diff 506317

View Options

libcxx/test/libcxx/language.support/cxa_deleted_virtual.pass.cpp

Loading...
View Options

libcxx/test/libcxx/thread/thread.condition/PR30202_notify_from_pthread_created_thread.pass.cpp

Loading...
View Options

libcxx/test/libcxx/thread/thread.threads/thread.thread.this/sleep_for.pass.cpp

Loading...
View Options

libcxx/test/libcxx/thread/thread.threads/thread.thread.this/sleep_for.signals.pass.cpp

Loading...
View Options

libcxx/test/std/depr/depr.c.headers/stdlib_h.aligned_alloc.compile.pass.cpp

Loading...
View Options

libcxx/test/std/diagnostics/syserr/syserr.errcat/syserr.errcat.objects/generic_category.pass.cpp

Loading...
View Options

libcxx/test/std/diagnostics/syserr/syserr.errcat/syserr.errcat.objects/system_category.pass.cpp

Loading...
View Options

libcxx/test/std/input.output/filesystems/class.directory_entry/directory_entry.mods/refresh.pass.cpp

Loading...
View Options

libcxx/test/std/input.output/filesystems/class.directory_entry/directory_entry.obs/file_size.pass.cpp

Loading...
View Options

libcxx/test/std/input.output/filesystems/class.directory_entry/directory_entry.obs/hard_link_count.pass.cpp

Loading...
View Options

libcxx/test/std/input.output/filesystems/class.directory_entry/directory_entry.obs/last_write_time.pass.cpp

Loading...
View Options

libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.copy_file/copy_file.pass.cpp

Loading...
View Options

libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.create_directories/create_directories.pass.cpp

Loading...
View Options

libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.create_directory/create_directory.pass.cpp

Loading...
View Options

libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.create_directory/create_directory_with_attributes.pass.cpp

Loading...
View Options

libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.file_size/file_size.pass.cpp

Loading...
View Options

libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp

Loading...
View Options

libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.remove_all/toctou.pass.cpp

Loading...
View Options

libcxx/test/std/input.output/iostream.format/input.streams/istream.formatted/istream.formatted.arithmetic/bool.pass.cpp

Loading...
View Options

libcxx/test/std/input.output/iostream.format/input.streams/istream.formatted/istream.formatted.arithmetic/double.pass.cpp

Loading...
View Options

libcxx/test/std/input.output/iostream.format/input.streams/istream.formatted/istream.formatted.arithmetic/float.pass.cpp

Loading...
View Options

libcxx/test/std/input.output/iostream.format/input.streams/istream.formatted/istream.formatted.arithmetic/int.pass.cpp

Loading...
View Options

libcxx/test/std/input.output/iostream.format/input.streams/istream.formatted/istream.formatted.arithmetic/long.pass.cpp

Loading...
View Options

libcxx/test/std/input.output/iostream.format/input.streams/istream.formatted/istream.formatted.arithmetic/long_double.pass.cpp

Loading...
View Options

libcxx/test/std/input.output/iostream.format/input.streams/istream.formatted/istream.formatted.arithmetic/long_long.pass.cpp

Loading...
View Options

libcxx/test/std/input.output/iostream.format/input.streams/istream.formatted/istream.formatted.arithmetic/pointer.pass.cpp

Loading...
View Options

libcxx/test/std/input.output/iostream.format/input.streams/istream.formatted/istream.formatted.arithmetic/short.pass.cpp

Loading...
View Options

libcxx/test/std/input.output/iostream.format/input.streams/istream.formatted/istream.formatted.arithmetic/unsigned_int.pass.cpp

Loading...
View Options

libcxx/test/std/input.output/iostream.format/input.streams/istream.formatted/istream.formatted.arithmetic/unsigned_long.pass.cpp

Loading...
View Options

libcxx/test/std/input.output/iostream.format/input.streams/istream.formatted/istream.formatted.arithmetic/unsigned_long_long.pass.cpp

Loading...
View Options

libcxx/test/std/input.output/iostream.format/input.streams/istream.formatted/istream.formatted.arithmetic/unsigned_short.pass.cpp

Loading...
View Options

libcxx/test/std/input.output/iostream.format/input.streams/istream.formatted/istream_extractors/streambuf.pass.cpp

Loading...
View Options

libcxx/test/std/input.output/iostream.format/input.streams/istream.unformatted/get.pass.cpp

Loading...
View Options

libcxx/test/std/input.output/iostream.format/input.streams/istream.unformatted/get_chart.pass.cpp

Loading...
View Options

libcxx/test/std/input.output/iostream.format/input.streams/istream.unformatted/get_pointer_size.pass.cpp

Loading...
View Options

libcxx/test/std/input.output/iostream.format/input.streams/istream.unformatted/get_pointer_size_chart.pass.cpp

Loading...
View Options

libcxx/test/std/input.output/iostream.format/input.streams/istream.unformatted/get_streambuf.pass.cpp

Loading...
View Options

libcxx/test/std/input.output/iostream.format/input.streams/istream.unformatted/get_streambuf_chart.pass.cpp

Loading...
View Options

libcxx/test/std/input.output/iostream.format/input.streams/istream.unformatted/getline_pointer_size.pass.cpp

Loading...
View Options

libcxx/test/std/input.output/iostream.format/input.streams/istream.unformatted/getline_pointer_size_chart.pass.cpp

Loading...
View Options

libcxx/test/std/input.output/iostream.format/input.streams/istream.unformatted/ignore.pass.cpp

Loading...
View Options

libcxx/test/std/input.output/iostream.format/input.streams/istream.unformatted/peek.pass.cpp

Loading...
View Options

libcxx/test/std/input.output/iostream.format/input.streams/istream.unformatted/read.pass.cpp

Loading...
View Options

libcxx/test/std/input.output/iostream.format/input.streams/istream.unformatted/seekg_off.pass.cpp

Loading...
View Options

libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.arithmetic/minmax_showbase.pass.cpp

Loading...
View Options

libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.arithmetic/minus1.pass.cpp

Loading...
View Options

libcxx/test/std/input.output/iostreams.base/ios.base/ios.types/ios_Init/ios_Init.multiple.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.array/sized_delete_array_fsizeddeallocation.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.single/sized_delete_fsizeddeallocation.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.exception/uncaught/uncaught_exceptions.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.runtime/cstdlib.aligned_alloc.compile.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.runtime/ctime.timespec.compile.pass.cpp

Loading...
View Options

libcxx/test/std/localization/locale.categories/category.ctype/facet.ctype.special/facet.ctype.char.statics/table_size.pass.cpp

Loading...
View Options

libcxx/test/std/localization/locale.categories/category.numeric/locale.num.get/facet.num.get.members/get_long.pass.cpp

Loading...
View Options

libcxx/test/std/numerics/rand/rand.device/ctor.pass.cpp

Loading...
View Options

libcxx/test/std/strings/basic.string/string.capacity/over_max_size.pass.cpp

Loading...
View Options

libcxx/test/std/thread/futures/futures.async/async_race.38682.pass.cpp

Loading...
View Options

libcxx/test/std/thread/futures/futures.future_error/what.pass.cpp

Loading...
View Options

libcxx/test/std/thread/thread.condition/notify_all_at_thread_exit_lwg3343.pass.cpp

Loading...
View Options

libcxx/test/std/utilities/memory/temporary.buffer/overaligned.pass.cpp

Loading...
View Options

libcxx/utils/ci/apple-install-libcxx.sh

Loading...
View Options

libcxx/utils/ci/run-buildbot

Loading...
View Options

libcxx/utils/libcxx/test/features.py

Loading...
View Options

libcxx/utils/libcxx/test/params.py

Loading...
View Options

libcxxabi/test/catch_function_01.pass.cpp

Loading...
View Options

libcxxabi/test/catch_function_03.pass.cpp

Loading...
View Options

libcxxabi/test/catch_member_data_pointer_01.pass.cpp

Loading...
View Options

libcxxabi/test/catch_member_function_pointer_02.pass.cpp

Loading...
View Options

libcxxabi/test/catch_member_pointer_nullptr.pass.cpp

Loading...
View Options

libcxxabi/test/catch_multi_level_pointer.pass.cpp

Loading...
View Options

libcxxabi/test/catch_pointer_nullptr.pass.cpp

Loading...
View Options

libcxxabi/test/catch_ptr_02.pass.cpp

Loading...
View Options

libcxxabi/test/cxa_vec_new_overflow_PR41395.pass.cpp

Loading...
View Options

libcxxabi/test/dynamic_cast.pass.cpp

Loading...
View Options

libcxxabi/test/exception_object_alignment.pass.cpp

Loading...
View Options

libcxxabi/test/forced_unwind1.pass.cpp

Loading...
View Options

libcxxabi/test/forced_unwind2.pass.cpp

Loading...
View Options

libcxxabi/test/incomplete_type.sh.cpp

Loading...
View Options

libcxxabi/test/test_aux_runtime_op_array_new.pass.cpp

Loading...
View Options

libcxxabi/test/test_demangle.pass.cpp

Loading...
View Options

libcxxabi/test/test_exception_address_alignment.pass.cpp

Loading...
View Options

libcxxabi/test/uncaught_exceptions.pass.cpp

Loading...
View Options

libunwind/test/libunwind_01.pass.cpp

Loading...