diff --git a/llvm/lib/CodeGen/HardwareLoops.cpp b/llvm/lib/CodeGen/HardwareLoops.cpp --- a/llvm/lib/CodeGen/HardwareLoops.cpp +++ b/llvm/lib/CodeGen/HardwareLoops.cpp @@ -332,9 +332,12 @@ HWLoopInfo.CountType = IntegerType::get(Ctx, Opts.Bitwidth.value()); } - if (Opts.Decrement.has_value()) + if (Opts.Decrement.has_value()) { + if (!HWLoopInfo.CountType) // HWLoopInfo.CountType could not be nullptr! + return false; HWLoopInfo.LoopDecrement = ConstantInt::get(HWLoopInfo.CountType, Opts.Decrement.value()); + } MadeChange |= TryConvertLoop(HWLoopInfo); return MadeChange && (!HWLoopInfo.IsNestingLegal && !Opts.ForceNested); @@ -342,6 +345,8 @@ bool HardwareLoopsImpl::TryConvertLoop(HardwareLoopInfo &HWLoopInfo) { + if (!HWLoopInfo.CountType) // HWLoopInfo.CountType could not be nullptr! + return false; Loop *L = HWLoopInfo.L; LLVM_DEBUG(dbgs() << "HWLoops: Try to convert profitable loop: " << *L); @@ -389,8 +394,11 @@ Value *EltsRem = InsertPHICounter(Setup, LoopDec); LoopDec->setOperand(0, EltsRem); UpdateBranch(LoopDec); - } else + } else { + if (!LoopDecrement) // LoopDecrement can not be nullptr! + return; InsertLoopDec(); + } // Run through the basic blocks of the loop and see if any of them have dead // PHIs that can be removed. diff --git a/llvm/test/Transforms/HardwareLoops/input-error.ll b/llvm/test/Transforms/HardwareLoops/input-error.ll new file mode 100644 --- /dev/null +++ b/llvm/test/Transforms/HardwareLoops/input-error.ll @@ -0,0 +1,52 @@ +; RUN: opt -passes='hardware-loops' -S %s -o - | FileCheck %s --check-prefix=CHECK +; RUN: opt -passes='hardware-loops' -S %s -o - | FileCheck %s --check-prefix=CHECK +; RUN: opt -passes='hardware-loops' -S %s -o - | FileCheck %s --check-prefix=CHECK-DEC + +define void @while_lt(i32 %i, i32 %N, ptr nocapture %A) { +; CHECK-LABEL: @while_lt( +; CHECK-NEXT: entry: +; CHECK-NEXT: [[CMP4:%.*]] = icmp ult i32 [[I:%.*]], [[N:%.*]] +; CHECK-NEXT: br i1 [[CMP4]], label [[WHILE_BODY:%.*]], label [[WHILE_END:%.*]] +; CHECK: while.body: +; CHECK-NEXT: [[I_ADDR_05:%.*]] = phi i32 [ [[INC:%.*]], [[WHILE_BODY]] ], [ [[I]], [[ENTRY:%.*]] ] +; CHECK-NEXT: [[ARRAYIDX:%.*]] = getelementptr inbounds i32, ptr [[A:%.*]], i32 [[I_ADDR_05]] +; CHECK-NEXT: store i32 [[I_ADDR_05]], ptr [[ARRAYIDX]], align 4 +; CHECK-NEXT: [[INC]] = add nuw i32 [[I_ADDR_05]], 1 +; CHECK-NEXT: [[TMP1:%.*]] = icmp eq i32 [[INC]], [[N]] +; CHECK-NEXT: br i1 [[TMP1]], label [[WHILE_END]], label [[WHILE_BODY]] +; CHECK: while.end: +; CHECK-NEXT: ret void +; +; CHECK-DEC-LABEL: @while_lt( +; CHECK-DEC-NEXT: entry: +; CHECK-DEC-NEXT: [[CMP4:%.*]] = icmp ult i32 [[I:%.*]], [[N:%.*]] +; CHECK-DEC-NEXT: br i1 [[CMP4]], label [[WHILE_BODY_PREHEADER:%.*]], label [[WHILE_END:%.*]] +; CHECK-DEC: while.body.preheader: +; CHECK-DEC-NEXT: [[TMP0:%.*]] = sub i32 [[N]], [[I]] +; CHECK-DEC-NEXT: call void @llvm.set.loop.iterations.i32(i32 [[TMP0]]) +; CHECK-DEC-NEXT: br label [[WHILE_BODY:%.*]] +; CHECK-DEC: while.body: +; CHECK-DEC-NEXT: [[I_ADDR_05:%.*]] = phi i32 [ [[INC:%.*]], [[WHILE_BODY]] ], [ [[I]], [[WHILE_BODY_PREHEADER]] ] +; CHECK-DEC-NEXT: [[ARRAYIDX:%.*]] = getelementptr inbounds i32, ptr [[A:%.*]], i32 [[I_ADDR_05]] +; CHECK-DEC-NEXT: store i32 [[I_ADDR_05]], ptr [[ARRAYIDX]], align 4 +; CHECK-DEC-NEXT: [[INC]] = add nuw i32 [[I_ADDR_05]], 1 +; CHECK-DEC-NEXT: [[TMP1:%.*]] = icmp eq i32 [[INC]], [[N]] +; CHECK-DEC-NEXT: br i1 [[TMP1]], label [[WHILE_END]], label [[WHILE_BODY]] +; CHECK-DEC: while.end: +; CHECK-DEC-NEXT: ret void +; +entry: + %cmp4 = icmp ult i32 %i, %N + br i1 %cmp4, label %while.body, label %while.end + +while.body: + %i.addr.05 = phi i32 [ %inc, %while.body ], [ %i, %entry ] + %arrayidx = getelementptr inbounds i32, ptr %A, i32 %i.addr.05 + store i32 %i.addr.05, ptr %arrayidx, align 4 + %inc = add nuw i32 %i.addr.05, 1 + %exitcond = icmp eq i32 %inc, %N + br i1 %exitcond, label %while.end, label %while.body + +while.end: + ret void +}