This is an archive of the discontinued LLVM Phabricator instance.

Differential D146268

[tests] precommit tests for D145846
AbandonedPublic

Authored by Allen on Mar 16 2023, 6:54 PM.

Details

Reviewers
None

Diff Detail

Unit TestsFailed

TimeTest
100 msx64 debian > Flang.Examples::feature-list-class.f90
110 msx64 debian > Flang.Examples::feature-list-functions.f90

Event Timeline

Allen created this revision.Mar 16 2023, 6:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 16 2023, 6:55 PM
Allen requested review of this revision.Mar 16 2023, 6:55 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 16 2023, 6:55 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Allen added a child revision: D145846: [InstCombine] enhance icmp with sub folds.Mar 16 2023, 7:37 PM
Allen mentioned this in D145846: [InstCombine] enhance icmp with sub folds.
Harbormaster completed remote builds in B219985: Diff 505966.Mar 16 2023, 8:17 PM
Allen updated this revision to Diff 506462.Mar 19 2023, 9:42 PM

Add more tests according comment

Allen updated this revision to Diff 506464.Mar 19 2023, 10:13 PM
Harbormaster completed remote builds in B220353: Diff 506464.Mar 19 2023, 11:11 PM
Allen updated this revision to Diff 507258.Mar 22 2023, 12:49 AM

Add "thwart complexity-based canonicalization"

Harbormaster completed remote builds in B220943: Diff 507258.Mar 22 2023, 1:48 AM
Allen added a comment.Mar 22 2023, 4:50 AM

close as commit e2f6ebe8ca15

Allen abandoned this revision.Mar 22 2023, 4:51 AM

Revision Contents

PathSize
llvm/
test/
Transforms/
InstCombine/
85 lines

Diff 507258

llvm/test/Transforms/InstCombine/icmp-sub.ll

Show First 20 Lines • Show All 91 Lines • ▼ Show 20 Lines
%phi_outer = phi i32 [ %sub, %bb_loop ], [ %x, %bb_entry ] %phi_outer = phi i32 [ %sub, %bb_loop ], [ %x, %bb_entry ]
%sub = sub i32 %phi_outer, %y %sub = sub i32 %phi_outer, %y
%cond_outer = icmp eq i32 %sub, 0 %cond_outer = icmp eq i32 %sub, 0
br i1 %cond_outer, label %bb_exit, label %bb_loop br i1 %cond_outer, label %bb_exit, label %bb_loop
bb_exit: bb_exit:
ret void ret void
} }
; https://alive2.llvm.org/ce/z/D2Aph4
define i1 @PR60818_ne(i32 %a) {
; CHECK-LABEL: @PR60818_ne(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[SUB:%.*]] = sub i32 0, [[A:%.*]]
; CHECK-NEXT: [[CMP:%.*]] = icmp ne i32 [[SUB]], [[A]]
; CHECK-NEXT: ret i1 [[CMP]]
;
entry:
%sub = sub i32 0, %a
%cmp = icmp ne i32 %sub, %a
ret i1 %cmp
}
define i1 @PR60818_eq(i32 %a) {
; CHECK-LABEL: @PR60818_eq(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[SUB:%.*]] = sub i32 0, [[A:%.*]]
; CHECK-NEXT: [[CMP:%.*]] = icmp eq i32 [[SUB]], [[A]]
; CHECK-NEXT: ret i1 [[CMP]]
;
entry:
%sub = sub i32 0, %a
%cmp = icmp eq i32 %sub, %a
ret i1 %cmp
}
define i1 @PR60818_eq_commuted(i32 %x) {
; CHECK-LABEL: @PR60818_eq_commuted(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[A:%.*]] = mul i32 [[X:%.*]], 43
; CHECK-NEXT: [[SUB:%.*]] = sub i32 0, [[A]]
; CHECK-NEXT: [[CMP:%.*]] = icmp eq i32 [[A]], [[SUB]]
; CHECK-NEXT: ret i1 [[CMP]]
;
entry:
%a = mul i32 %x, 43 ; thwart complexity-based canonicalization
%sub = sub i32 0, %a
%cmp = icmp eq i32 %a, %sub ; negation on RHS
ret i1 %cmp
}
define <2 x i1> @PR60818_ne_vector(<2 x i32> %a) {
; CHECK-LABEL: @PR60818_ne_vector(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[SUB:%.*]] = sub <2 x i32> zeroinitializer, [[A:%.*]]
; CHECK-NEXT: [[CMP:%.*]] = icmp ne <2 x i32> [[SUB]], [[A]]
; CHECK-NEXT: ret <2 x i1> [[CMP]]
;
entry:
%sub = sub <2 x i32> zeroinitializer, %a
%cmp = icmp ne <2 x i32> %a, %sub
ret <2 x i1> %cmp
}
; Negative as multi-use
define i1 @PR60818_eq_multi_use(i32 %a) {
; CHECK-LABEL: @PR60818_eq_multi_use(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[SUB:%.*]] = sub i32 0, [[A:%.*]]
; CHECK-NEXT: call void @use(i32 [[SUB]])
; CHECK-NEXT: [[CMP:%.*]] = icmp eq i32 [[SUB]], [[A]]
; CHECK-NEXT: ret i1 [[CMP]]
;
entry:
%sub = sub i32 0, %a
call void @use(i32 %sub) ; add new user
%cmp = icmp eq i32 %sub, %a
ret i1 %cmp
}
; Negative as non-equality predicate
define i1 @PR60818_sgt(i32 %a) {
; CHECK-LABEL: @PR60818_sgt(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[SUB:%.*]] = sub i32 0, [[A:%.*]]
; CHECK-NEXT: [[CMP:%.*]] = icmp sgt i32 [[SUB]], [[A]]
; CHECK-NEXT: ret i1 [[CMP]]
;
entry:
%sub = sub i32 0, %a
%cmp = icmp sgt i32 %sub, %a
ret i1 %cmp
}
Context not available.