This is an archive of the discontinued LLVM Phabricator instance.

Replace `IntrinsicEmitter::ComputeFixedEncoding()` and cleanup
ClosedPublic

Authored by chapuni on Mar 13 2023, 7:13 AM.

Diff Detail

Event Timeline

chapuni created this revision.Mar 13 2023, 7:13 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 13 2023, 7:13 AM
chapuni edited the summary of this revision. (Show Details)Mar 13 2023, 7:14 AM
chapuni updated this revision to Diff 505119.Mar 14 2023, 8:33 AM
  • Update (w/ some fixups)
arsenm added a subscriber: arsenm.Mar 14 2023, 3:56 PM
arsenm added inline comments.
llvm/include/llvm/CodeGen/ValueTypes.td
29 ↗(On Diff #505119)

Does this mean it's now possible to define codegen patterns that accept different types? e.g. a single store pattern that accepts i32 and f32 inputs?

chapuni updated this revision to Diff 505315.Mar 14 2023, 4:23 PM
chapuni edited the summary of this revision. (Show Details)

Rebase on D143844

chapuni updated this revision to Diff 505319.Mar 14 2023, 4:30 PM

Restore the last cleanup

chapuni added inline comments.Mar 14 2023, 4:50 PM
llvm/include/llvm/CodeGen/ValueTypes.td
29 ↗(On Diff #505119)

I suppose this is just a convention for coming MVTEmitter to emit MVT::isOverloaded(). I have no idea if we could enhance semantics.

chapuni updated this revision to Diff 505521.Mar 15 2023, 9:04 AM
chapuni edited the summary of this revision. (Show Details)
  • Update for recent changes
chapuni edited the summary of this revision. (Show Details)Mar 15 2023, 9:20 AM
chapuni edited the summary of this revision. (Show Details)Mar 15 2023, 4:56 PM
chapuni updated this revision to Diff 506440.Mar 19 2023, 3:23 PM
chapuni edited the summary of this revision. (Show Details)
chapuni updated this revision to Diff 507182.Mar 21 2023, 4:53 PM
chapuni edited the summary of this revision. (Show Details)
chapuni updated this revision to Diff 508414.Mar 26 2023, 7:03 AM
chapuni retitled this revision from TableGen: Let Intrinsics.td emit TypeSig to Replace `IntrinsicEmitter::ComputeFixedEncoding()` and cleanup.
chapuni edited the summary of this revision. (Show Details)
  • Split out preceding changes
chapuni published this revision for review.Mar 26 2023, 7:08 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 26 2023, 7:08 AM
arsenm accepted this revision.Mar 30 2023, 11:54 AM
This revision is now accepted and ready to land.Mar 30 2023, 11:54 AM
chapuni updated this revision to Diff 511421.Apr 6 2023, 7:56 AM
  • Rebase
This revision was landed with ongoing or failed builds.Apr 26 2023, 7:50 AM
This revision was automatically updated to reflect the committed changes.