diff --git a/clang/docs/ReleaseNotes.rst b/clang/docs/ReleaseNotes.rst --- a/clang/docs/ReleaseNotes.rst +++ b/clang/docs/ReleaseNotes.rst @@ -291,6 +291,9 @@ template parameters with different nested constraints. - Fix type equivalence comparison between auto types to take constraints into account. +- Fix bug in the computation of the ``__has_unique_object_representations`` + builtin for types with unnamed bitfields. + (`#61336 `_) Bug Fixes to AST Handling ^^^^^^^^^^^^^^^^^^^^^^^^^ diff --git a/clang/lib/AST/ASTContext.cpp b/clang/lib/AST/ASTContext.cpp --- a/clang/lib/AST/ASTContext.cpp +++ b/clang/lib/AST/ASTContext.cpp @@ -2716,6 +2716,11 @@ int64_t FieldSizeInBits = Context.toBits(Context.getTypeSizeInChars(Field->getType())); if (Field->isBitField()) { + // If we have explicit padding bits, they don't contribute bits + // to the actual object representation, so return 0. + if (Field->isUnnamedBitfield()) + return 0; + int64_t BitfieldSize = Field->getBitWidthValue(Context); if (IsBitIntType) { if ((unsigned)BitfieldSize > diff --git a/clang/test/SemaCXX/type-traits.cpp b/clang/test/SemaCXX/type-traits.cpp --- a/clang/test/SemaCXX/type-traits.cpp +++ b/clang/test/SemaCXX/type-traits.cpp @@ -2828,6 +2828,17 @@ static_assert(!has_unique_object_representations::value, "Alignment causes padding"); static_assert(!has_unique_object_representations::value, "Also no arrays that have padding"); +struct __attribute__((packed)) PackedNoPadding1 { + short i; + int j; +}; +struct __attribute__((packed)) PackedNoPadding2 { + int j; + short i; +}; +static_assert(has_unique_object_representations::value, "Packed structs have no padding"); +static_assert(has_unique_object_representations::value, "Packed structs have no padding"); + static_assert(!has_unique_object_representations::value, "Functions are not unique"); static_assert(!has_unique_object_representations::value, "Functions are not unique"); static_assert(!has_unique_object_representations::value, "Functions are not unique"); @@ -2878,9 +2889,35 @@ char d : 2; }; +struct UnnamedBitfield { + int named : 8; + int : 24; +}; + +struct __attribute__((packed)) UnnamedBitfieldPacked { + int named : 8; + int : 24; +}; + +struct UnnamedEmptyBitfield { + int named; + int : 0; +}; + +struct UnnamedEmptyBitfieldSplit { + short named; + int : 0; + short also_named; +}; + static_assert(!has_unique_object_representations::value, "Bitfield padding"); static_assert(has_unique_object_representations::value, "Bitfield padding"); static_assert(!has_unique_object_representations::value, "Bitfield padding"); +static_assert(!has_unique_object_representations::value, "Bitfield padding"); +static_assert(!has_unique_object_representations::value, "Bitfield padding"); +static_assert(has_unique_object_representations::value, "Bitfield padding"); +static_assert(sizeof(UnnamedEmptyBitfieldSplit) != (sizeof(short) * 2), "Wrong size"); +static_assert(!has_unique_object_representations::value, "Bitfield padding"); struct BoolBitfield { bool b : 8;