This is an archive of the discontinued LLVM Phabricator instance.

Differential D145531

[X86] Add ICX target in `unpckpd` tuning tests; NFC
ClosedPublic

Authored by goldstein.w.n on Mar 7 2023, 4:24 PM.

Details

Reviewers
RKSimon
pengfei
Commits
rG6dbf894b8066: [X86] Add ICX target in `unpckpd` tuning tests; NFC

Diff Detail

Event Timeline

goldstein.w.n created this revision.Mar 7 2023, 4:24 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 7 2023, 4:24 PM
Herald added a subscriber: pengfei. · View Herald Transcript
goldstein.w.n requested review of this revision.Mar 7 2023, 4:24 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 7 2023, 4:24 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
goldstein.w.n mentioned this in D144570: [X86] Add support for using Sched/Codesize information to `X86FixupInstTuning` Pass..Mar 7 2023, 4:25 PM
goldstein.w.n added reviewers: RKSimon, pengfei.
goldstein.w.n added a child revision: D144570: [X86] Add support for using Sched/Codesize information to `X86FixupInstTuning` Pass..
Harbormaster completed remote builds in B217964: Diff 503181.Mar 7 2023, 5:05 PM
RKSimon accepted this revision.Mar 7 2023, 5:22 PM

LGTM

This revision is now accepted and ready to land.Mar 7 2023, 5:22 PM
goldstein.w.n updated this revision to Diff 503208.Mar 7 2023, 7:04 PM

Rebase

Harbormaster completed remote builds in B217984: Diff 503208.Mar 7 2023, 7:43 PM
This revision was landed with ongoing or failed builds.Mar 8 2023, 9:58 AM
Closed by commit rG6dbf894b8066: [X86] Add ICX target in `unpckpd` tuning tests; NFC (authored by goldstein.w.n). · Explain Why
This revision was automatically updated to reflect the committed changes.
goldstein.w.n added a commit: rG6dbf894b8066: [X86] Add ICX target in `unpckpd` tuning tests; NFC.

Revision Contents

PathSize
llvm/
test/
CodeGen/
X86/
2 lines

Diff 503421

llvm/test/CodeGen/X86/tuning-shuffle-unpckpd.ll

; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mcpu=skylake | FileCheck %s --check-prefixes=CHECK,CHECK-SKL ; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mcpu=skylake | FileCheck %s --check-prefixes=CHECK,CHECK-SKL
; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mcpu=x86-64-v3 | FileCheck %s --check-prefixes=CHECK,CHECK-V3 ; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mcpu=x86-64-v3 | FileCheck %s --check-prefixes=CHECK,CHECK-V3
; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mcpu=icelake-server | FileCheck %s --check-prefixes=CHECK,CHECK-ICX
define <8 x float> @transform_VUNPCKLPDYrr(<8 x float> %a, <8 x float> %b) nounwind { define <8 x float> @transform_VUNPCKLPDYrr(<8 x float> %a, <8 x float> %b) nounwind {
; CHECK-LABEL: transform_VUNPCKLPDYrr: ; CHECK-LABEL: transform_VUNPCKLPDYrr:
; CHECK: # %bb.0: ; CHECK: # %bb.0:
; CHECK-NEXT: vunpcklpd {{.*#+}} ymm0 = ymm0[0],ymm1[0],ymm0[2],ymm1[2] ; CHECK-NEXT: vunpcklpd {{.*#+}} ymm0 = ymm0[0],ymm1[0],ymm0[2],ymm1[2]
; CHECK-NEXT: retq ; CHECK-NEXT: retq
%shufp = shufflevector <8 x float> %a, <8 x float> %b, <8 x i32> <i32 0, i32 1, i32 8, i32 9, i32 4, i32 5, i32 12, i32 13> %shufp = shufflevector <8 x float> %a, <8 x float> %b, <8 x i32> <i32 0, i32 1, i32 8, i32 9, i32 4, i32 5, i32 12, i32 13>
ret <8 x float> %shufp ret <8 x float> %shufp
▲ Show 20 Lines • Show All 61 Lines • ▼ Show 20 Lines
; CHECK: # %bb.0: ; CHECK: # %bb.0:
; CHECK-NEXT: vunpckhpd {{.*#+}} xmm0 = xmm0[1],mem[1] ; CHECK-NEXT: vunpckhpd {{.*#+}} xmm0 = xmm0[1],mem[1]
; CHECK-NEXT: retq ; CHECK-NEXT: retq
%b = load <4 x float>, ptr %pb %b = load <4 x float>, ptr %pb
%shufp = shufflevector <4 x float> %a, <4 x float> %b, <4 x i32> <i32 2, i32 3, i32 6, i32 7> %shufp = shufflevector <4 x float> %a, <4 x float> %b, <4 x i32> <i32 2, i32 3, i32 6, i32 7>
ret <4 x float> %shufp ret <4 x float> %shufp
} }
;; NOTE: These prefixes are unused and the list is autogenerated. Do not add tests below this line: ;; NOTE: These prefixes are unused and the list is autogenerated. Do not add tests below this line:
; CHECK-ICX: {{.*}}
; CHECK-SKL: {{.*}} ; CHECK-SKL: {{.*}}
; CHECK-V3: {{.*}} ; CHECK-V3: {{.*}}