This is an archive of the discontinued LLVM Phabricator instance.

[clang-tidy] readability-identifier-naming.HungarianNotation: rename CharPrinter to CharPointer
ClosedPublic

Authored by amurzeau on Feb 25 2023, 2:32 PM.

Details

Summary

The CharPrinter is a typo and should have been named CharPointer as it
configures the hungarian notation prefix for char pointers (char*).

As all configuration options within
readability-identifier-naming.HungarianNotation.CString.* were not read
at all in the previous clang-tidy version (fixed in D144431), this option
rename won't break existing users.

A note in release notes is added to let users know these options were
renamed.

Diff Detail

Event Timeline

amurzeau created this revision.Feb 25 2023, 2:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 25 2023, 2:32 PM
Herald added a subscriber: xazax.hun. · View Herald Transcript
amurzeau requested review of this revision.Feb 25 2023, 2:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 25 2023, 2:32 PM
carlosgalvezp accepted this revision.Feb 25 2023, 11:42 PM

Good catch, thanks for fixing!

This revision is now accepted and ready to land.Feb 25 2023, 11:42 PM