diff --git a/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp b/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp --- a/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp +++ b/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp @@ -11797,6 +11797,38 @@ } } + // Match VSELECTs with absolute difference patterns. + // (vselect (setcc a, b, set?gt), (sub a, b), (sub b, a)) --> (abd? a, b) + // (vselect (setcc a, b, set?ge), (sub a, b), (sub b, a)) --> (abd? a, b) + // (vselect (setcc a, b, set?lt), (sub b, a), (sub a, b)) --> (abd? a, b) + // (vselect (setcc a, b, set?le), (sub b, a), (sub a, b)) --> (abd? a, b) + if (N1.getOpcode() == ISD::SUB && N2.getOpcode() == ISD::SUB && + N1.getOperand(0) == N2.getOperand(1) && + N1.getOperand(1) == N2.getOperand(0)) { + bool IsSigned = isSignedIntSetCC(CC); + unsigned ABDOpc = IsSigned ? ISD::ABDS : ISD::ABDU; + if (hasOperation(ABDOpc, VT)) { + switch (CC) { + case ISD::SETGT: + case ISD::SETGE: + case ISD::SETUGT: + case ISD::SETUGE: + if (LHS == N1.getOperand(0) && RHS == N1.getOperand(1)) + return DAG.getNode(ABDOpc, DL, VT, LHS, RHS); + break; + case ISD::SETLT: + case ISD::SETLE: + case ISD::SETULT: + case ISD::SETULE: + if (RHS == N1.getOperand(0) && LHS == N1.getOperand(1) ) + return DAG.getNode(ABDOpc, DL, VT, LHS, RHS); + break; + default: + break; + } + } + } + // Match VSELECTs into add with unsigned saturation. if (hasOperation(ISD::UADDSAT, VT)) { // Check if one of the arms of the VSELECT is vector with all bits set. diff --git a/llvm/lib/Target/PowerPC/PPCISelLowering.h b/llvm/lib/Target/PowerPC/PPCISelLowering.h --- a/llvm/lib/Target/PowerPC/PPCISelLowering.h +++ b/llvm/lib/Target/PowerPC/PPCISelLowering.h @@ -1415,7 +1415,6 @@ SDValue combineFMALike(SDNode *N, DAGCombinerInfo &DCI) const; SDValue combineTRUNCATE(SDNode *N, DAGCombinerInfo &DCI) const; SDValue combineSetCC(SDNode *N, DAGCombinerInfo &DCI) const; - SDValue combineVSelect(SDNode *N, DAGCombinerInfo &DCI) const; SDValue combineVectorShuffle(ShuffleVectorSDNode *SVN, SelectionDAG &DAG) const; SDValue combineVReverseMemOP(ShuffleVectorSDNode *SVN, LSBaseSDNode *LSBase, diff --git a/llvm/lib/Target/PowerPC/PPCISelLowering.cpp b/llvm/lib/Target/PowerPC/PPCISelLowering.cpp --- a/llvm/lib/Target/PowerPC/PPCISelLowering.cpp +++ b/llvm/lib/Target/PowerPC/PPCISelLowering.cpp @@ -1390,10 +1390,6 @@ setTargetDAGCombine({ISD::TRUNCATE, ISD::SETCC, ISD::SELECT_CC}); } - if (Subtarget.hasP9Altivec()) { - setTargetDAGCombine({ISD::VSELECT}); - } - setLibcallName(RTLIB::LOG_F128, "logf128"); setLibcallName(RTLIB::LOG2_F128, "log2f128"); setLibcallName(RTLIB::LOG10_F128, "log10f128"); @@ -16038,8 +16034,6 @@ } case ISD::BUILD_VECTOR: return DAGCombineBuildVector(N, DCI); - case ISD::VSELECT: - return combineVSelect(N, DCI); } return SDValue(); @@ -17665,69 +17659,6 @@ return true; } -// For type v4i32/v8ii16/v16i8, transform -// from (vselect (setcc a, b, setugt), (sub a, b), (sub b, a)) to (abdu a, b) -// from (vselect (setcc a, b, setuge), (sub a, b), (sub b, a)) to (abdu a, b) -// from (vselect (setcc a, b, setult), (sub b, a), (sub a, b)) to (abdu a, b) -// from (vselect (setcc a, b, setule), (sub b, a), (sub a, b)) to (abdu a, b) -// TODO: Move this to DAGCombiner? -SDValue PPCTargetLowering::combineVSelect(SDNode *N, - DAGCombinerInfo &DCI) const { - assert((N->getOpcode() == ISD::VSELECT) && "Need VSELECT node here"); - assert(Subtarget.hasP9Altivec() && - "Only combine this when P9 altivec supported!"); - - SelectionDAG &DAG = DCI.DAG; - SDLoc dl(N); - SDValue Cond = N->getOperand(0); - SDValue TrueOpnd = N->getOperand(1); - SDValue FalseOpnd = N->getOperand(2); - EVT VT = N->getOperand(1).getValueType(); - - if (Cond.getOpcode() != ISD::SETCC || TrueOpnd.getOpcode() != ISD::SUB || - FalseOpnd.getOpcode() != ISD::SUB) - return SDValue(); - - // ABSD only available for type v4i32/v8i16/v16i8 - if (VT != MVT::v4i32 && VT != MVT::v8i16 && VT != MVT::v16i8) - return SDValue(); - - // At least to save one more dependent computation - if (!(Cond.hasOneUse() || TrueOpnd.hasOneUse() || FalseOpnd.hasOneUse())) - return SDValue(); - - ISD::CondCode CC = cast(Cond.getOperand(2))->get(); - - // Can only handle unsigned comparison here - switch (CC) { - default: - return SDValue(); - case ISD::SETUGT: - case ISD::SETUGE: - break; - case ISD::SETULT: - case ISD::SETULE: - std::swap(TrueOpnd, FalseOpnd); - break; - } - - SDValue CmpOpnd1 = Cond.getOperand(0); - SDValue CmpOpnd2 = Cond.getOperand(1); - - // SETCC CmpOpnd1 CmpOpnd2 cond - // TrueOpnd = CmpOpnd1 - CmpOpnd2 - // FalseOpnd = CmpOpnd2 - CmpOpnd1 - if (TrueOpnd.getOperand(0) == CmpOpnd1 && - TrueOpnd.getOperand(1) == CmpOpnd2 && - FalseOpnd.getOperand(0) == CmpOpnd2 && - FalseOpnd.getOperand(1) == CmpOpnd1) { - return DAG.getNode(ISD::ABDU, dl, N->getOperand(1).getValueType(), CmpOpnd1, - CmpOpnd2, DAG.getTargetConstant(0, dl, MVT::i32)); - } - - return SDValue(); -} - /// getAddrModeForFlags - Based on the set of address flags, select the most /// optimal instruction format to match by. PPC::AddrMode PPCTargetLowering::getAddrModeForFlags(unsigned Flags) const { diff --git a/llvm/test/CodeGen/AArch64/abd-combine.ll b/llvm/test/CodeGen/AArch64/abd-combine.ll --- a/llvm/test/CodeGen/AArch64/abd-combine.ll +++ b/llvm/test/CodeGen/AArch64/abd-combine.ll @@ -107,10 +107,7 @@ define <8 x i16> @abdu_ugt(<8 x i16>, <8 x i16>) { ; CHECK-LABEL: abdu_ugt: ; CHECK: // %bb.0: -; CHECK-NEXT: cmhi v2.8h, v0.8h, v1.8h -; CHECK-NEXT: sub v3.8h, v0.8h, v1.8h -; CHECK-NEXT: sub v0.8h, v1.8h, v0.8h -; CHECK-NEXT: bit v0.16b, v3.16b, v2.16b +; CHECK-NEXT: uabd v0.8h, v0.8h, v1.8h ; CHECK-NEXT: ret %3 = icmp ugt <8 x i16> %0, %1 %4 = sub <8 x i16> %0, %1 @@ -122,10 +119,7 @@ define <8 x i16> @abdu_uge(<8 x i16>, <8 x i16>) { ; CHECK-LABEL: abdu_uge: ; CHECK: // %bb.0: -; CHECK-NEXT: cmhs v2.8h, v0.8h, v1.8h -; CHECK-NEXT: sub v3.8h, v0.8h, v1.8h -; CHECK-NEXT: sub v0.8h, v1.8h, v0.8h -; CHECK-NEXT: bit v0.16b, v3.16b, v2.16b +; CHECK-NEXT: uabd v0.8h, v0.8h, v1.8h ; CHECK-NEXT: ret %3 = icmp uge <8 x i16> %0, %1 %4 = sub <8 x i16> %0, %1 @@ -137,10 +131,7 @@ define <8 x i16> @abdu_ult(<8 x i16>, <8 x i16>) { ; CHECK-LABEL: abdu_ult: ; CHECK: // %bb.0: -; CHECK-NEXT: cmhi v2.8h, v1.8h, v0.8h -; CHECK-NEXT: sub v3.8h, v0.8h, v1.8h -; CHECK-NEXT: sub v0.8h, v1.8h, v0.8h -; CHECK-NEXT: bif v0.16b, v3.16b, v2.16b +; CHECK-NEXT: uabd v0.8h, v0.8h, v1.8h ; CHECK-NEXT: ret %3 = icmp ult <8 x i16> %0, %1 %4 = sub <8 x i16> %0, %1 @@ -152,10 +143,7 @@ define <8 x i16> @abdu_ule(<8 x i16>, <8 x i16>) { ; CHECK-LABEL: abdu_ule: ; CHECK: // %bb.0: -; CHECK-NEXT: cmhs v2.8h, v1.8h, v0.8h -; CHECK-NEXT: sub v3.8h, v0.8h, v1.8h -; CHECK-NEXT: sub v0.8h, v1.8h, v0.8h -; CHECK-NEXT: bif v0.16b, v3.16b, v2.16b +; CHECK-NEXT: uabd v0.8h, v0.8h, v1.8h ; CHECK-NEXT: ret %3 = icmp ule <8 x i16> %0, %1 %4 = sub <8 x i16> %0, %1 @@ -167,10 +155,7 @@ define <8 x i16> @abds_sgt(<8 x i16>, <8 x i16>) { ; CHECK-LABEL: abds_sgt: ; CHECK: // %bb.0: -; CHECK-NEXT: cmgt v2.8h, v0.8h, v1.8h -; CHECK-NEXT: sub v3.8h, v0.8h, v1.8h -; CHECK-NEXT: sub v0.8h, v1.8h, v0.8h -; CHECK-NEXT: bit v0.16b, v3.16b, v2.16b +; CHECK-NEXT: sabd v0.8h, v0.8h, v1.8h ; CHECK-NEXT: ret %3 = icmp sgt <8 x i16> %0, %1 %4 = sub <8 x i16> %0, %1 @@ -182,10 +167,7 @@ define <8 x i16> @abds_sge(<8 x i16>, <8 x i16>) { ; CHECK-LABEL: abds_sge: ; CHECK: // %bb.0: -; CHECK-NEXT: cmge v2.8h, v0.8h, v1.8h -; CHECK-NEXT: sub v3.8h, v0.8h, v1.8h -; CHECK-NEXT: sub v0.8h, v1.8h, v0.8h -; CHECK-NEXT: bit v0.16b, v3.16b, v2.16b +; CHECK-NEXT: sabd v0.8h, v0.8h, v1.8h ; CHECK-NEXT: ret %3 = icmp sge <8 x i16> %0, %1 %4 = sub <8 x i16> %0, %1 @@ -197,10 +179,7 @@ define <8 x i16> @abds_slt(<8 x i16>, <8 x i16>) { ; CHECK-LABEL: abds_slt: ; CHECK: // %bb.0: -; CHECK-NEXT: cmgt v2.8h, v1.8h, v0.8h -; CHECK-NEXT: sub v3.8h, v0.8h, v1.8h -; CHECK-NEXT: sub v0.8h, v1.8h, v0.8h -; CHECK-NEXT: bif v0.16b, v3.16b, v2.16b +; CHECK-NEXT: sabd v0.8h, v0.8h, v1.8h ; CHECK-NEXT: ret %3 = icmp slt <8 x i16> %0, %1 %4 = sub <8 x i16> %0, %1 @@ -212,10 +191,7 @@ define <8 x i16> @abds_sle(<8 x i16>, <8 x i16>) { ; CHECK-LABEL: abds_sle: ; CHECK: // %bb.0: -; CHECK-NEXT: cmge v2.8h, v1.8h, v0.8h -; CHECK-NEXT: sub v3.8h, v0.8h, v1.8h -; CHECK-NEXT: sub v0.8h, v1.8h, v0.8h -; CHECK-NEXT: bif v0.16b, v3.16b, v2.16b +; CHECK-NEXT: sabd v0.8h, v0.8h, v1.8h ; CHECK-NEXT: ret %3 = icmp sle <8 x i16> %0, %1 %4 = sub <8 x i16> %0, %1 diff --git a/llvm/test/CodeGen/PowerPC/ppc64-P9-vabsd.ll b/llvm/test/CodeGen/PowerPC/ppc64-P9-vabsd.ll --- a/llvm/test/CodeGen/PowerPC/ppc64-P9-vabsd.ll +++ b/llvm/test/CodeGen/PowerPC/ppc64-P9-vabsd.ll @@ -1834,13 +1834,20 @@ ; Tests for ABDS icmp + sub + select sequence define <4 x i32> @absd_int32_sgt(<4 x i32>, <4 x i32>) { -; CHECK-LABEL: absd_int32_sgt: -; CHECK: # %bb.0: -; CHECK-NEXT: vcmpgtsw v4, v2, v3 -; CHECK-NEXT: vsubuwm v5, v2, v3 -; CHECK-NEXT: vsubuwm v2, v3, v2 -; CHECK-NEXT: xxsel v2, v2, v5, v4 -; CHECK-NEXT: blr +; CHECK-PWR9-LABEL: absd_int32_sgt: +; CHECK-PWR9: # %bb.0: +; CHECK-PWR9-NEXT: xvnegsp v3, v3 +; CHECK-PWR9-NEXT: xvnegsp v2, v2 +; CHECK-PWR9-NEXT: vabsduw v2, v2, v3 +; CHECK-PWR9-NEXT: blr +; +; CHECK-PWR78-LABEL: absd_int32_sgt: +; CHECK-PWR78: # %bb.0: +; CHECK-PWR78-NEXT: vcmpgtsw v4, v2, v3 +; CHECK-PWR78-NEXT: vsubuwm v5, v2, v3 +; CHECK-PWR78-NEXT: vsubuwm v2, v3, v2 +; CHECK-PWR78-NEXT: xxsel v2, v2, v5, v4 +; CHECK-PWR78-NEXT: blr %3 = icmp sgt <4 x i32> %0, %1 %4 = sub <4 x i32> %0, %1 %5 = sub <4 x i32> %1, %0 @@ -1849,14 +1856,21 @@ } define <4 x i32> @absd_int32_sge(<4 x i32>, <4 x i32>) { -; CHECK-LABEL: absd_int32_sge: -; CHECK: # %bb.0: -; CHECK-NEXT: vcmpgtsw v4, v3, v2 -; CHECK-NEXT: xxlnor vs0, v4, v4 -; CHECK-NEXT: vsubuwm v4, v2, v3 -; CHECK-NEXT: vsubuwm v2, v3, v2 -; CHECK-NEXT: xxsel v2, v2, v4, vs0 -; CHECK-NEXT: blr +; CHECK-PWR9-LABEL: absd_int32_sge: +; CHECK-PWR9: # %bb.0: +; CHECK-PWR9-NEXT: xvnegsp v3, v3 +; CHECK-PWR9-NEXT: xvnegsp v2, v2 +; CHECK-PWR9-NEXT: vabsduw v2, v2, v3 +; CHECK-PWR9-NEXT: blr +; +; CHECK-PWR78-LABEL: absd_int32_sge: +; CHECK-PWR78: # %bb.0: +; CHECK-PWR78-NEXT: vcmpgtsw v4, v3, v2 +; CHECK-PWR78-NEXT: xxlnor vs0, v4, v4 +; CHECK-PWR78-NEXT: vsubuwm v4, v2, v3 +; CHECK-PWR78-NEXT: vsubuwm v2, v3, v2 +; CHECK-PWR78-NEXT: xxsel v2, v2, v4, vs0 +; CHECK-PWR78-NEXT: blr %3 = icmp sge <4 x i32> %0, %1 %4 = sub <4 x i32> %0, %1 %5 = sub <4 x i32> %1, %0 @@ -1865,13 +1879,20 @@ } define <4 x i32> @absd_int32_slt(<4 x i32>, <4 x i32>) { -; CHECK-LABEL: absd_int32_slt: -; CHECK: # %bb.0: -; CHECK-NEXT: vcmpgtsw v4, v3, v2 -; CHECK-NEXT: vsubuwm v5, v2, v3 -; CHECK-NEXT: vsubuwm v2, v3, v2 -; CHECK-NEXT: xxsel v2, v5, v2, v4 -; CHECK-NEXT: blr +; CHECK-PWR9-LABEL: absd_int32_slt: +; CHECK-PWR9: # %bb.0: +; CHECK-PWR9-NEXT: xvnegsp v3, v3 +; CHECK-PWR9-NEXT: xvnegsp v2, v2 +; CHECK-PWR9-NEXT: vabsduw v2, v2, v3 +; CHECK-PWR9-NEXT: blr +; +; CHECK-PWR78-LABEL: absd_int32_slt: +; CHECK-PWR78: # %bb.0: +; CHECK-PWR78-NEXT: vcmpgtsw v4, v3, v2 +; CHECK-PWR78-NEXT: vsubuwm v5, v2, v3 +; CHECK-PWR78-NEXT: vsubuwm v2, v3, v2 +; CHECK-PWR78-NEXT: xxsel v2, v5, v2, v4 +; CHECK-PWR78-NEXT: blr %3 = icmp slt <4 x i32> %0, %1 %4 = sub <4 x i32> %0, %1 %5 = sub <4 x i32> %1, %0 @@ -1880,14 +1901,21 @@ } define <4 x i32> @absd_int32_sle(<4 x i32>, <4 x i32>) { -; CHECK-LABEL: absd_int32_sle: -; CHECK: # %bb.0: -; CHECK-NEXT: vcmpgtsw v4, v2, v3 -; CHECK-NEXT: xxlnor vs0, v4, v4 -; CHECK-NEXT: vsubuwm v4, v2, v3 -; CHECK-NEXT: vsubuwm v2, v3, v2 -; CHECK-NEXT: xxsel v2, v4, v2, vs0 -; CHECK-NEXT: blr +; CHECK-PWR9-LABEL: absd_int32_sle: +; CHECK-PWR9: # %bb.0: +; CHECK-PWR9-NEXT: xvnegsp v3, v3 +; CHECK-PWR9-NEXT: xvnegsp v2, v2 +; CHECK-PWR9-NEXT: vabsduw v2, v2, v3 +; CHECK-PWR9-NEXT: blr +; +; CHECK-PWR78-LABEL: absd_int32_sle: +; CHECK-PWR78: # %bb.0: +; CHECK-PWR78-NEXT: vcmpgtsw v4, v2, v3 +; CHECK-PWR78-NEXT: xxlnor vs0, v4, v4 +; CHECK-PWR78-NEXT: vsubuwm v4, v2, v3 +; CHECK-PWR78-NEXT: vsubuwm v2, v3, v2 +; CHECK-PWR78-NEXT: xxsel v2, v4, v2, vs0 +; CHECK-PWR78-NEXT: blr %3 = icmp sle <4 x i32> %0, %1 %4 = sub <4 x i32> %0, %1 %5 = sub <4 x i32> %1, %0