Index: clang-tidy/modernize/LoopConvertUtils.cpp =================================================================== --- clang-tidy/modernize/LoopConvertUtils.cpp +++ clang-tidy/modernize/LoopConvertUtils.cpp @@ -820,14 +820,14 @@ if (Len > 1 && ContainerName.endswith(Style == NS_UpperCase ? "S" : "s")) { IteratorName = ContainerName.substr(0, Len - 1); // E.g.: (auto thing : things) - if (!declarationExists(IteratorName)) + if (!declarationExists(IteratorName) || IteratorName == OldIndex->getName()) return IteratorName; } if (Len > 2 && ContainerName.endswith(Style == NS_UpperCase ? "S_" : "s_")) { IteratorName = ContainerName.substr(0, Len - 2); // E.g.: (auto thing : things_) - if (!declarationExists(IteratorName)) + if (!declarationExists(IteratorName) || IteratorName == OldIndex->getName()) return IteratorName; } @@ -849,12 +849,12 @@ IteratorName = AppendWithStyle(ContainerName, OldIndex->getName()); // E.g.: (auto container_i : container) - if (!declarationExists(IteratorName)) + if (!declarationExists(IteratorName) || IteratorName == OldIndex->getName()) return IteratorName; IteratorName = AppendWithStyle(ContainerName, Elem); // E.g.: (auto container_elem : container) - if (!declarationExists(IteratorName)) + if (!declarationExists(IteratorName) || IteratorName == OldIndex->getName()) return IteratorName; // Someone defeated my naming scheme... @@ -875,7 +875,8 @@ int Attempt = 0; do { IteratorName = GiveMeName + std::to_string(Attempt++); - } while (declarationExists(IteratorName)); + } while (declarationExists(IteratorName) || + IteratorName == OldIndex->getName()); return IteratorName; } Index: test/clang-tidy/modernize-loop-convert-extra.cpp =================================================================== --- test/clang-tidy/modernize-loop-convert-extra.cpp +++ test/clang-tidy/modernize-loop-convert-extra.cpp @@ -325,6 +325,23 @@ // CHECK-FIXES-NEXT: (void)NumsI; } +void oldIndexConflict() { + for (int Num = 0; Num < N; ++Num) { + printf("Num: %d\n", Nums[Num]); + } + // CHECK-MESSAGES: :[[@LINE-3]]:3: warning: use range-based for loop instead + // CHECK-FIXES: for (int Num : Nums) + // CHECK-FIXES-NEXT: printf("Num: %d\n", Num); + + S Things; + for (S::iterator Thing = Things.begin(), End = Things.end(); Thing != End; ++Thing) { + printf("Thing: %d %d\n", Thing->X, (*Thing).X); + } + // CHECK-MESSAGES: :[[@LINE-3]]:3: warning: use range-based for loop instead + // CHECK-FIXES: for (auto & Thing : Things) + // CHECK-FIXES-NEXT: printf("Thing: %d %d\n", Thing.X, Thing.X); +} + void macroConflict() { S MAXs; for (S::iterator It = MAXs.begin(), E = MAXs.end(); It != E; ++It) {