diff --git a/llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp b/llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp --- a/llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp +++ b/llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp @@ -1180,6 +1180,7 @@ Constant::getNullValue(VNodesTy), getInstrProfVNodesVarName()); VNodesVar->setSection( getInstrProfSectionName(IPSK_vnodes, TT.getObjectFormat())); + VNodesVar->setAlignment(M->getDataLayout().getABITypeAlign(VNodesTy)); // VNodesVar is used by runtime but not referenced via relocation by other // sections. Conservatively make it linker retained. UsedVars.push_back(VNodesVar); diff --git a/llvm/test/Instrumentation/InstrProfiling/align32.ll b/llvm/test/Instrumentation/InstrProfiling/align32.ll new file mode 100644 --- /dev/null +++ b/llvm/test/Instrumentation/InstrProfiling/align32.ll @@ -0,0 +1,38 @@ +;; Check that the prf_vnodes variable has the correct alignment +;; when pointers are 4 byte long. +; RUN: opt %s -passes=instrprof -S | FileCheck %s --check-prefix=ALIGN32 + +target datalayout = "e-m:e-p:32:32-p270:32:32-p271:32:32-p272:64:64-f64:32:64-f80:32-n8:16:32-S128" +target triple = "i386-unknown-linux-gnu" + +@__profn_foo = private constant [3 x i8] c"foo" +@__profn_bar = private constant [3 x i8] c"bar" + +define i32 @foo(ptr ) { + call void @llvm.instrprof.increment(ptr @__profn_foo, i64 12884901887, i32 1, i32 0) + %2 = ptrtoint ptr %0 to i64 + call void @llvm.instrprof.value.profile(ptr @__profn_foo, i64 12884901887, i64 %2, i32 0, i32 0) + %3 = tail call i32 %0() + ret i32 %3 +} + +$bar = comdat any + +define i32 @bar(ptr ) comdat { +entry: + call void @llvm.instrprof.increment(ptr @__profn_bar, i64 12884901887, i32 1, i32 0) + %1 = ptrtoint ptr %0 to i64 + call void @llvm.instrprof.value.profile(ptr @__profn_bar, i64 12884901887, i64 %1, i32 0, i32 0) + %2 = tail call i32 %0() + ret i32 %2 +} + +; Function Attrs: nounwind +declare void @llvm.instrprof.increment(ptr, i64, i32, i32) #0 + +; Function Attrs: nounwind +declare void @llvm.instrprof.value.profile(ptr, i64, i64, i32, i32) #0 + +attributes #0 = { nounwind } + +; ALIGN32: @__llvm_prf_vnodes = private global {{.*}} section "__llvm_prf_vnds", align 4 diff --git a/llvm/test/Instrumentation/InstrProfiling/icall-comdat.ll b/llvm/test/Instrumentation/InstrProfiling/icall-comdat.ll --- a/llvm/test/Instrumentation/InstrProfiling/icall-comdat.ll +++ b/llvm/test/Instrumentation/InstrProfiling/icall-comdat.ll @@ -10,7 +10,11 @@ ; RUN: opt < %s -mtriple=mips64-unknown-linux -passes=instrprof -vp-static-alloc=true -S | FileCheck %s --check-prefix=STATIC-SEXT ; RUN: opt < %s -mtriple=x86_64-unknown-linux -passes=instrprof -vp-static-alloc=false -S | FileCheck %s --check-prefix=DYN - +;; Check that counters have the correct alignments. +; RUN: opt %s -mtriple=powerpc64-unknown-linux -passes=instrprof -S | FileCheck %s --check-prefix=ALIGN +; RUN: opt %s -mtriple=powerpc-ibm-aix -passes=instrprof -S | FileCheck %s --check-prefix=ALIGN +; RUN: opt %s -mtriple=powerpc64-ibm-aix -passes=instrprof -S | FileCheck %s --check-prefix=ALIGN +; RUN: opt %s -mtriple=x86_64-unknown-linux -passes=instrprof -S | FileCheck %s --check-prefix=ALIGN @__profn_foo = private constant [3 x i8] c"foo" @__profn_bar = private constant [3 x i8] c"bar" @@ -62,3 +66,12 @@ ; STATIC: declare void @__llvm_profile_instrument_target(i64, ptr, i32) ; STATIC-EXT: declare void @__llvm_profile_instrument_target(i64, ptr, i32 zeroext) ; STATIC-SEXT: declare void @__llvm_profile_instrument_target(i64, ptr, i32 signext) + +; ALIGN: @__profc_foo = private global {{.*}} section "__llvm_prf_cnts",{{.*}} align 8 +; ALIGN: @__profvp_foo = private global {{.*}} section "__llvm_prf_vals",{{.*}} align 8 +; ALIGN: @__profd_foo = private global {{.*}} section "__llvm_prf_data",{{.*}} align 8 +; ALIGN: @__profc_bar = private global {{.*}} section "__llvm_prf_cnts",{{.*}} align 8 +; ALIGN: @__profvp_bar = private global {{.*}} section "__llvm_prf_vals",{{.*}} align 8 +; ALIGN: @__profd_bar = private global {{.*}} section "__llvm_prf_data",{{.*}} align 8 +; ALIGN: @__llvm_prf_vnodes = private global {{.*}} section "__llvm_prf_vnds", align 8 +; ALIGN: @__llvm_prf_nm = private constant {{.*}} section "__llvm_prf_names", align 1