This is an archive of the discontinued LLVM Phabricator instance.

Make lldb::endian::InlHostByteOrder() private.
ClosedPublic

Authored by brucem on Nov 5 2015, 8:41 PM.

Details

Summary

Since this is within the lldb namespace, the compiler tries to
export a symbol for it. Unfortunately, since it is inlined, the
symbol is hidden and this results in a mess of warnings when
building on OS X with cmake.

Moving it to the lldb_private namespace eliminates that problem.

Diff Detail

Repository
rL LLVM

Event Timeline

brucem updated this revision to Diff 39473.Nov 5 2015, 8:41 PM
brucem retitled this revision from to Make lldb::endian::InlHostByteOrder() private..
brucem updated this object.
brucem added a reviewer: clayborg.
brucem added a subscriber: lldb-commits.
clayborg accepted this revision.Nov 6 2015, 12:52 PM
clayborg edited edge metadata.
This revision is now accepted and ready to land.Nov 6 2015, 12:52 PM
This revision was automatically updated to reflect the committed changes.