diff --git a/clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp --- a/clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp +++ b/clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp @@ -68,6 +68,19 @@ /// to us. If he doesn't, he performs additional invalidations. enum InvalidationKind { NoEvalCall, EvalCallAsPure }; + /// Given a range, should the argument stay inside or outside this range? + enum RangeKind { OutOfRange, WithinRange }; + + static RangeKind negateKind(RangeKind K) { + switch (K) { + case OutOfRange: + return WithinRange; + case WithinRange: + return OutOfRange; + } + llvm_unreachable("Unknown range kind"); + } + // The universal integral type to use in value range descriptions. // Unsigned to make sure overflows are well-defined. typedef uint64_t RangeInt; @@ -82,9 +95,11 @@ /// ArgNo in CallExpr and CallEvent is defined as Unsigned, but /// obviously uint32_t should be enough for all practical purposes. typedef uint32_t ArgNo; + /// Special argument number for specifying the return value. static const ArgNo Ret; using DescString = SmallString<96>; + /// Returns the string representation of an argument index. /// E.g.: (1) -> '1st arg', (2) - > '2nd arg' static SmallString<8> getArgDesc(ArgNo); @@ -102,10 +117,12 @@ class ValueConstraint; // Pointer to the ValueConstraint. We need a copyable, polymorphic and - // default initialize able type (vector needs that). A raw pointer was good, + // default initializable type (vector needs that). A raw pointer was good, // however, we cannot default initialize that. unique_ptr makes the Summary // class non-copyable, therefore not an option. Releasing the copyability // requirement would render the initialization of the Summary map infeasible. + // A new value constraint is created furthermore by the negate functionality + // of the constraint and returned as pointer. using ValueConstraintPtr = std::shared_ptr; /// Polymorphic base class that represents a constraint on a given argument @@ -122,35 +139,12 @@ public: ValueConstraint(ArgNo ArgN) : ArgN(ArgN) {} virtual ~ValueConstraint() {} + /// Apply the effects of the constraint on the given program state. If null /// is returned then the constraint is not feasible. virtual ProgramStateRef apply(ProgramStateRef State, const CallEvent &Call, const Summary &Summary, CheckerContext &C) const = 0; - virtual ValueConstraintPtr negate() const { - llvm_unreachable("Not implemented"); - }; - - /// Check whether the constraint is malformed or not. It is malformed if the - /// specified argument has a mismatch with the given FunctionDecl (e.g. the - /// arg number is out-of-range of the function's argument list). - bool checkValidity(const FunctionDecl *FD) const { - const bool ValidArg = ArgN == Ret || ArgN < FD->getNumParams(); - assert(ValidArg && "Arg out of range!"); - if (!ValidArg) - return false; - // Subclasses may further refine the validation. - return checkSpecificValidity(FD); - } - ArgNo getArgNo() const { return ArgN; } - - /// Return those arguments that should be tracked when we report a bug. By - /// default it is the argument that is constrained, however, in some special - /// cases we need to track other arguments as well. E.g. a buffer size might - /// be encoded in another argument. - virtual std::vector getArgsToTrack() const { return {ArgN}; } - - virtual StringRef getName() const = 0; /// Represents that in which context do we require a description of the /// constraint. @@ -158,6 +152,8 @@ /// The constraint is violated. Violation, /// We assume that the constraint is satisfied. + /// This can be used when a precondition is satisfied, or when a summary + /// case is applied. Assumption }; @@ -174,81 +170,96 @@ "Description not implemented for summary case constraints"); } - protected: - ArgNo ArgN; // Argument to which we apply the constraint. + /// Return those arguments that should be tracked when we report a bug about + /// argument constraint violation. By default it is the argument that is + /// constrained, however, in some special cases we need to track other + /// arguments as well. E.g. a buffer size might be encoded in another + /// argument. + /// The "return value" argument number can not occur as returned value. + virtual std::vector getArgsToTrack() const { return {ArgN}; } - /// Do polymorphic validation check on the constraint. + /// Get a constraint that represents exactly the opposite of the current. + virtual ValueConstraintPtr negate() const { + llvm_unreachable("Not implemented"); + }; + + /// Check whether the constraint is malformed or not. It is malformed if the + /// specified argument has a mismatch with the given FunctionDecl (e.g. the + /// arg number is out-of-range of the function's argument list). + /// This condition can indicate if a probably wrong or unexpected function + /// was found where the constraint is to be applied. + bool checkValidity(const FunctionDecl *FD) const { + const bool ValidArg = ArgN == Ret || ArgN < FD->getNumParams(); + assert(ValidArg && "Arg out of range!"); + if (!ValidArg) + return false; + // Subclasses may further refine the validation. + return checkSpecificValidity(FD); + } + + /// Return the argument number (may be placeholder for "return value"). + ArgNo getArgNo() const { return ArgN; } + + protected: + /// Argument to which to apply the constraint. It can be a real argument of + /// the function to check, or a special value to indicate the return value + /// of the function. + /// Every constraint is assigned to one main argument, even if other + /// arguments are involved. + ArgNo ArgN; + + /// Do constraint-specific validation check. virtual bool checkSpecificValidity(const FunctionDecl *FD) const { return true; } }; - /// Given a range, should the argument stay inside or outside this range? - enum RangeKind { OutOfRange, WithinRange }; - - /// Encapsulates a range on a single symbol. + /// Check if a single argument falls into a specific range. + /// The "range" can be built from sub-ranges that are closed intervals. class RangeConstraint : public ValueConstraint { + /// The constraint can be specified by allowing or disallowing the range. + /// WithinRange indicates allowing the range, OutOfRange indicates + /// disallowing it. RangeKind Kind; - // A range is formed as a set of intervals (sub-ranges). - // E.g. {['A', 'Z'], ['a', 'z']} - // - // The default constructed RangeConstraint has an empty range set, applying - // such constraint does not involve any assumptions, thus the State remains - // unchanged. This is meaningful, if the range is dependent on a looked up - // type (e.g. [0, Socklen_tMax]). If the type is not found, then the range - // is default initialized to be empty. + + /// A range is formed as a set of intervals (sub-ranges). + /// E.g. {['A', 'Z'], ['a', 'z']} + /// + /// The default constructed RangeConstraint has an empty range set, applying + /// such constraint does not involve any assumptions, thus the State remains + /// unchanged. This is meaningful, if the range is dependent on a looked up + /// type (e.g. [0, Socklen_tMax]). If the type is not found, then the range + /// is default initialized to be empty. IntRangeVector Ranges; - // A textual description of this constraint for the specific case where the - // constraint is used. If empty a generated description will be used. + + /// A textual description of this constraint for the specific case where the + /// constraint is used. If empty a generated description will be used that + /// is built from the range of the constraint. StringRef Description; public: - StringRef getName() const override { return "Range"; } RangeConstraint(ArgNo ArgN, RangeKind Kind, const IntRangeVector &Ranges, StringRef Desc = "") : ValueConstraint(ArgN), Kind(Kind), Ranges(Ranges), Description(Desc) { } - std::string describe(DescriptionKind DK, const CallEvent &Call, - ProgramStateRef State, - const Summary &Summary) const override; - const IntRangeVector &getRanges() const { return Ranges; } - private: - ProgramStateRef applyAsOutOfRange(ProgramStateRef State, - const CallEvent &Call, - const Summary &Summary) const; - ProgramStateRef applyAsWithinRange(ProgramStateRef State, - const CallEvent &Call, - const Summary &Summary) const; - - public: ProgramStateRef apply(ProgramStateRef State, const CallEvent &Call, const Summary &Summary, - CheckerContext &C) const override { - switch (Kind) { - case OutOfRange: - return applyAsOutOfRange(State, Call, Summary); - case WithinRange: - return applyAsWithinRange(State, Call, Summary); - } - llvm_unreachable("Unknown range kind!"); - } + CheckerContext &C) const override; + + std::string describe(DescriptionKind DK, const CallEvent &Call, + ProgramStateRef State, + const Summary &Summary) const override; ValueConstraintPtr negate() const override { RangeConstraint Tmp(*this); - switch (Kind) { - case OutOfRange: - Tmp.Kind = WithinRange; - break; - case WithinRange: - Tmp.Kind = OutOfRange; - break; - } + Tmp.Kind = negateKind(Kind); return std::make_shared(Tmp); } + protected: bool checkSpecificValidity(const FunctionDecl *FD) const override { const bool ValidArg = getArgType(FD, ArgN)->isIntegralType(FD->getASTContext()); @@ -256,14 +267,40 @@ "This constraint should be applied on an integral type"); return ValidArg; } + + private: + using RangeApplyFunction = std::function; + + /// @brief Apply a function on all intervals in the range. + void applyOnWithinRange( + BasicValueFactory &BVF, QualType ArgT, + const RangeApplyFunction &F) const; + /// @brief Apply a function on all intervals in the complement range. + void applyOnOutOfRange( + BasicValueFactory &BVF, QualType ArgT, + const RangeApplyFunction &F) const; + /// @brief Apply a function on all intervals of the range or the complement + /// range. + void applyOnRange(RangeKind Kind, + BasicValueFactory &BVF, QualType ArgT, + const RangeApplyFunction &F) const { + switch (Kind) { + case OutOfRange: + applyOnOutOfRange(BVF, ArgT, F); + break; + case WithinRange: + applyOnWithinRange(BVF, ArgT, F); + break; + }; + } }; + /// Check relation of an argument to another. class ComparisonConstraint : public ValueConstraint { BinaryOperator::Opcode Opcode; ArgNo OtherArgN; public: - StringRef getName() const override { return "Comparison"; }; ComparisonConstraint(ArgNo ArgN, BinaryOperator::Opcode Opcode, ArgNo OtherArgN) : ValueConstraint(ArgN), Opcode(Opcode), OtherArgN(OtherArgN) {} @@ -274,6 +311,7 @@ CheckerContext &C) const override; }; + /// Check null or non-null-ness of an argument that is of pointer type. class NotNullConstraint : public ValueConstraint { using ValueConstraint::ValueConstraint; // This variable has a role when we negate the constraint. @@ -282,23 +320,14 @@ public: NotNullConstraint(ArgNo ArgN, bool CannotBeNull = true) : ValueConstraint(ArgN), CannotBeNull(CannotBeNull) {} - std::string describe(DescriptionKind DK, const CallEvent &Call, - ProgramStateRef State, - const Summary &Summary) const override; - StringRef getName() const override { return "NonNull"; } + ProgramStateRef apply(ProgramStateRef State, const CallEvent &Call, const Summary &Summary, - CheckerContext &C) const override { - SVal V = getArgSVal(Call, getArgNo()); - if (V.isUndef()) - return State; - - DefinedOrUnknownSVal L = V.castAs(); - if (!isa(L)) - return State; + CheckerContext &C) const override; - return State->assume(L, CannotBeNull); - } + std::string describe(DescriptionKind DK, const CallEvent &Call, + ProgramStateRef State, + const Summary &Summary) const override; ValueConstraintPtr negate() const override { NotNullConstraint Tmp(*this); @@ -306,6 +335,7 @@ return std::make_shared(Tmp); } + protected: bool checkSpecificValidity(const FunctionDecl *FD) const override { const bool ValidArg = getArgType(FD, ArgN)->isPointerType(); assert(ValidArg && @@ -337,7 +367,6 @@ BinaryOperator::Opcode Op = BO_LE; public: - StringRef getName() const override { return "BufferSize"; } BufferSizeConstraint(ArgNo Buffer, llvm::APSInt BufMinSize) : ValueConstraint(Buffer), ConcreteSize(BufMinSize) {} BufferSizeConstraint(ArgNo Buffer, ArgNo BufSize) @@ -346,6 +375,14 @@ : ValueConstraint(Buffer), SizeArgN(BufSize), SizeMultiplierArgN(BufSizeMultiplier) {} + ProgramStateRef apply(ProgramStateRef State, const CallEvent &Call, + const Summary &Summary, + CheckerContext &C) const override; + + std::string describe(DescriptionKind DK, const CallEvent &Call, + ProgramStateRef State, + const Summary &Summary) const override; + std::vector getArgsToTrack() const override { std::vector Result{ArgN}; if (SizeArgN) @@ -355,58 +392,13 @@ return Result; } - std::string describe(DescriptionKind DK, const CallEvent &Call, - ProgramStateRef State, - const Summary &Summary) const override; - - ProgramStateRef apply(ProgramStateRef State, const CallEvent &Call, - const Summary &Summary, - CheckerContext &C) const override { - SValBuilder &SvalBuilder = C.getSValBuilder(); - // The buffer argument. - SVal BufV = getArgSVal(Call, getArgNo()); - - // Get the size constraint. - const SVal SizeV = [this, &State, &Call, &Summary, &SvalBuilder]() { - if (ConcreteSize) { - return SVal(SvalBuilder.makeIntVal(*ConcreteSize)); - } - assert(SizeArgN && "The constraint must be either a concrete value or " - "encoded in an argument."); - // The size argument. - SVal SizeV = getArgSVal(Call, *SizeArgN); - // Multiply with another argument if given. - if (SizeMultiplierArgN) { - SVal SizeMulV = getArgSVal(Call, *SizeMultiplierArgN); - SizeV = SvalBuilder.evalBinOp(State, BO_Mul, SizeV, SizeMulV, - Summary.getArgType(*SizeArgN)); - } - return SizeV; - }(); - - // The dynamic size of the buffer argument, got from the analyzer engine. - SVal BufDynSize = getDynamicExtentWithOffset(State, BufV); - - SVal Feasible = SvalBuilder.evalBinOp(State, Op, SizeV, BufDynSize, - SvalBuilder.getContext().BoolTy); - if (auto F = Feasible.getAs()) - return State->assume(*F, true); - - // We can get here only if the size argument or the dynamic size is - // undefined. But the dynamic size should never be undefined, only - // unknown. So, here, the size of the argument is undefined, i.e. we - // cannot apply the constraint. Actually, other checkers like - // CallAndMessage should catch this situation earlier, because we call a - // function with an uninitialized argument. - llvm_unreachable("Size argument or the dynamic size is Undefined"); - } - ValueConstraintPtr negate() const override { BufferSizeConstraint Tmp(*this); Tmp.Op = BinaryOperator::negateComparisonOp(Op); return std::make_shared(Tmp); } + protected: bool checkSpecificValidity(const FunctionDecl *FD) const override { const bool ValidArg = getArgType(FD, ArgN)->isPointerType(); assert(ValidArg && @@ -758,7 +750,7 @@ void initFunctionSummaries(CheckerContext &C) const; void reportBug(const CallEvent &Call, ExplodedNode *N, - const ValueConstraint *VC, const Summary &Summary, + const ValueConstraint *VC, const ValueConstraint *NegatedVC, const Summary &Summary, CheckerContext &C) const { if (!ChecksEnabled[CK_StdCLibraryFunctionArgsChecker]) return; @@ -897,17 +889,83 @@ } } -std::string StdLibraryFunctionsChecker::NotNullConstraint::describe( - DescriptionKind DK, const CallEvent &Call, ProgramStateRef State, - const Summary &Summary) const { - SmallString<48> Result; - const auto Violation = ValueConstraint::DescriptionKind::Violation; - Result += "the "; - Result += getArgDesc(ArgN); - Result += " to '"; - Result += getFunctionName(Call); - Result += DK == Violation ? "' should not be NULL" : "' is not NULL"; - return Result.c_str(); +void StdLibraryFunctionsChecker::RangeConstraint::applyOnWithinRange( + BasicValueFactory &BVF, QualType ArgT, const RangeApplyFunction &F) const { + if (Ranges.empty()) + return; + + const IntRangeVector &R = getRanges(); + size_t E = R.size(); + for (size_t I = 0; I != E; ++I) { + const llvm::APSInt &Min = BVF.getValue(R[I].first, ArgT); + const llvm::APSInt &Max = BVF.getValue(R[I].second, ArgT); + assert(Min <= Max); + if (!F(Min, Max, I == E - 1)) + return; + } +} + +void StdLibraryFunctionsChecker::RangeConstraint::applyOnOutOfRange( + BasicValueFactory &BVF, QualType ArgT, const RangeApplyFunction &F) const { + if (Ranges.empty()) + return; + + // Cut off [T_MIN, min(R) - 1] and [max(R) + 1, T_MAX] if necessary, + // and then cut away all holes in R one by one. + // + // E.g. consider a range list R as [A, B] and [C, D] + // -------+--------+------------------+------------+-----------> + // A B C D + // We get the ranges [-inf, A - 1], [D + 1, +inf], [B + 1, C - 1]. + const IntRangeVector &R = getRanges(); + size_t E = R.size(); + + const llvm::APSInt &MinusInf = BVF.getMinValue(ArgT); + const llvm::APSInt &PlusInf = BVF.getMaxValue(ArgT); + + const llvm::APSInt &Left = BVF.getValue(R[0].first - 1ULL, ArgT); + const llvm::APSInt &Right = BVF.getValue(R[E - 1].second + 1ULL, ArgT); + bool LeftLimited = Left != PlusInf; + bool RightLimited = Right != MinusInf; + + for (size_t I = 1; I != E; ++I) { + const llvm::APSInt &Min = BVF.getValue(R[I - 1].second + 1ULL, ArgT); + const llvm::APSInt &Max = BVF.getValue(R[I].first - 1ULL, ArgT); + if (Min <= Max) { + if (!F(Min, Max, !LeftLimited && !RightLimited && I == E - 1)) + return; + } + } + if (LeftLimited) { + assert(MinusInf <= Left); + if (!F(MinusInf, Left, !RightLimited)) + return; + } + if (RightLimited) { + assert(Right <= PlusInf); + if (!F(Right, PlusInf, true)) + return; + } +} + +ProgramStateRef StdLibraryFunctionsChecker::RangeConstraint::apply(ProgramStateRef State, const CallEvent &Call, + const Summary &Summary, + CheckerContext &C) const { + ConstraintManager &CM = C.getConstraintManager(); + SVal V = getArgSVal(Call, getArgNo()); + QualType T = Summary.getArgType(getArgNo()); + + if (auto N = V.getAs()) { + auto ExcludeRangeFromArg = [&](const llvm::APSInt &Min, const llvm::APSInt &Max, bool) { + State = CM.assumeInclusiveRange(State, *N, Min, Max, false); + return static_cast(State); + }; + // "OutOfRange R" is handled by excluding all ranges in R. + // "WithinRange R" is treated as "OutOfRange [T_MIN, T_MAX] \ R". + applyOnRange(negateKind(Kind), C.getSValBuilder().getBasicValueFactory(), T, ExcludeRangeFromArg); + } + + return State; } std::string StdLibraryFunctionsChecker::RangeConstraint::describe( @@ -915,10 +973,10 @@ const Summary &Summary) const { BasicValueFactory &BVF = getBVF(State); - QualType T = Summary.getArgType(getArgNo()); DescString Result; const auto Violation = ValueConstraint::DescriptionKind::Violation; + Result += "the "; Result += getArgDesc(ArgN); Result += " to '"; @@ -948,6 +1006,97 @@ return Result.c_str(); } +ProgramStateRef StdLibraryFunctionsChecker::ComparisonConstraint::apply( + ProgramStateRef State, const CallEvent &Call, const Summary &Summary, + CheckerContext &C) const { + + ProgramStateManager &Mgr = State->getStateManager(); + SValBuilder &SVB = Mgr.getSValBuilder(); + QualType CondT = SVB.getConditionType(); + QualType T = Summary.getArgType(getArgNo()); + SVal V = getArgSVal(Call, getArgNo()); + + BinaryOperator::Opcode Op = getOpcode(); + ArgNo OtherArg = getOtherArgNo(); + SVal OtherV = getArgSVal(Call, OtherArg); + QualType OtherT = Summary.getArgType(OtherArg); + // Note: we avoid integral promotion for comparison. + OtherV = SVB.evalCast(OtherV, T, OtherT); + if (auto CompV = SVB.evalBinOp(State, Op, V, OtherV, CondT) + .getAs()) + State = State->assume(*CompV, true); + return State; +} + +ProgramStateRef StdLibraryFunctionsChecker::NotNullConstraint::apply(ProgramStateRef State, const CallEvent &Call, + const Summary &Summary, + CheckerContext &C) const { + SVal V = getArgSVal(Call, getArgNo()); + if (V.isUndef()) + return State; + + DefinedOrUnknownSVal L = V.castAs(); + if (!isa(L)) + return State; + + return State->assume(L, CannotBeNull); +} + +std::string StdLibraryFunctionsChecker::NotNullConstraint::describe( + DescriptionKind DK, const CallEvent &Call, ProgramStateRef State, + const Summary &Summary) const { + SmallString<48> Result; + const auto Violation = ValueConstraint::DescriptionKind::Violation; + Result += "the "; + Result += getArgDesc(ArgN); + Result += " to '"; + Result += getFunctionName(Call); + Result += DK == Violation ? "' should not be NULL" : "' is not NULL"; + return Result.c_str(); +} + +ProgramStateRef StdLibraryFunctionsChecker::BufferSizeConstraint::apply(ProgramStateRef State, const CallEvent &Call, + const Summary &Summary, + CheckerContext &C) const { + SValBuilder &SvalBuilder = C.getSValBuilder(); + // The buffer argument. + SVal BufV = getArgSVal(Call, getArgNo()); + + // Get the size constraint. + const SVal SizeV = [this, &State, &Call, &Summary, &SvalBuilder]() { + if (ConcreteSize) { + return SVal(SvalBuilder.makeIntVal(*ConcreteSize)); + } + assert(SizeArgN && "The constraint must be either a concrete value or " + "encoded in an argument."); + // The size argument. + SVal SizeV = getArgSVal(Call, *SizeArgN); + // Multiply with another argument if given. + if (SizeMultiplierArgN) { + SVal SizeMulV = getArgSVal(Call, *SizeMultiplierArgN); + SizeV = SvalBuilder.evalBinOp(State, BO_Mul, SizeV, SizeMulV, + Summary.getArgType(*SizeArgN)); + } + return SizeV; + }(); + + // The dynamic size of the buffer argument, got from the analyzer engine. + SVal BufDynSize = getDynamicExtentWithOffset(State, BufV); + + SVal Feasible = SvalBuilder.evalBinOp(State, Op, SizeV, BufDynSize, + SvalBuilder.getContext().BoolTy); + if (auto F = Feasible.getAs()) + return State->assume(*F, true); + + // We can get here only if the size argument or the dynamic size is + // undefined. But the dynamic size should never be undefined, only + // unknown. So, here, the size of the argument is undefined, i.e. we + // cannot apply the constraint. Actually, other checkers like + // CallAndMessage should catch this situation earlier, because we call a + // function with an uninitialized argument. + llvm_unreachable("Size argument or the dynamic size is Undefined"); +} + std::string StdLibraryFunctionsChecker::BufferSizeConstraint::describe( DescriptionKind DK, const CallEvent &Call, ProgramStateRef State, const Summary &Summary) const { @@ -972,116 +1121,6 @@ return Result.c_str(); } -ProgramStateRef StdLibraryFunctionsChecker::RangeConstraint::applyAsOutOfRange( - ProgramStateRef State, const CallEvent &Call, - const Summary &Summary) const { - if (Ranges.empty()) - return State; - - ProgramStateManager &Mgr = State->getStateManager(); - SValBuilder &SVB = Mgr.getSValBuilder(); - BasicValueFactory &BVF = SVB.getBasicValueFactory(); - ConstraintManager &CM = Mgr.getConstraintManager(); - QualType T = Summary.getArgType(getArgNo()); - SVal V = getArgSVal(Call, getArgNo()); - - if (auto N = V.getAs()) { - const IntRangeVector &R = getRanges(); - size_t E = R.size(); - for (size_t I = 0; I != E; ++I) { - const llvm::APSInt &Min = BVF.getValue(R[I].first, T); - const llvm::APSInt &Max = BVF.getValue(R[I].second, T); - assert(Min <= Max); - State = CM.assumeInclusiveRange(State, *N, Min, Max, false); - if (!State) - break; - } - } - - return State; -} - -ProgramStateRef StdLibraryFunctionsChecker::RangeConstraint::applyAsWithinRange( - ProgramStateRef State, const CallEvent &Call, - const Summary &Summary) const { - if (Ranges.empty()) - return State; - - ProgramStateManager &Mgr = State->getStateManager(); - SValBuilder &SVB = Mgr.getSValBuilder(); - BasicValueFactory &BVF = SVB.getBasicValueFactory(); - ConstraintManager &CM = Mgr.getConstraintManager(); - QualType T = Summary.getArgType(getArgNo()); - SVal V = getArgSVal(Call, getArgNo()); - - // "WithinRange R" is treated as "outside [T_MIN, T_MAX] \ R". - // We cut off [T_MIN, min(R) - 1] and [max(R) + 1, T_MAX] if necessary, - // and then cut away all holes in R one by one. - // - // E.g. consider a range list R as [A, B] and [C, D] - // -------+--------+------------------+------------+-----------> - // A B C D - // Then we assume that the value is not in [-inf, A - 1], - // then not in [D + 1, +inf], then not in [B + 1, C - 1] - if (auto N = V.getAs()) { - const IntRangeVector &R = getRanges(); - size_t E = R.size(); - - const llvm::APSInt &MinusInf = BVF.getMinValue(T); - const llvm::APSInt &PlusInf = BVF.getMaxValue(T); - - const llvm::APSInt &Left = BVF.getValue(R[0].first - 1ULL, T); - if (Left != PlusInf) { - assert(MinusInf <= Left); - State = CM.assumeInclusiveRange(State, *N, MinusInf, Left, false); - if (!State) - return nullptr; - } - - const llvm::APSInt &Right = BVF.getValue(R[E - 1].second + 1ULL, T); - if (Right != MinusInf) { - assert(Right <= PlusInf); - State = CM.assumeInclusiveRange(State, *N, Right, PlusInf, false); - if (!State) - return nullptr; - } - - for (size_t I = 1; I != E; ++I) { - const llvm::APSInt &Min = BVF.getValue(R[I - 1].second + 1ULL, T); - const llvm::APSInt &Max = BVF.getValue(R[I].first - 1ULL, T); - if (Min <= Max) { - State = CM.assumeInclusiveRange(State, *N, Min, Max, false); - if (!State) - return nullptr; - } - } - } - - return State; -} - -ProgramStateRef StdLibraryFunctionsChecker::ComparisonConstraint::apply( - ProgramStateRef State, const CallEvent &Call, const Summary &Summary, - CheckerContext &C) const { - - ProgramStateManager &Mgr = State->getStateManager(); - SValBuilder &SVB = Mgr.getSValBuilder(); - QualType CondT = SVB.getConditionType(); - QualType T = Summary.getArgType(getArgNo()); - SVal V = getArgSVal(Call, getArgNo()); - - BinaryOperator::Opcode Op = getOpcode(); - ArgNo OtherArg = getOtherArgNo(); - SVal OtherV = getArgSVal(Call, OtherArg); - QualType OtherT = Summary.getArgType(OtherArg); - // Note: we avoid integral promotion for comparison. - OtherV = SVB.evalCast(OtherV, T, OtherT); - if (auto CompV = SVB.evalBinOp(State, Op, V, OtherV, CondT) - .getAs()) - State = State->assume(*CompV, true); - return State; -} - void StdLibraryFunctionsChecker::checkPreCall(const CallEvent &Call, CheckerContext &C) const { std::optional FoundSummary = findFunctionSummary(Call, C); @@ -1094,13 +1133,14 @@ ProgramStateRef NewState = State; ExplodedNode *NewNode = C.getPredecessor(); for (const ValueConstraintPtr &Constraint : Summary.getArgConstraints()) { + ValueConstraintPtr NegatedConstraint = Constraint->negate(); ProgramStateRef SuccessSt = Constraint->apply(NewState, Call, Summary, C); ProgramStateRef FailureSt = - Constraint->negate()->apply(NewState, Call, Summary, C); + NegatedConstraint->apply(NewState, Call, Summary, C); // The argument constraint is not satisfied. if (FailureSt && !SuccessSt) { - if (ExplodedNode *N = C.generateErrorNode(NewState, NewNode)) - reportBug(Call, N, Constraint.get(), Summary, C); + if (ExplodedNode *N = C.generateErrorNode(State, NewNode)) + reportBug(Call, N, Constraint.get(), NegatedConstraint.get(), Summary, C); break; } // We will apply the constraint even if we cannot reason about the