diff --git a/llvm/lib/ObjCopy/ELF/ELFObject.cpp b/llvm/lib/ObjCopy/ELF/ELFObject.cpp --- a/llvm/lib/ObjCopy/ELF/ELFObject.cpp +++ b/llvm/lib/ObjCopy/ELF/ELFObject.cpp @@ -1704,6 +1704,10 @@ else return Data.takeError(); case SHT_SYMTAB: { + // Multiple SHT_SYMTAB sections are forbidden by the ELF gABI. + if (Obj.SymbolTable != nullptr) + return createStringError(llvm::errc::invalid_argument, + "found multiple SHT_SYMTAB sections"); auto &SymTab = Obj.addSection(); Obj.SymbolTable = &SymTab; return SymTab; diff --git a/llvm/test/tools/llvm-objcopy/ELF/multiple-symtab.test b/llvm/test/tools/llvm-objcopy/ELF/multiple-symtab.test new file mode 100644 --- /dev/null +++ b/llvm/test/tools/llvm-objcopy/ELF/multiple-symtab.test @@ -0,0 +1,20 @@ +## According to the ELF gABI, "Currently, an object file may have only one +## section of each type [SHT_SYMTAB and SHT_DYNSYM], but this restriction may be +## relaxed in the future." +## This test shows that we emit an error if we encounter multiple SHT_SYMTAB +## sections. +# RUN: yaml2obj %s -o %t +# RUN: not llvm-objcopy %t /dev/null 2>&1 | FileCheck %s + +# CHECK: error: found multiple SHT_SYMTAB sections + +--- !ELF +FileHeader: + Class: ELFCLASS64 + Data: ELFDATA2LSB + Type: ET_REL +Sections: + - Name: .symtab + Type: SHT_SYMTAB + - Name: .symtab2 + Type: SHT_SYMTAB