diff --git a/libcxx/include/__tree b/libcxx/include/__tree --- a/libcxx/include/__tree +++ b/libcxx/include/__tree @@ -375,7 +375,7 @@ { _LIBCPP_ASSERT(__root != nullptr, "Root node should not be null"); _LIBCPP_ASSERT(__z != nullptr, "The node to remove should not be null"); - _LIBCPP_DEBUG_ASSERT(__tree_invariant(__root), "The tree invariants should hold"); + _LIBCPP_DEBUG_ASSERT(std::__tree_invariant(__root), "The tree invariants should hold"); // __z will be removed from the tree. Client still needs to destruct/deallocate it // __y is either __z, or if __z has two children, __tree_next(__z). // __y will have at most one child. diff --git a/libcxx/test/tools/clang_tidy_checks/CMakeLists.txt b/libcxx/test/tools/clang_tidy_checks/CMakeLists.txt --- a/libcxx/test/tools/clang_tidy_checks/CMakeLists.txt +++ b/libcxx/test/tools/clang_tidy_checks/CMakeLists.txt @@ -33,7 +33,10 @@ ${CLANG_INCLUDE_DIRS} ${LLVM_INCLUDE_DIRS} ) -target_compile_options(clangTidy INTERFACE -fno-rtti) +target_compile_options(clangTidy INTERFACE + -fno-rtti + -fno-sanitize=address,hwaddress,memory,undefined,thread,dataflow,leak # ignore any sanitizers + ) add_library(cxx-tidy MODULE ${SOURCES}) target_link_libraries(cxx-tidy clangTidy) diff --git a/libcxx/utils/ci/buildkite-pipeline.yml b/libcxx/utils/ci/buildkite-pipeline.yml --- a/libcxx/utils/ci/buildkite-pipeline.yml +++ b/libcxx/utils/ci/buildkite-pipeline.yml @@ -97,6 +97,7 @@ env: CC: "gcc-${GCC_STABLE_VERSION}" CXX: "g++-${GCC_STABLE_VERSION}" + ENABLE_CLANG_TIDY: "On" agents: queue: "libcxx-builders" os: "linux" @@ -132,6 +133,7 @@ env: CC: "clang-${LLVM_HEAD_VERSION}" CXX: "clang++-${LLVM_HEAD_VERSION}" + ENABLE_CLANG_TIDY: "On" agents: queue: "libcxx-builders" os: "linux" @@ -245,6 +247,7 @@ env: CC: "gcc-${GCC_STABLE_VERSION}" CXX: "g++-${GCC_STABLE_VERSION}" + ENABLE_CLANG_TIDY: "On" agents: queue: "libcxx-builders" os: "linux" @@ -262,6 +265,7 @@ env: CC: "clang-15" CXX: "clang++-15" + ENABLE_CLANG_TIDY: "On" agents: queue: "libcxx-builders" os: "linux" @@ -279,6 +283,7 @@ env: CC: "clang-16" CXX: "clang++-16" + ENABLE_CLANG_TIDY: "On" agents: queue: "libcxx-builders" os: "linux" @@ -299,6 +304,7 @@ env: CC: "clang-${LLVM_HEAD_VERSION}" CXX: "clang++-${LLVM_HEAD_VERSION}" + ENABLE_CLANG_TIDY: "On" agents: queue: "libcxx-builders" os: "linux" @@ -316,6 +322,7 @@ env: CC: "clang-${LLVM_HEAD_VERSION}" CXX: "clang++-${LLVM_HEAD_VERSION}" + ENABLE_CLANG_TIDY: "On" agents: queue: "libcxx-builders" os: "linux" @@ -333,6 +340,7 @@ env: CC: "clang-${LLVM_HEAD_VERSION}" CXX: "clang++-${LLVM_HEAD_VERSION}" + ENABLE_CLANG_TIDY: "On" agents: queue: "libcxx-builders" os: "linux" @@ -350,6 +358,7 @@ env: CC: "clang-${LLVM_HEAD_VERSION}" CXX: "clang++-${LLVM_HEAD_VERSION}" + ENABLE_CLANG_TIDY: "On" agents: queue: "libcxx-builders" os: "linux" @@ -389,6 +398,7 @@ env: CC: "clang-${LLVM_HEAD_VERSION}" CXX: "clang++-${LLVM_HEAD_VERSION}" + ENABLE_CLANG_TIDY: "On" agents: queue: "libcxx-builders" os: "linux" @@ -406,6 +416,7 @@ env: CC: "clang-${LLVM_HEAD_VERSION}" CXX: "clang++-${LLVM_HEAD_VERSION}" + ENABLE_CLANG_TIDY: "On" agents: queue: "libcxx-builders" os: "linux" @@ -423,6 +434,7 @@ env: CC: "clang-${LLVM_HEAD_VERSION}" CXX: "clang++-${LLVM_HEAD_VERSION}" + ENABLE_CLANG_TIDY: "On" agents: queue: "libcxx-builders" os: "linux" @@ -440,6 +452,7 @@ env: CC: "clang-${LLVM_HEAD_VERSION}" CXX: "clang++-${LLVM_HEAD_VERSION}" + ENABLE_CLANG_TIDY: "On" agents: queue: "libcxx-builders" os: "linux" @@ -457,6 +470,7 @@ env: CC: "clang-${LLVM_HEAD_VERSION}" CXX: "clang++-${LLVM_HEAD_VERSION}" + ENABLE_CLANG_TIDY: "On" agents: queue: "libcxx-builders" os: "linux" @@ -474,6 +488,7 @@ env: CC: "clang-${LLVM_HEAD_VERSION}" CXX: "clang++-${LLVM_HEAD_VERSION}" + ENABLE_CLANG_TIDY: "On" agents: queue: "libcxx-builders" os: "linux" @@ -493,6 +508,7 @@ env: CC: "clang-${LLVM_HEAD_VERSION}" CXX: "clang++-${LLVM_HEAD_VERSION}" + ENABLE_CLANG_TIDY: "On" agents: queue: "libcxx-builders" os: "linux" @@ -510,6 +526,7 @@ env: CC: "clang-${LLVM_HEAD_VERSION}" CXX: "clang++-${LLVM_HEAD_VERSION}" + ENABLE_CLANG_TIDY: "On" agents: queue: "libcxx-builders" os: "linux" @@ -527,6 +544,7 @@ env: CC: "clang-${LLVM_HEAD_VERSION}" CXX: "clang++-${LLVM_HEAD_VERSION}" + ENABLE_CLANG_TIDY: "On" agents: queue: "libcxx-builders" os: "linux" @@ -544,6 +562,7 @@ env: CC: "clang-${LLVM_HEAD_VERSION}" CXX: "clang++-${LLVM_HEAD_VERSION}" + ENABLE_CLANG_TIDY: "On" agents: queue: "libcxx-builders" os: "linux" @@ -561,6 +580,7 @@ env: CC: "clang-${LLVM_HEAD_VERSION}" CXX: "clang++-${LLVM_HEAD_VERSION}" + ENABLE_CLANG_TIDY: "On" agents: queue: "libcxx-builders" os: "linux" @@ -578,6 +598,7 @@ env: CC: "clang-${LLVM_HEAD_VERSION}" CXX: "clang++-${LLVM_HEAD_VERSION}" + ENABLE_CLANG_TIDY: "On" agents: queue: "libcxx-builders" os: "linux" @@ -595,6 +616,7 @@ env: CC: "clang-${LLVM_HEAD_VERSION}" CXX: "clang++-${LLVM_HEAD_VERSION}" + ENABLE_CLANG_TIDY: "On" agents: queue: "libcxx-builders" os: "linux" @@ -612,6 +634,7 @@ env: CC: "clang-${LLVM_HEAD_VERSION}" CXX: "clang++-${LLVM_HEAD_VERSION}" + ENABLE_CLANG_TIDY: "On" agents: queue: "libcxx-builders" os: "linux" @@ -629,6 +652,7 @@ env: CC: "clang-${LLVM_HEAD_VERSION}" CXX: "clang++-${LLVM_HEAD_VERSION}" + ENABLE_CLANG_TIDY: "On" agents: queue: "libcxx-builders" os: "linux" @@ -646,6 +670,7 @@ env: CC: "clang-${LLVM_HEAD_VERSION}" CXX: "clang++-${LLVM_HEAD_VERSION}" + ENABLE_CLANG_TIDY: "On" agents: queue: "libcxx-builders" os: "linux" @@ -664,6 +689,7 @@ env: CC: "clang-${LLVM_HEAD_VERSION}" CXX: "clang++-${LLVM_HEAD_VERSION}" + ENABLE_CLANG_TIDY: "On" agents: queue: "libcxx-builders" os: "linux"