diff --git a/bolt/include/bolt/Rewrite/MachORewriteInstance.h b/bolt/include/bolt/Rewrite/MachORewriteInstance.h --- a/bolt/include/bolt/Rewrite/MachORewriteInstance.h +++ b/bolt/include/bolt/Rewrite/MachORewriteInstance.h @@ -68,13 +68,12 @@ public: // This constructor has complex initialization that can fail during // construction. Constructors can’t return errors, so clients must test \p Err - // after the object is constructed. Use createMachORewriteInstance instead. + // after the object is constructed. Use `create` method instead. MachORewriteInstance(object::MachOObjectFile *InputFile, StringRef ToolPath, Error &Err); static Expected> - createMachORewriteInstance(object::MachOObjectFile *InputFile, - StringRef ToolPath); + create(object::MachOObjectFile *InputFile, StringRef ToolPath); ~MachORewriteInstance(); Error setProfile(StringRef FileName); diff --git a/bolt/include/bolt/Rewrite/RewriteInstance.h b/bolt/include/bolt/Rewrite/RewriteInstance.h --- a/bolt/include/bolt/Rewrite/RewriteInstance.h +++ b/bolt/include/bolt/Rewrite/RewriteInstance.h @@ -43,13 +43,13 @@ public: // This constructor has complex initialization that can fail during // construction. Constructors can’t return errors, so clients must test \p Err - // after the object is constructed. Use createRewriteInstance instead. + // after the object is constructed. Use `create` method instead. RewriteInstance(llvm::object::ELFObjectFileBase *File, const int Argc, const char *const *Argv, StringRef ToolPath, Error &Err); static Expected> - createRewriteInstance(llvm::object::ELFObjectFileBase *File, const int Argc, - const char *const *Argv, StringRef ToolPath); + create(llvm::object::ELFObjectFileBase *File, const int Argc, + const char *const *Argv, StringRef ToolPath); ~RewriteInstance(); /// Assign profile from \p Filename to this instance. diff --git a/bolt/lib/Rewrite/MachORewriteInstance.cpp b/bolt/lib/Rewrite/MachORewriteInstance.cpp --- a/bolt/lib/Rewrite/MachORewriteInstance.cpp +++ b/bolt/lib/Rewrite/MachORewriteInstance.cpp @@ -85,8 +85,8 @@ #define DEBUG_TYPE "bolt" Expected> -MachORewriteInstance::createMachORewriteInstance( - object::MachOObjectFile *InputFile, StringRef ToolPath) { +MachORewriteInstance::create(object::MachOObjectFile *InputFile, + StringRef ToolPath) { Error Err = Error::success(); auto MachORI = std::make_unique(InputFile, ToolPath, Err); diff --git a/bolt/lib/Rewrite/RewriteInstance.cpp b/bolt/lib/Rewrite/RewriteInstance.cpp --- a/bolt/lib/Rewrite/RewriteInstance.cpp +++ b/bolt/lib/Rewrite/RewriteInstance.cpp @@ -311,9 +311,8 @@ } // anonymous namespace Expected> -RewriteInstance::createRewriteInstance(ELFObjectFileBase *File, const int Argc, - const char *const *Argv, - StringRef ToolPath) { +RewriteInstance::create(ELFObjectFileBase *File, const int Argc, + const char *const *Argv, StringRef ToolPath) { Error Err = Error::success(); auto RI = std::make_unique(File, Argc, Argv, ToolPath, Err); if (Err) diff --git a/bolt/tools/driver/llvm-bolt.cpp b/bolt/tools/driver/llvm-bolt.cpp --- a/bolt/tools/driver/llvm-bolt.cpp +++ b/bolt/tools/driver/llvm-bolt.cpp @@ -216,8 +216,7 @@ Binary &Binary = *BinaryOrErr.get().getBinary(); if (auto *e = dyn_cast(&Binary)) { - auto RIOrErr = - RewriteInstance::createRewriteInstance(e, argc, argv, ToolPath); + auto RIOrErr = RewriteInstance::create(e, argc, argv, ToolPath); if (Error E = RIOrErr.takeError()) report_error(opts::InputFilename, std::move(E)); RewriteInstance &RI = *RIOrErr.get(); @@ -244,8 +243,7 @@ if (Error E = RI.run()) report_error(opts::InputFilename, std::move(E)); } else if (auto *O = dyn_cast(&Binary)) { - auto MachORIOrErr = - MachORewriteInstance::createMachORewriteInstance(O, ToolPath); + auto MachORIOrErr = MachORewriteInstance::create(O, ToolPath); if (Error E = MachORIOrErr.takeError()) report_error(opts::InputFilename, std::move(E)); MachORewriteInstance &MachORI = *MachORIOrErr.get(); @@ -275,15 +273,13 @@ Binary &Binary2 = *BinaryOrErr2.get().getBinary(); if (auto *ELFObj1 = dyn_cast(&Binary1)) { if (auto *ELFObj2 = dyn_cast(&Binary2)) { - auto RI1OrErr = - RewriteInstance::createRewriteInstance(ELFObj1, argc, argv, ToolPath); + auto RI1OrErr = RewriteInstance::create(ELFObj1, argc, argv, ToolPath); if (Error E = RI1OrErr.takeError()) report_error(opts::InputFilename, std::move(E)); RewriteInstance &RI1 = *RI1OrErr.get(); if (Error E = RI1.setProfile(opts::InputDataFilename)) report_error(opts::InputDataFilename, std::move(E)); - auto RI2OrErr = - RewriteInstance::createRewriteInstance(ELFObj2, argc, argv, ToolPath); + auto RI2OrErr = RewriteInstance::create(ELFObj2, argc, argv, ToolPath); if (Error E = RI2OrErr.takeError()) report_error(opts::InputFilename2, std::move(E)); RewriteInstance &RI2 = *RI2OrErr.get(); diff --git a/bolt/tools/heatmap/heatmap.cpp b/bolt/tools/heatmap/heatmap.cpp --- a/bolt/tools/heatmap/heatmap.cpp +++ b/bolt/tools/heatmap/heatmap.cpp @@ -85,8 +85,7 @@ Binary &Binary = *BinaryOrErr.get().getBinary(); if (auto *e = dyn_cast(&Binary)) { - auto RIOrErr = - RewriteInstance::createRewriteInstance(e, argc, argv, ToolPath); + auto RIOrErr = RewriteInstance::create(e, argc, argv, ToolPath); if (Error E = RIOrErr.takeError()) report_error("RewriteInstance", std::move(E)); diff --git a/bolt/tools/llvm-bolt-fuzzer/llvm-bolt-fuzzer.cpp b/bolt/tools/llvm-bolt-fuzzer/llvm-bolt-fuzzer.cpp --- a/bolt/tools/llvm-bolt-fuzzer/llvm-bolt-fuzzer.cpp +++ b/bolt/tools/llvm-bolt-fuzzer/llvm-bolt-fuzzer.cpp @@ -45,8 +45,7 @@ return 0; // Fuzz RewriteInstance. - auto RIOrErr = - RewriteInstance::createRewriteInstance(E, argc, argv, "llvm-bolt"); + auto RIOrErr = RewriteInstance::create(E, argc, argv, "llvm-bolt"); if (Error E = RIOrErr.takeError()) { consumeError(std::move(E)); return 0;