Add build for Windows on Arm in packaging script

[pbo-linaro]

This script is used by Linaro to create LLVM Windows on Arm releases, and we would like to upstream this.

[omjavaid]

This looks good to me after fixing nits mentioned inline.

llvm/utils/release/build_llvm_release.bat

324

These flags are common to all stage1 builds and can be added to variable that be included to all stage1 builds.

333

These LLDB python related flags should be common for all Stage1 builds too. Should be added to a common variable.

[pbo-linaro]

Factorized some flags.

[pbo-linaro]

llvm/utils/release/build_llvm_release.bat

324

stage0_bin_dir needs to be expanded for every architecture, so it has to be duplicated for all stage1.

333

Added them to common_flags for arm64 stage0 and stage1

[hans]

Could the refactorings (set_environment and do_build_libxml) be done in separate patches? That would make it easier to review.

Side question: has anyone tried the script on llvm-16.0.0-rc1 yet? I was meaning to do it but didn't find the cycles yet.

llvm/utils/release/build_llvm_release.bat

144

Why is this being dropped?

303

We're building flang now?

330

..and mlir?

I wonder if we should try to keep LLVM_ENABLE_PROJECTS the same across targets, maybe there could be a flag to add flang to it if we need that.

378

This was probably my fault, but maybe add some newlines while here anyway.

[pbo-linaro]

Thanks for your review!

Initially, I duplicated the LIBXML2 build, as you say, with the intent to factorize it later.
But finally, with @omjavaid , we decided to make both at once, so the result is cleaner.

It's a bit long to test (takes hours to build, and we did it many time), so if we could integrate both, that would be really nice...

For flags and list of targets to build, I'll let @omjavaid answer, as I followed his indications.

We built 17-init and 16.0.0-rc1 with this script, as shown here (arm64 only):
https://gitlab.com/Linaro/windowsonarm/packages/llvm-release/-/jobs/3694968725
We build it nightly as well, so we can have an updated llvm for our internal usage.

[pbo-linaro]

llvm/utils/release/build_llvm_release.bat

144

This adds a regression, as LLD_VERSION is not correctly detected, thus empty.
And it fails the cmake step, when a REGEX REPLACE is done on that empty string.

378

I'm not sure to understand what you want me to add exactly here?

[hans]

In D142983#4096547, @pbo-linaro wrote:

Thanks for your review!

Initially, I duplicated the LIBXML2 build, as you say, with the intent to factorize it later.
But finally, with @omjavaid , we decided to make both at once, so the result is cleaner.

It's a bit long to test (takes hours to build, and we did it many time), so if we could integrate both, that would be really nice...

Okay.

For flags and list of targets to build, I'll let @omjavaid answer, as I followed his indications.

We built 17-init and 16.0.0-rc1 with this script, as shown here (arm64 only):
https://gitlab.com/Linaro/windowsonarm/packages/llvm-release/-/jobs/3694968725
We build it nightly as well, so we can have an updated llvm for our internal usage.

Great!

llvm/utils/release/build_llvm_release.bat

144

I think this line has been there for a long time though, so I don't understand how it could regress something. Maybe something else changed?
I don't think we should drop this, but try to fix the underlying problem.

378

I meant it would be nice to break this very long line into multiple lines (with ^ at the end, like we do with the set cmake_flags=... line for example).

[pbo-linaro]

llvm/utils/release/build_llvm_release.bat

144

You are right. After looking more in details, it happens only when PACKAGE_VERSION does not respect "[0-9]+.[0-9]+.*" regex.

Initially, I worked on that script using main branch, which resulted in -DPACKAGE_VERSION=main. 17-init presented the same issue, thus I assumed there had been a regression (and didn't try with 16.0.0-rc1, which works!).

As you can try yourself, this fails at cmake step.
cmake -GNinja -DLLVM_ENABLE_PROJECTS=lld -DCMAKE_BUILD_TYPE=Release -DPACKAGE_VERSION=main ./llvm
...

• LLD version:

CMake Error at .../llvm-project/lld/CMakeLists.txt:137 (string):

string sub-command REGEX, mode REPLACE needs at least 6 arguments total to
command.

---

That said, for now, i'll just restore that line in the script, as we expect to build only "normal" releases with this script, matching the expected regex.

378

Yes sure. I forgot about this long line, as it's wrapped in phabricator.

[pbo-linaro]

Bring back PACKAGE_VERSION and split libxml2 cmake parameters on multiple lines.

[omjavaid]

@pbo-linaro I have replied to flang query and also going to issue a build using this script to verify it. Looks good to me. I ll post the result of my build tomorrow.

llvm/utils/release/build_llvm_release.bat

303

We have been releasing building flang + mlir for windows on arm since 14.0.0 release. I have tried it on x64 and it passes all ninja check-flang on x64. So I found it reasonable to include flang for all the windows build.

330

mlir + flang included to woa build since 14.0.0. IMO should be added to x64 as well.

[hans]

llvm/utils/release/build_llvm_release.bat

330

What does including mlir even mean since we build with -DLLVM_INSTALL_TOOLCHAIN_ONLY=ON? I thought it was a library?

As for flang, I'd suggest adding it behind a flag for now, which controls whether it gets added to ENABLE_PROJECTS centrally. You could default the flag to on for arm64 I suppose since it's been shipping there already.

[omjavaid]

llvm/utils/release/build_llvm_release.bat

330

Agreed. We only need clang at stage0 and for stage1 only arm64 can have mlir+flang.

[pbo-linaro]

Use same list of projects for arm64 than x86/x64, except for openmp which does
not build for arm64 at this time.

[pbo-linaro]

After discussion with @omjavaid, we decided to build same list of projects for arm64, than x64/x86.

The flang/mlir support could be added later with another patch.
Does this seem good to you @hans ?

[mstorsjo]

In D142983#4101843, @pbo-linaro wrote:

Use same list of projects for arm64 than x86/x64, except for openmp which does
not build for arm64 at this time.

FYI, I think openmp should build for windows/arm64 with clang-cl with current git main (and on the 16.x branch); this was fixed in November/December. I primarily build and test it in mingw mode, but I've made fixes to make it work in clang-cl mode too.

Building openmp is a bit more tricky than other subprojects though, as it requires perl to be available at build time.

[pbo-linaro]

Thanks for the information @mstorsjo.
Let me try it on my machine, and I'll use the exact same projects list between all arch if it works 👍.

EDIT: works!

[pbo-linaro]

Build same projects for all architecture.

OpenMP builds fine for arm64, as show in this build log:
https://gitlab.com/Linaro/windowsonarm/packages/llvm-release/-/jobs/3708866040

[hans]

lgtm

In D142983#4101865, @pbo-linaro wrote:

After discussion with @omjavaid, we decided to build same list of projects for arm64, than x64/x86.

The flang/mlir support could be added later with another patch.
Does this seem good to you @hans ?

Sounds good to me.

llvm/utils/release/build_llvm_release.bat

308

What's the state of these tests on win/arm64? Should we enable some in a follow-up patch?

334

With all the other tests commented out, I'm surprised these are running.. do they pass? Should they be commented out too for now?

[pbo-linaro]

Thanks for your approval! 👍

llvm/utils/release/build_llvm_release.bat

334

At the time of 15.0.0, there were some failures. We deactivated it as well to reduce build time.

But the plan is to enable them again in the future. First, we wanted to upstream that build script, to avoid keeping a fork on our side.

[pbo-linaro]

@hans As I don't have any commit access to LLVM, could you kindly push this patch? Thanks

llvm/utils/release/build_llvm_release.bat

 @echo off
 setlocal enabledelayedexpansion
 
 goto begin
 
 :usage
 echo Script for building the LLVM installer on Windows,
 echo used for the releases at https://github.com/llvm/llvm-project/releases
 echo.
-echo Usage: build_llvm_release.bat --version ^<version^> [--x86,--x64]
+echo Usage: build_llvm_release.bat --version ^<version^> [--x86,--x64, --arm64]
 echo.
 echo Options:
 echo --version: [required] version to build
 echo --help: display this help
 echo --x86: build and test x86 variant
 echo --x64: build and test x64 variant
+echo --arm64: build and test arm64 variant
 echo.
 echo Note: At least one variant to build is required.
 echo.
 echo Example: build_llvm_release.bat --version 15.0.0 --x86 --x64
 exit /b 1
 
 :begin
 
 ::==============================================================================
 :: parse args
 set version=
 set help=
 set x86=
 set x64=
+set arm64=
 call :parse_args %*
 
 if "%help%" NEQ "" goto usage
 
 if "%version%" == "" (
     echo --version option is required
     echo =============================
     goto usage
 )
 
-if "%x64%" == "" if "%x86%" == "" (
+if "%arm64%" == "" if "%x64%" == "" if "%x86%" == "" (
     echo nothing to build!
-    echo choose one or several variants from: --x86 --x64
+    echo choose one or several variants from: --x86 --x64 --arm64
     exit /b 1
 )
 
 ::==============================================================================
 :: check prerequisites
 REM Note:
 REM   7zip versions 21.x and higher will try to extract the symlinks in
 REM   llvm's git archive, which requires running as administrator.

 echo Using VS devcmd: %vsdevcmd%
 
 ::==============================================================================
 :: start echoing what we do
 @echo on
 
 set python32_dir=C:\Users\%USERNAME%\AppData\Local\Programs\Python\Python310-32
 set python64_dir=C:\Users\%USERNAME%\AppData\Local\Programs\Python\Python310
+set pythonarm64_dir=C:\Users\%USERNAME%\AppData\Local\Programs\Python\Python311-arm64
 
 set revision=llvmorg-%version%
 set package_version=%version%
 set build_dir=%cd%\llvm_package_%package_version%
 
 echo Revision: %revision%
 echo Package version: %package_version%
 echo Build dir: %build_dir%

 curl -L https://github.com/llvm/llvm-project/archive/%revision%.zip -o src.zip || exit /b 1
 7z x src.zip || exit /b 1
 mv llvm-project-* llvm-project || exit /b 1
 
 curl -O https://gitlab.gnome.org/GNOME/libxml2/-/archive/v2.9.12/libxml2-v2.9.12.tar.gz || exit /b 1
 tar zxf libxml2-v2.9.12.tar.gz
 
 REM Setting CMAKE_CL_SHOWINCLUDES_PREFIX to work around PR27226.
-REM Common flags for both 32/64 builds.
+REM Common flags for all builds.
 set common_cmake_flags=^
   -DCMAKE_BUILD_TYPE=Release ^
   -DLLVM_ENABLE_ASSERTIONS=OFF ^
   -DLLVM_INSTALL_TOOLCHAIN_ONLY=ON ^
   -DLLVM_BUILD_LLVM_C_DYLIB=ON ^
   -DCMAKE_INSTALL_UCRT_LIBRARIES=ON ^
   -DPython3_FIND_REGISTRY=NEVER ^
   -DPACKAGE_VERSION=%package_version% ^
   -DLLDB_RELOCATABLE_PYTHON=1 ^
   -DLLDB_EMBED_PYTHON_HOME=OFF ^
   -DCMAKE_CL_SHOWINCLUDES_PREFIX="Note: including file: " ^
   -DLLVM_ENABLE_LIBXML2=FORCE_ON ^
   -DLLDB_ENABLE_LIBXML2=OFF ^
   -DCMAKE_C_FLAGS="-DLIBXML_STATIC" ^
   -DCMAKE_CXX_FLAGS="-DLIBXML_STATIC" ^
   -DLLVM_ENABLE_PROJECTS="clang;clang-tools-extra;lld;compiler-rt;lldb;openmp"
 
 REM Preserve original path
 set OLDPATH=%PATH%
 
 REM Build the 32-bits and/or 64-bits binaries.
 if "%x86%" == "true" call :do_build_32 || exit /b 1
 if "%x64%" == "true" call :do_build_64 || exit /b 1
+if "%arm64%" == "true" call :do_build_arm64 || exit /b 1
 exit /b 0
 
 ::==============================================================================
 :: Build 32-bits binaries.
 ::==============================================================================
 :do_build_32
-REM Restore original path
-set PATH=%OLDPATH%
-
-REM TODO: Run the "check-all" tests.
-
-REM Set Python environment
-set PYTHONHOME=%python32_dir%
-set PATH=%PYTHONHOME%;%PATH%
-%python32_dir%/python.exe --version || exit /b 1
-
-set "VSCMD_START_DIR=%build_dir%"
+call :set_environment %python32_dir% || exit /b 1
 call "%vsdevcmd%" -arch=x86 || exit /b 1
 @echo on
 mkdir build32_stage0
 cd build32_stage0
-
-mkdir libxmlbuild
-cd libxmlbuild
-cmake -GNinja -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=install -DBUILD_SHARED_LIBS=OFF -DLIBXML2_WITH_C14N=OFF -DLIBXML2_WITH_CATALOG=OFF -DLIBXML2_WITH_DEBUG=OFF -DLIBXML2_WITH_DOCB=OFF -DLIBXML2_WITH_FTP=OFF -DLIBXML2_WITH_HTML=OFF -DLIBXML2_WITH_HTTP=OFF -DLIBXML2_WITH_ICONV=OFF -DLIBXML2_WITH_ICU=OFF -DLIBXML2_WITH_ISO8859X=OFF -DLIBXML2_WITH_LEGACY=OFF -DLIBXML2_WITH_LZMA=OFF -DLIBXML2_WITH_MEM_DEBUG=OFF -DLIBXML2_WITH_MODULES=OFF -DLIBXML2_WITH_OUTPUT=ON -DLIBXML2_WITH_PATTERN=OFF -DLIBXML2_WITH_PROGRAMS=OFF -DLIBXML2_WITH_PUSH=OFF -DLIBXML2_WITH_PYTHON=OFF -DLIBXML2_WITH_READER=OFF -DLIBXML2_WITH_REGEXPS=OFF -DLIBXML2_WITH_RUN_DEBUG=OFF -DLIBXML2_WITH_SAX1=OFF -DLIBXML2_WITH_SCHEMAS=OFF -DLIBXML2_WITH_SCHEMATRON=OFF -DLIBXML2_WITH_TESTS=OFF -DLIBXML2_WITH_THREADS=ON -DLIBXML2_WITH_THREAD_ALLOC=OFF -DLIBXML2_WITH_TREE=ON -DLIBXML2_WITH_VALID=OFF -DLIBXML2_WITH_WRITER=OFF -DLIBXML2_WITH_XINCLUDE=OFF -DLIBXML2_WITH_XPATH=OFF -DLIBXML2_WITH_XPTR=OFF -DLIBXML2_WITH_ZLIB=OFF ../../libxml2-v2.9.12 || exit /b 1
-ninja install || exit /b 1
-set libxmldir=%cd%\install
-set "libxmldir=%libxmldir:\=/%"
-cd ..
+call :do_build_libxml || exit /b 1
 
 REM Stage0 binaries directory; used in stage1.
 set "stage0_bin_dir=%build_dir%/build32_stage0/bin"
 set cmake_flags=^
   %common_cmake_flags% ^
   -DLLDB_TEST_COMPILER=%stage0_bin_dir%/clang.exe ^
   -DPYTHON_HOME=%PYTHONHOME% ^
   -DPython3_ROOT_DIR=%PYTHONHOME% ^

 
 exit /b 0
 ::==============================================================================
 
 ::==============================================================================
 :: Build 64-bits binaries.
 ::==============================================================================
 :do_build_64
-REM Restore original path
-set PATH=%OLDPATH%
-
-REM Set Python environment
-set PYTHONHOME=%python64_dir%
-set PATH=%PYTHONHOME%;%PATH%
-%python64_dir%/python.exe --version || exit /b 1
-
-set "VSCMD_START_DIR=%build_dir%"
+call :set_environment %python64_dir% || exit /b 1
 call "%vsdevcmd%" -arch=amd64 || exit /b 1
 @echo on
 mkdir build64_stage0
 cd build64_stage0
-
-mkdir libxmlbuild
-cd libxmlbuild
-cmake -GNinja -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=install -DBUILD_SHARED_LIBS=OFF -DLIBXML2_WITH_C14N=OFF -DLIBXML2_WITH_CATALOG=OFF -DLIBXML2_WITH_DEBUG=OFF -DLIBXML2_WITH_DOCB=OFF -DLIBXML2_WITH_FTP=OFF -DLIBXML2_WITH_HTML=OFF -DLIBXML2_WITH_HTTP=OFF -DLIBXML2_WITH_ICONV=OFF -DLIBXML2_WITH_ICU=OFF -DLIBXML2_WITH_ISO8859X=OFF -DLIBXML2_WITH_LEGACY=OFF -DLIBXML2_WITH_LZMA=OFF -DLIBXML2_WITH_MEM_DEBUG=OFF -DLIBXML2_WITH_MODULES=OFF -DLIBXML2_WITH_OUTPUT=ON -DLIBXML2_WITH_PATTERN=OFF -DLIBXML2_WITH_PROGRAMS=OFF -DLIBXML2_WITH_PUSH=OFF -DLIBXML2_WITH_PYTHON=OFF -DLIBXML2_WITH_READER=OFF -DLIBXML2_WITH_REGEXPS=OFF -DLIBXML2_WITH_RUN_DEBUG=OFF -DLIBXML2_WITH_SAX1=OFF -DLIBXML2_WITH_SCHEMAS=OFF -DLIBXML2_WITH_SCHEMATRON=OFF -DLIBXML2_WITH_TESTS=OFF -DLIBXML2_WITH_THREADS=ON -DLIBXML2_WITH_THREAD_ALLOC=OFF -DLIBXML2_WITH_TREE=ON -DLIBXML2_WITH_VALID=OFF -DLIBXML2_WITH_WRITER=OFF -DLIBXML2_WITH_XINCLUDE=OFF -DLIBXML2_WITH_XPATH=OFF -DLIBXML2_WITH_XPTR=OFF -DLIBXML2_WITH_ZLIB=OFF ../../libxml2-v2.9.12 || exit /b 1
-ninja install || exit /b 1
-set libxmldir=%cd%\install
-set "libxmldir=%libxmldir:\=/%"
-cd ..
+call :do_build_libxml || exit /b 1
 
 REM Stage0 binaries directory; used in stage1.
 set "stage0_bin_dir=%build_dir%/build64_stage0/bin"
 set cmake_flags=^
   %common_cmake_flags% ^
   -DLLDB_TEST_COMPILER=%stage0_bin_dir%/clang.exe ^
   -DPYTHON_HOME=%PYTHONHOME% ^
   -DPython3_ROOT_DIR=%PYTHONHOME% ^

 ninja check-clang-tools || ninja check-clang-tools || ninja check-clang-tools || exit /b 1
 ninja check-clangd || ninja check-clangd || ninja check-clangd || exit /b 1
 ninja package || exit /b 1
 cd ..
 
 exit /b 0
 ::==============================================================================
 
+::==============================================================================
+:: Build arm64 binaries.
+::==============================================================================
+:do_build_arm64
+call :set_environment %pythonarm64_dir% || exit /b 1
+call "%vsdevcmd%" -host_arch=x64 -arch=arm64 || exit /b 1
+@echo on
+mkdir build_arm64_stage0
+cd build_arm64_stage0
+call :do_build_libxml || exit /b 1
+
+REM Stage0 binaries directory; used in stage1.
+set "stage0_bin_dir=%build_dir%/build_arm64_stage0/bin"
+set cmake_flags=^
+  %common_cmake_flags% ^
+  -DCLANG_DEFAULT_LINKER=lld ^
+  -DLIBXML2_INCLUDE_DIRS=%libxmldir%/include/libxml2 ^
+  -DLIBXML2_LIBRARIES=%libxmldir%/lib/libxml2s.lib ^
+  -DPython3_ROOT_DIR=%PYTHONHOME% ^
+  -DCOMPILER_RT_BUILD_PROFILE=OFF ^
+  -DCOMPILER_RT_BUILD_SANITIZERS=OFF
+
+REM We need to build stage0 compiler-rt with clang-cl (msvc lacks some builtins).
+cmake -GNinja %cmake_flags% ^
+  -DCMAKE_C_COMPILER=clang-cl.exe ^
+  -DCMAKE_CXX_COMPILER=clang-cl.exe ^
+  ..\llvm-project\llvm || exit /b 1
+ninja || exit /b 1
+::ninja check-llvm || exit /b 1
+::ninja check-clang || exit /b 1
+::ninja check-lld || exit /b 1
+::ninja check-sanitizer || exit /b 1
+::ninja check-clang-tools || exit /b 1
+::ninja check-clangd || exit /b 1
+cd..
+
+REM CMake expects the paths that specifies the compiler and linker to be
+REM with forward slash.
+REM CPACK_SYSTEM_NAME is set to have a correct name for installer generated.
+set all_cmake_flags=^
+  %cmake_flags% ^
+  -DCMAKE_C_COMPILER=%stage0_bin_dir%/clang-cl.exe ^
+  -DCMAKE_CXX_COMPILER=%stage0_bin_dir%/clang-cl.exe ^
+  -DCMAKE_LINKER=%stage0_bin_dir%/lld-link.exe ^
+  -DCMAKE_AR=%stage0_bin_dir%/llvm-lib.exe ^
+  -DCMAKE_RC=%stage0_bin_dir%/llvm-windres.exe ^
+  -DCPACK_SYSTEM_NAME=woa64
+set cmake_flags=%all_cmake_flags:\=/%
+
+mkdir build_arm64
+cd build_arm64
+cmake -GNinja %cmake_flags% ..\llvm-project\llvm || exit /b 1
+ninja || exit /b 1
+REM Check but do not fail on errors.
+ninja check-lldb
+::ninja check-llvm || exit /b 1
+::ninja check-clang || exit /b 1
+::ninja check-lld || exit /b 1
+::ninja check-sanitizer || exit /b 1
+::ninja check-clang-tools || exit /b 1
+::ninja check-clangd || exit /b 1
+ninja package || exit /b 1
+cd ..
+
+exit /b 0
+::==============================================================================
+::
+::==============================================================================
+:: Set PATH and some environment variables.
+::==============================================================================
+:set_environment
+REM Restore original path
+set PATH=%OLDPATH%
+
+set python_dir=%1
+
+REM Set Python environment
+%python_dir%/python.exe --version || exit /b 1
+set PYTHONHOME=%python_dir%
+set PATH=%PYTHONHOME%;%PATH%
+
+set "VSCMD_START_DIR=%build_dir%"
+
+exit /b 0
+
+::=============================================================================
+
+::==============================================================================
+:: Build libxml.
+::==============================================================================
+:do_build_libxml
+mkdir libxmlbuild
+cd libxmlbuild
+cmake -GNinja -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=install ^
+  -DBUILD_SHARED_LIBS=OFF -DLIBXML2_WITH_C14N=OFF -DLIBXML2_WITH_CATALOG=OFF ^
+  -DLIBXML2_WITH_DEBUG=OFF -DLIBXML2_WITH_DOCB=OFF -DLIBXML2_WITH_FTP=OFF ^
+  -DLIBXML2_WITH_HTML=OFF -DLIBXML2_WITH_HTTP=OFF -DLIBXML2_WITH_ICONV=OFF ^
+  -DLIBXML2_WITH_ICU=OFF -DLIBXML2_WITH_ISO8859X=OFF -DLIBXML2_WITH_LEGACY=OFF ^
+  -DLIBXML2_WITH_LZMA=OFF -DLIBXML2_WITH_MEM_DEBUG=OFF -DLIBXML2_WITH_MODULES=OFF ^
+  -DLIBXML2_WITH_OUTPUT=ON -DLIBXML2_WITH_PATTERN=OFF -DLIBXML2_WITH_PROGRAMS=OFF ^
+  -DLIBXML2_WITH_PUSH=OFF -DLIBXML2_WITH_PYTHON=OFF -DLIBXML2_WITH_READER=OFF ^
+  -DLIBXML2_WITH_REGEXPS=OFF -DLIBXML2_WITH_RUN_DEBUG=OFF -DLIBXML2_WITH_SAX1=OFF ^
+  -DLIBXML2_WITH_SCHEMAS=OFF -DLIBXML2_WITH_SCHEMATRON=OFF -DLIBXML2_WITH_TESTS=OFF ^
+  -DLIBXML2_WITH_THREADS=ON -DLIBXML2_WITH_THREAD_ALLOC=OFF -DLIBXML2_WITH_TREE=ON ^
+  -DLIBXML2_WITH_VALID=OFF -DLIBXML2_WITH_WRITER=OFF -DLIBXML2_WITH_XINCLUDE=OFF ^
+  -DLIBXML2_WITH_XPATH=OFF -DLIBXML2_WITH_XPTR=OFF -DLIBXML2_WITH_ZLIB=OFF ^
+  ../../libxml2-v2.9.12 || exit /b 1
+ninja install || exit /b 1
+set libxmldir=%cd%\install
+set "libxmldir=%libxmldir:\=/%"
+cd ..
+
+exit /b 0
 ::=============================================================================
 :: Parse command line arguments.
 :: The format for the arguments is:
 ::   Boolean: --option
 ::   Value:   --option<separator>value
 ::     with <separator> being: space, colon, semicolon or equal sign
 ::
 :: Command line usage example: