Page MenuHomePhabricator

Improve modernize-make-unique matcher.
ClosedPublic

Authored by angelgarcia on Nov 3 2015, 9:49 AM.

Details

Summary

"std::unique_ptr<int>" is not the same type as "std::unique_ptr<int, std::default_delete<int>>", unless we insert a "hasCanonicalType" in the middle. Probably it also happens in other cases related to default template argument.

Diff Detail

Event Timeline

angelgarcia updated this revision to Diff 39081.Nov 3 2015, 9:49 AM
angelgarcia retitled this revision from to Improve modernize-make-unique matcher..
angelgarcia updated this object.
angelgarcia added a reviewer: klimek.
angelgarcia added subscribers: cfe-commits, alexfh.
klimek accepted this revision.Nov 3 2015, 11:30 AM
klimek edited edge metadata.

lg

This revision is now accepted and ready to land.Nov 3 2015, 11:30 AM
angelgarcia closed this revision.Nov 4 2015, 2:30 AM