This is an archive of the discontinued LLVM Phabricator instance.

[mlir][NFC] Cleanup Passes documentation
ClosedPublic

Authored by sotoshigoto on Jan 29 2023, 10:42 PM.

Details

Summary
  • Fix a place of NVGPU dialect's pass
  • Move a summary of -finalize-memref-to-llvm into description
  • Fix broken links
  • Replace back-quote dialect headers with single-quote headers for improved readability.

Diff Detail

Event Timeline

sotoshigoto created this revision.Jan 29 2023, 10:42 PM
sotoshigoto requested review of this revision.Jan 29 2023, 10:42 PM
bondhugula added a subscriber: bondhugula.
bondhugula added inline comments.
mlir/docs/Passes.md
91

Can you please place this in alphabetical order? Everything above is in that order.

mlir/include/mlir/Conversion/Passes.td
639–646

-> Finalize MemRef ... dialect conversion

mlir/include/mlir/Dialect/MemRef/Transforms/Passes.td
51–52

Update doc based on the review comments

sotoshigoto updated this revision to Diff 494125.EditedFeb 1 2023, 5:40 PM
sotoshigoto marked 3 inline comments as done.

Upload patch to fix a ci error

Could someone review this patch document and provide feedback?

rriddle accepted this revision.Feb 22 2023, 9:33 AM
This revision is now accepted and ready to land.Feb 22 2023, 9:33 AM
This revision was automatically updated to reflect the committed changes.