Index: clang/docs/ReleaseNotes.rst =================================================================== --- clang/docs/ReleaseNotes.rst +++ clang/docs/ReleaseNotes.rst @@ -63,6 +63,9 @@ Improvements to Clang's diagnostics ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ +- We now generate a diagnostic for signed integer overflow due to unary minus + in a non-constant expression context. This fixes + `Issue 31643 `_ Non-comprehensive list of changes in this release ------------------------------------------------- Index: clang/lib/AST/ExprConstant.cpp =================================================================== --- clang/lib/AST/ExprConstant.cpp +++ clang/lib/AST/ExprConstant.cpp @@ -13500,10 +13500,16 @@ return false; if (!Result.isInt()) return Error(E); const APSInt &Value = Result.getInt(); - if (Value.isSigned() && Value.isMinSignedValue() && E->canOverflow() && - !HandleOverflow(Info, E, -Value.extend(Value.getBitWidth() + 1), - E->getType())) - return false; + if (Value.isSigned() && Value.isMinSignedValue() && E->canOverflow()) { + if (Info.checkingForUndefinedBehavior()) + Info.Ctx.getDiagnostics().Report(E->getExprLoc(), + diag::warn_integer_constant_overflow) + << toString(Value, 10) << E->getType(); + + if (!HandleOverflow(Info, E, -Value.extend(Value.getBitWidth() + 1), + E->getType())) + return false; + } return Success(-Value, E); } case UO_Not: { Index: clang/lib/Sema/SemaChecking.cpp =================================================================== --- clang/lib/Sema/SemaChecking.cpp +++ clang/lib/Sema/SemaChecking.cpp @@ -14853,7 +14853,7 @@ Expr *OriginalE = Exprs.pop_back_val(); Expr *E = OriginalE->IgnoreParenCasts(); - if (isa(E)) { + if (isa(E)) { E->EvaluateForOverflow(Context); continue; } Index: clang/test/CXX/expr/expr.const/p2-0x.cpp =================================================================== --- clang/test/CXX/expr/expr.const/p2-0x.cpp +++ clang/test/CXX/expr/expr.const/p2-0x.cpp @@ -146,6 +146,7 @@ constexpr int int_min = ~0x7fffffff; constexpr int minus_int_min = -int_min; // expected-error {{constant expression}} expected-note {{value 2147483648 is outside the range}} + constexpr int minus_int_min_from_shift = -(1<<31); // expected-error {{constant expression}} expected-note {{value 2147483648 is outside the range}} constexpr int div0 = 3 / 0; // expected-error {{constant expression}} expected-note {{division by zero}} constexpr int mod0 = 3 % 0; // expected-error {{constant expression}} expected-note {{division by zero}} constexpr int int_min_div_minus_1 = int_min / -1; // expected-error {{constant expression}} expected-note {{value 2147483648 is outside the range}} Index: clang/test/SemaCXX/integer-overflow.cpp =================================================================== --- clang/test/SemaCXX/integer-overflow.cpp +++ clang/test/SemaCXX/integer-overflow.cpp @@ -208,3 +208,9 @@ } } } + +namespace GH31643 { +void f() { + int a = -(1<<31); // expected-warning {{overflow in expression; result is -2147483648 with type 'int'}} +} +} Index: clang/unittests/Support/TimeProfilerTest.cpp =================================================================== --- clang/unittests/Support/TimeProfilerTest.cpp +++ clang/unittests/Support/TimeProfilerTest.cpp @@ -179,6 +179,7 @@ Frontend | EvaluateAsRValue () | EvaluateForOverflow () +| EvaluateForOverflow () | EvaluateAsRValue () | EvaluateForOverflow () | isPotentialConstantExpr (slow_namespace::slow_func)