Index: llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp =================================================================== --- llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp +++ llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp @@ -597,9 +597,15 @@ // TODO: Is there a benefit to checking the conditions performFNegCombine // does? We don't for the other cases. SDValue BCSrc = N->getOperand(0); - return BCSrc.getOpcode() == ISD::BUILD_VECTOR && - BCSrc.getNumOperands() == 2 && - BCSrc.getOperand(1).getValueSizeInBits() == 32; + if (BCSrc.getOpcode() == ISD::BUILD_VECTOR) { + return BCSrc.getNumOperands() == 2 && + BCSrc.getOperand(1).getValueSizeInBits() == 32; + } + + if (BCSrc.getOpcode() == ISD::SELECT && BCSrc.getValueType() == MVT::f32) + return true; + + return false; } return fnegFoldsIntoOpcode(Opc); @@ -4153,6 +4159,25 @@ return Result; } + if (BCSrc.getOpcode() == ISD::SELECT && VT == MVT::f32) { + // fneg (bitcast (f32 (select cond, i32:lhs, i32:rhs))) -> + // select cond, (bitcast i32:lhs to f32), (bitcast i32:rhs to f32) + SDValue LHS = + DAG.getNode(ISD::BITCAST, SL, MVT::f32, BCSrc.getOperand(1)); + SDValue RHS = + DAG.getNode(ISD::BITCAST, SL, MVT::f32, BCSrc.getOperand(2)); + + SDValue NegLHS = DAG.getNode(ISD::FNEG, SL, MVT::f32, LHS); + SDValue NegRHS = DAG.getNode(ISD::FNEG, SL, MVT::f32, RHS); + + SDValue NewSelect = DAG.getNode(ISD::SELECT, SL, MVT::f32, + BCSrc.getOperand(0), NegLHS, NegRHS); + if (!BCSrc.hasOneUse()) + DAG.ReplaceAllUsesWith(BCSrc, + DAG.getNode(ISD::FNEG, SL, VT, NewSelect)); + return NewSelect; + } + return SDValue(); } default: Index: llvm/test/CodeGen/AMDGPU/fneg-modifier-casting.ll =================================================================== --- llvm/test/CodeGen/AMDGPU/fneg-modifier-casting.ll +++ llvm/test/CodeGen/AMDGPU/fneg-modifier-casting.ll @@ -424,12 +424,12 @@ ; GFX7: ; %bb.0: ; GFX7-NEXT: s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0) ; GFX7-NEXT: v_and_b32_e32 v0, 1, v0 -; GFX7-NEXT: v_mov_b32_e32 v7, v1 ; GFX7-NEXT: v_cmp_eq_u32_e32 vcc, 1, v0 -; GFX7-NEXT: v_cndmask_b32_e32 v1, v4, v2, vcc -; GFX7-NEXT: v_cndmask_b32_e32 v0, v3, v7, vcc +; GFX7-NEXT: v_cndmask_b32_e64 v2, -v4, -v2, vcc +; GFX7-NEXT: v_cndmask_b32_e32 v0, v3, v1, vcc +; GFX7-NEXT: v_xor_b32_e32 v1, 0x80000000, v2 ; GFX7-NEXT: flat_store_dwordx2 v[5:6], v[0:1] -; GFX7-NEXT: v_xor_b32_e32 v1, 0x80000000, v1 +; GFX7-NEXT: v_mov_b32_e32 v1, v2 ; GFX7-NEXT: s_waitcnt vmcnt(0) ; GFX7-NEXT: s_setpc_b64 s[30:31] ; @@ -437,12 +437,12 @@ ; GFX9: ; %bb.0: ; GFX9-NEXT: s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0) ; GFX9-NEXT: v_and_b32_e32 v0, 1, v0 -; GFX9-NEXT: v_mov_b32_e32 v7, v1 ; GFX9-NEXT: v_cmp_eq_u32_e32 vcc, 1, v0 -; GFX9-NEXT: v_cndmask_b32_e32 v1, v4, v2, vcc -; GFX9-NEXT: v_cndmask_b32_e32 v0, v3, v7, vcc +; GFX9-NEXT: v_cndmask_b32_e64 v2, -v4, -v2, vcc +; GFX9-NEXT: v_cndmask_b32_e32 v0, v3, v1, vcc +; GFX9-NEXT: v_xor_b32_e32 v1, 0x80000000, v2 ; GFX9-NEXT: global_store_dwordx2 v[5:6], v[0:1], off -; GFX9-NEXT: v_xor_b32_e32 v1, 0x80000000, v1 +; GFX9-NEXT: v_mov_b32_e32 v1, v2 ; GFX9-NEXT: s_waitcnt vmcnt(0) ; GFX9-NEXT: s_setpc_b64 s[30:31] ; @@ -450,12 +450,12 @@ ; GFX11: ; %bb.0: ; GFX11-NEXT: s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0) ; GFX11-NEXT: s_waitcnt_vscnt null, 0x0 -; GFX11-NEXT: v_dual_mov_b32 v7, v1 :: v_dual_and_b32 v0, 1, v0 -; GFX11-NEXT: s_delay_alu instid0(VALU_DEP_1) | instskip(NEXT) | instid1(VALU_DEP_2) +; GFX11-NEXT: v_and_b32_e32 v0, 1, v0 +; GFX11-NEXT: s_delay_alu instid0(VALU_DEP_1) | instskip(SKIP_2) | instid1(VALU_DEP_2) ; GFX11-NEXT: v_cmp_eq_u32_e32 vcc_lo, 1, v0 -; GFX11-NEXT: v_dual_cndmask_b32 v1, v4, v2 :: v_dual_cndmask_b32 v0, v3, v7 -; GFX11-NEXT: s_delay_alu instid0(VALU_DEP_1) -; GFX11-NEXT: v_xor_b32_e32 v2, 0x80000000, v1 +; GFX11-NEXT: v_cndmask_b32_e64 v2, -v4, -v2, vcc_lo +; GFX11-NEXT: v_cndmask_b32_e32 v0, v3, v1, vcc_lo +; GFX11-NEXT: v_xor_b32_e32 v1, 0x80000000, v2 ; GFX11-NEXT: global_store_b64 v[5:6], v[0:1], off ; GFX11-NEXT: v_mov_b32_e32 v1, v2 ; GFX11-NEXT: s_waitcnt_vscnt null, 0x0 @@ -499,14 +499,13 @@ ; GCN: ; %bb.0: ; GCN-NEXT: s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0) ; GCN-NEXT: v_and_b32_e32 v0, 1, v0 +; GCN-NEXT: v_and_b32_e32 v1, 1, v1 ; GCN-NEXT: v_xor_b32_e32 v3, 0x80000000, v3 ; GCN-NEXT: v_cmp_eq_u32_e32 vcc, 1, v0 -; GCN-NEXT: v_and_b32_e32 v1, 1, v1 ; GCN-NEXT: v_cndmask_b32_e32 v0, v2, v4, vcc -; GCN-NEXT: v_cndmask_b32_e32 v2, v3, v5, vcc -; GCN-NEXT: v_xor_b32_e32 v3, 0x80000000, v2 +; GCN-NEXT: v_cndmask_b32_e64 v2, -v3, -v5, vcc ; GCN-NEXT: v_cmp_eq_u32_e32 vcc, 1, v1 -; GCN-NEXT: v_cndmask_b32_e32 v1, v2, v3, vcc +; GCN-NEXT: v_cndmask_b32_e64 v1, -v2, v2, vcc ; GCN-NEXT: s_setpc_b64 s[30:31] ; ; GFX11-LABEL: select_fneg_select_fneg_f64: @@ -515,16 +514,13 @@ ; GFX11-NEXT: s_waitcnt_vscnt null, 0x0 ; GFX11-NEXT: v_and_b32_e32 v0, 1, v0 ; GFX11-NEXT: v_xor_b32_e32 v3, 0x80000000, v3 -; GFX11-NEXT: v_and_b32_e32 v1, 1, v1 -; GFX11-NEXT: s_delay_alu instid0(VALU_DEP_3) | instskip(SKIP_1) | instid1(VALU_DEP_4) +; GFX11-NEXT: s_delay_alu instid0(VALU_DEP_2) | instskip(SKIP_1) | instid1(VALU_DEP_3) ; GFX11-NEXT: v_cmp_eq_u32_e32 vcc_lo, 1, v0 -; GFX11-NEXT: v_cndmask_b32_e32 v0, v2, v4, vcc_lo -; GFX11-NEXT: v_cndmask_b32_e32 v2, v3, v5, vcc_lo -; GFX11-NEXT: s_delay_alu instid0(VALU_DEP_4) | instskip(NEXT) | instid1(VALU_DEP_2) +; GFX11-NEXT: v_dual_cndmask_b32 v0, v2, v4 :: v_dual_and_b32 v1, 1, v1 +; GFX11-NEXT: v_cndmask_b32_e64 v2, -v3, -v5, vcc_lo +; GFX11-NEXT: s_delay_alu instid0(VALU_DEP_2) | instskip(NEXT) | instid1(VALU_DEP_2) ; GFX11-NEXT: v_cmp_eq_u32_e32 vcc_lo, 1, v1 -; GFX11-NEXT: v_xor_b32_e32 v3, 0x80000000, v2 -; GFX11-NEXT: s_delay_alu instid0(VALU_DEP_1) -; GFX11-NEXT: v_cndmask_b32_e32 v1, v2, v3, vcc_lo +; GFX11-NEXT: v_cndmask_b32_e64 v1, -v2, v2, vcc_lo ; GFX11-NEXT: s_setpc_b64 s[30:31] %fneg0 = fneg double %arg0 %select0 = select i1 %cond0, double %arg1, double %fneg0 @@ -896,10 +892,9 @@ ; GCN-NEXT: v_and_b32_e32 v5, 1, v0 ; GCN-NEXT: v_cmp_eq_u32_e32 vcc, 0, v5 ; GCN-NEXT: v_cndmask_b32_e32 v3, v1, v3, vcc -; GCN-NEXT: v_cndmask_b32_e32 v1, v2, v4, vcc -; GCN-NEXT: v_xor_b32_e32 v2, 0x80000000, v1 +; GCN-NEXT: v_cndmask_b32_e64 v1, -v2, -v4, vcc ; GCN-NEXT: v_cmp_lt_i32_e32 vcc, 1, v0 -; GCN-NEXT: v_cndmask_b32_e32 v1, v1, v2, vcc +; GCN-NEXT: v_cndmask_b32_e64 v1, -v1, v1, vcc ; GCN-NEXT: v_mov_b32_e32 v0, v3 ; GCN-NEXT: s_setpc_b64 s[30:31] ; @@ -911,12 +906,11 @@ ; GFX11-NEXT: s_delay_alu instid0(VALU_DEP_1) | instskip(SKIP_3) | instid1(VALU_DEP_3) ; GFX11-NEXT: v_cmp_eq_u32_e32 vcc_lo, 0, v5 ; GFX11-NEXT: v_cndmask_b32_e32 v3, v1, v3, vcc_lo -; GFX11-NEXT: v_cndmask_b32_e32 v1, v2, v4, vcc_lo +; GFX11-NEXT: v_cndmask_b32_e64 v1, -v2, -v4, vcc_lo ; GFX11-NEXT: v_cmp_lt_i32_e32 vcc_lo, 1, v0 ; GFX11-NEXT: v_mov_b32_e32 v0, v3 -; GFX11-NEXT: s_delay_alu instid0(VALU_DEP_3) | instskip(NEXT) | instid1(VALU_DEP_1) -; GFX11-NEXT: v_xor_b32_e32 v2, 0x80000000, v1 -; GFX11-NEXT: v_cndmask_b32_e32 v1, v1, v2, vcc_lo +; GFX11-NEXT: s_delay_alu instid0(VALU_DEP_3) +; GFX11-NEXT: v_cndmask_b32_e64 v1, -v1, v1, vcc_lo ; GFX11-NEXT: s_setpc_b64 s[30:31] %i = and i32 %arg, 1 %i3 = icmp eq i32 %i, 0