This is an archive of the discontinued LLVM Phabricator instance.

[libc++][ranges] Temporarily mark `ranges::join_view` as experimental.
ClosedPublic

Authored by var-const on Jan 24 2023, 5:20 PM.

Details

Summary

This is in anticipation of https://isocpp.org/files/papers/D2770R0.html,
which is ABI-breaking for join_view.

Diff Detail

Event Timeline

var-const created this revision.Jan 24 2023, 5:20 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 24 2023, 5:20 PM
Herald added a subscriber: arichardson. · View Herald Transcript
var-const requested review of this revision.Jan 24 2023, 5:20 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 24 2023, 5:20 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Jan 24 2023, 6:41 PM
ldionne added a subscriber: ldionne.

LGTM w/ changes and green CI

libcxx/include/__config
256 ↗(On Diff #491975)

I would avoid introducing this macro and simply use _LIBCPP_ENABLE_EXPERIMENTAL directly from join_view.

libcxx/test/libcxx/experimental/fexperimental-library.compile.pass.cpp
32–35 ↗(On Diff #491975)

This can go away.

libcxx/test/std/ranges/range.adaptors/range.join.view/adaptor.pass.cpp
10

I would simply use UNSUPPORTED: !c++experimental

This revision is now accepted and ready to land.Jan 24 2023, 6:41 PM

Address feedback.

var-const marked 3 inline comments as done.

Address feedback and rebase

@ldionne Hmm, how do I reconcile the change to release notes with https://github.com/llvm/llvm-project/commit/603c286334b07f568d39f6706c848f576914f323 that bumped the version to 17 and removed the 16's notes?

var-const updated this revision to Diff 492950.Jan 27 2023, 4:57 PM

Remove release notes from this patch.

This revision was landed with ongoing or failed builds.Jan 30 2023, 12:36 AM
This revision was automatically updated to reflect the committed changes.