diff --git a/llvm/lib/Support/RISCVISAInfo.cpp b/llvm/lib/Support/RISCVISAInfo.cpp --- a/llvm/lib/Support/RISCVISAInfo.cpp +++ b/llvm/lib/Support/RISCVISAInfo.cpp @@ -703,13 +703,10 @@ Desc.str().c_str(), Ext.str().c_str()); } - if (!IgnoreUnknown && Name.size() == Type.size()) { - if (IgnoreUnknown) - continue; + if (!IgnoreUnknown && Name.size() == Type.size()) return createStringError(errc::invalid_argument, "%s name missing after '%s'", Desc.str().c_str(), Type.str().c_str()); - } unsigned Major, Minor, ConsumeLength; if (auto E = getExtensionVersion(Name, Vers, Major, Minor, ConsumeLength, @@ -723,12 +720,9 @@ } // Check if duplicated extension. - if (!IgnoreUnknown && llvm::is_contained(AllExts, Name)) { - if (IgnoreUnknown) - continue; + if (!IgnoreUnknown && llvm::is_contained(AllExts, Name)) return createStringError(errc::invalid_argument, "duplicated %s '%s'", Desc.str().c_str(), Name.str().c_str()); - } ISAInfo->addExtension(Name, Major, Minor); // Extension format is correct, keep parsing the extensions. diff --git a/llvm/tools/llvm-objdump/llvm-objdump.cpp b/llvm/tools/llvm-objdump/llvm-objdump.cpp --- a/llvm/tools/llvm-objdump/llvm-objdump.cpp +++ b/llvm/tools/llvm-objdump/llvm-objdump.cpp @@ -2011,7 +2011,7 @@ // Package up features to be passed to target/subtarget Expected FeaturesValue = Obj->getFeatures(); if (!FeaturesValue) - WithColor::error(errs(), ToolName) << FeaturesValue.takeError(); + reportError(Obj->getFileName(), toString(FeaturesValue.takeError())); SubtargetFeatures Features = *FeaturesValue; if (!MAttrs.empty()) { for (unsigned I = 0; I != MAttrs.size(); ++I)