Page MenuHomePhabricator

Format: support inline namespaces
ClosedPublic

Authored by compnerd on Oct 29 2015, 3:15 PM.

Details

Reviewers
djasper
Summary

Correct handling for C++17 inline namespaces. We would previously fail to
identify the inline namespaces as a namespace name since multiple ones may be
concatenated now with C++17.

Diff Detail

Event Timeline

compnerd updated this revision to Diff 38768.Oct 29 2015, 3:15 PM
compnerd retitled this revision from to Format: support inline namespaces .
compnerd updated this object.
compnerd added a reviewer: djasper.
compnerd added a subscriber: cfe-commits.
djasper accepted this revision.Oct 29 2015, 3:30 PM
djasper edited edge metadata.

Expression can be simplified, otherwise looks good.

lib/Format/UnwrappedLineParser.cpp
1370
while (FormatTok->isOneOf(tok::identifier, tok::coloncolon))
  nextToken();
This revision is now accepted and ready to land.Oct 29 2015, 3:30 PM
compnerd closed this revision.Oct 30 2015, 7:23 AM

SVN r251690 with the mod.