This is an archive of the discontinued LLVM Phabricator instance.

Differential D141551

Require input target triples to have Environment field
AbandonedPublic

Authored by lamb-j on Jan 11 2023, 3:52 PM.

Details

Reviewers
yaxunl

Diff Detail

Event Timeline

lamb-j created this revision.Jan 11 2023, 3:52 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 11 2023, 3:52 PM
lamb-j requested review of this revision.Jan 11 2023, 3:52 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 11 2023, 3:52 PM
Herald added subscribers: cfe-commits, MaskRay. · View Herald Transcript
lamb-j added a reviewer: yaxunl.Jan 11 2023, 3:53 PM
Harbormaster completed remote builds in B207228: Diff 488405.Jan 11 2023, 7:06 PM
lamb-j abandoned this revision.Jan 12 2023, 9:16 AM

We're ok with env field being blank, so this doesn't accomplish what we need

Revision Contents

PathSize
clang/
lib/
Driver/
3 lines

Diff 488405

clang/lib/Driver/OffloadBundler.cpp

//===- OffloadBundler.cpp - File Bundling and Unbundling ------------------===// //===- OffloadBundler.cpp - File Bundling and Unbundling ------------------===//
Lint: Lint
Inline Actions

clang-format not found in user’s local PATH; not linting file.

Lint: Lint: clang-format not found in user’s local PATH; not linting file.
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
/// ///
▲ Show 20 Lines • Show All 93 Lines • ▼ Show 20 Lines bool OpenMPCompatibleWithHIP =
OffloadKind == "openmp" && OffloadKind == "openmp" &&
TargetOffloadKind.startswith_insensitive("hip"); TargetOffloadKind.startswith_insensitive("hip");
return HIPCompatibleWithOpenMP || OpenMPCompatibleWithHIP; return HIPCompatibleWithOpenMP || OpenMPCompatibleWithHIP;
} }
return false; return false;
} }
bool OffloadTargetInfo::isTripleValid() const { bool OffloadTargetInfo::isTripleValid() const {
return !Triple.str().empty() && Triple.getArch() != Triple::UnknownArch; return !Triple.str().empty() && Triple.getArch() != Triple::UnknownArch &&
Triple.hasEnvironment();
} }
bool OffloadTargetInfo::operator==(const OffloadTargetInfo &Target) const { bool OffloadTargetInfo::operator==(const OffloadTargetInfo &Target) const {
return OffloadKind == Target.OffloadKind && return OffloadKind == Target.OffloadKind &&
Triple.isCompatibleWith(Target.Triple) && TargetID == Target.TargetID; Triple.isCompatibleWith(Target.Triple) && TargetID == Target.TargetID;
} }
std::string OffloadTargetInfo::str() const { std::string OffloadTargetInfo::str() const {
▲ Show 20 Lines • Show All 1,177 Lines • Show Last 20 Lines