Page MenuHomePhabricator

[TestBreakpointCommand] Fix after r251121
ClosedPublic

Authored by sivachandra on Oct 23 2015, 2:22 PM.

Details

Summary

"from future import print_function" was added to the test file but
not to the embedded interpreter. This change uses file.write instead to
avoid all problems with print.

Diff Detail

Event Timeline

sivachandra retitled this revision from to [TestBreakpointCommand] Fix after r251121.
sivachandra updated this object.
sivachandra added a reviewer: zturner.
sivachandra added a subscriber: lldb-commits.
zturner edited edge metadata.Oct 23 2015, 2:30 PM
zturner added a subscriber: zturner.

Can you leave the from future import print_function at the top? That's
orthogonal to changing the dynamically executed code.

I can reproduce this problem by running LLDB in 2.7 and entering the
embedded interpreter and typing print("foo", file=sys.stdout). So I can
probably fix that and this is an ok workaround for now, but people still
need to be using print function instead of print statement on statically
generated python code, so I think the future statement should stay.

sivachandra edited edge metadata.

Put back the import of print_function from future.

zturner accepted this revision.Oct 23 2015, 2:38 PM
zturner edited edge metadata.
This revision is now accepted and ready to land.Oct 23 2015, 2:38 PM
sivachandra closed this revision.Oct 23 2015, 2:40 PM