diff --git a/clang-tools-extra/clangd/SemanticHighlighting.h b/clang-tools-extra/clangd/SemanticHighlighting.h --- a/clang-tools-extra/clangd/SemanticHighlighting.h +++ b/clang-tools-extra/clangd/SemanticHighlighting.h @@ -51,6 +51,8 @@ Macro, Modifier, Operator, + AngleBracketOpen, + AngleBracketClose, // This one is different from the other kinds as it's a line style // rather than a token style. diff --git a/clang-tools-extra/clangd/SemanticHighlighting.cpp b/clang-tools-extra/clangd/SemanticHighlighting.cpp --- a/clang-tools-extra/clangd/SemanticHighlighting.cpp +++ b/clang-tools-extra/clangd/SemanticHighlighting.cpp @@ -368,6 +368,63 @@ return addToken(*Range, Kind); } + // Most of this function works around + // https://github.com/clangd/clangd/issues/871. + void addAngleBracketTokens(SourceLocation LLoc, SourceLocation RLoc) { + if (!LLoc.isValid() || !RLoc.isValid()) + return; + + auto LRange = getRangeForSourceLocation(LLoc); + if (!LRange) + return; + + // For the inner element of a nested template instantiation with no space + // between the '>' characters, TemplateSpecializationLocInfo::RAngleLoc has + // the MacroIDBit set, and the "expansion location" refers to the actual + // location in the code. + if (!RLoc.isFileID()) + RLoc = SourceMgr.getExpansionLoc(RLoc); + if (!RLoc.isFileID()) + return; + + const auto *RTok = TB.spelledTokenAt(RLoc); + + // The normal, non-nested case. + if (RTok && RTok->kind() != tok::greatergreater) { + auto RRange = halfOpenToRange( + SourceMgr, RTok->range(SourceMgr).toCharRange(SourceMgr)); + addToken(*LRange, HighlightingKind::AngleBracketOpen); + addToken(RRange, HighlightingKind::AngleBracketClose); + return; + } + + // This handles the inner element of a nested template instantiation. + // Our angle bracket is the first character of a mis-lexed ">>" construct, + // so we need to adjust the length of the clang token. + if (RTok) { + CharSourceRange TokRange = RTok->range(SourceMgr).toCharRange(SourceMgr); + Position Begin = sourceLocToPosition(SourceMgr, TokRange.getBegin()); + Position End = Begin; + ++End.character; + addToken(*LRange, HighlightingKind::AngleBracketOpen); + addToken({Begin, End}, HighlightingKind::AngleBracketClose); + return; + } + + // This handles the outer element of a nested template instantiation. + // Our angle bracket is the second character of a mis-lexed ">>" construct, + // so the clang token starts one character to the left of it. + RTok = TB.spelledTokenAt(RLoc.getLocWithOffset(-1)); + if (!RTok || RTok->kind() != tok::greatergreater) + return; + CharSourceRange TokRange = RTok->range(SourceMgr).toCharRange(SourceMgr); + Position End = sourceLocToPosition(SourceMgr, TokRange.getEnd()); + Position Begin = End; + --Begin.character; + addToken(*LRange, HighlightingKind::AngleBracketOpen); + addToken({Begin, End}, HighlightingKind::AngleBracketClose); + } + HighlightingToken &addToken(Range R, HighlightingKind Kind) { HighlightingToken HT; HT.R = std::move(R); @@ -566,6 +623,17 @@ return true; } + bool VisitTemplateDecl(TemplateDecl *D) { + if (auto *TPL = D->getTemplateParameters()) + H.addAngleBracketTokens(TPL->getLAngleLoc(), TPL->getRAngleLoc()); + return true; + } + + bool VisitTemplateSpecializationTypeLoc(TemplateSpecializationTypeLoc L) { + H.addAngleBracketTokens(L.getLAngleLoc(), L.getRAngleLoc()); + return true; + } + bool VisitFunctionDecl(FunctionDecl *D) { if (D->isOverloadedOperator()) { const auto addOpDeclToken = [&](SourceLocation Loc) { @@ -580,6 +648,8 @@ if (Kind == OO_Call || Kind == OO_Subscript) addOpDeclToken(Range.getEnd()); } + if (auto *Args = D->getTemplateSpecializationArgsAsWritten()) + H.addAngleBracketTokens(Args->getLAngleLoc(), Args->getRAngleLoc()); return true; } @@ -631,6 +701,12 @@ return true; } + bool VisitCXXNamedCastExpr(CXXNamedCastExpr *E) { + const auto &B = E->getAngleBrackets(); + H.addAngleBracketTokens(B.getBegin(), B.getEnd()); + return true; + } + bool VisitCallExpr(CallExpr *E) { // Highlighting parameters passed by non-const reference does not really // make sense for literals... @@ -1073,6 +1149,10 @@ return OS << "Modifier"; case HighlightingKind::Operator: return OS << "Operator"; + case HighlightingKind::AngleBracketOpen: + return OS << "AngleBracketOpen"; + case HighlightingKind::AngleBracketClose: + return OS << "AngleBracketClose"; case HighlightingKind::InactiveCode: return OS << "InactiveCode"; } @@ -1211,6 +1291,10 @@ return "modifier"; case HighlightingKind::Operator: return "operator"; + case HighlightingKind::AngleBracketOpen: + return "angleBracketOpen"; + case HighlightingKind::AngleBracketClose: + return "angleBracketClose"; case HighlightingKind::InactiveCode: return "comment"; } diff --git a/clang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp b/clang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp --- a/clang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp +++ b/clang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp @@ -130,17 +130,17 @@ )cpp", R"cpp( namespace $Namespace_decl[[abc]] { - template + template$AngleBracketOpen[[<]]typename $TemplateParameter_def[[T]]$AngleBracketClose[[>]] struct $Class_def[[A]] { $TemplateParameter[[T]] $Field_decl[[t]]; }; } - template - struct $Class_def[[C]] : $Namespace[[abc]]::$Class[[A]]<$TemplateParameter[[T]]> { + template$AngleBracketOpen[[<]]typename $TemplateParameter_def[[T]]$AngleBracketClose[[>]] + struct $Class_def[[C]] : $Namespace[[abc]]::$Class[[A]]$AngleBracketOpen[[<]]$TemplateParameter[[T]]$AngleBracketClose[[>]] { typename $TemplateParameter[[T]]::$Type_dependentName[[A]]* $Field_decl[[D]]; }; - $Namespace[[abc]]::$Class[[A]] $Variable_def[[AA]]; - typedef $Namespace[[abc]]::$Class[[A]] $Class_decl[[AAA]]; + $Namespace[[abc]]::$Class[[A]]$AngleBracketOpen[[<]]int$AngleBracketClose[[>]] $Variable_def[[AA]]; + typedef $Namespace[[abc]]::$Class[[A]]$AngleBracketOpen[[<]]int$AngleBracketClose[[>]] $Class_decl[[AAA]]; struct $Class_def[[B]] { $Class_decl_constrDestr[[B]](); ~$Class_decl_constrDestr[[B]](); @@ -243,36 +243,36 @@ typedef float $Primitive_decl[[F]]; )cpp", R"cpp( - template + template$AngleBracketOpen[[<]]typename $TemplateParameter_def[[T]], typename = void$AngleBracketClose[[>]] class $Class_def[[A]] { $TemplateParameter[[T]] $Field_decl[[AA]]; $TemplateParameter[[T]] $Method_decl[[foo]](); }; - template + template$AngleBracketOpen[[<]]class $TemplateParameter_def[[TT]]$AngleBracketClose[[>]] class $Class_def[[B]] { - $Class[[A]]<$TemplateParameter[[TT]]> $Field_decl[[AA]]; + $Class[[A]]$AngleBracketOpen[[<]]$TemplateParameter[[TT]]$AngleBracketClose[[>]] $Field_decl[[AA]]; }; - template + template$AngleBracketOpen[[<]]class $TemplateParameter_def[[TT]], class $TemplateParameter_def[[GG]]$AngleBracketClose[[>]] class $Class_def[[BB]] {}; template class $Class_def[[BB]]<$TemplateParameter[[T]], int> {}; template class $Class_def[[BB]]<$TemplateParameter[[T]], $TemplateParameter[[T]]*> {}; - template class $TemplateParameter_def[[T]], class $TemplateParameter_def[[C]]> - $TemplateParameter[[T]]<$TemplateParameter[[C]]> $Function_decl[[f]](); + template$AngleBracketOpen[[<]]template$AngleBracketOpen[[<]]class$AngleBracketClose[[>]] class $TemplateParameter_def[[T]], class $TemplateParameter_def[[C]]$AngleBracketClose[[>]] + $TemplateParameter[[T]]$AngleBracketOpen[[<]]$TemplateParameter[[C]]$AngleBracketClose[[>]] $Function_decl[[f]](); - template + template$AngleBracketOpen[[<]]typename$AngleBracketClose[[>]] class $Class_def[[Foo]] {}; - template + template$AngleBracketOpen[[<]]typename $TemplateParameter_def[[T]]$AngleBracketClose[[>]] void $Function_decl[[foo]]($TemplateParameter[[T]] ...); )cpp", R"cpp( - template + template $AngleBracketOpen[[<]]class $TemplateParameter_def[[T]]$AngleBracketClose[[>]] struct $Class_def[[Tmpl]] {$TemplateParameter[[T]] $Field_decl[[x]] = 0;}; - extern template struct $Class_def[[Tmpl]]; - template struct $Class_def[[Tmpl]]; + extern template struct $Class_def[[Tmpl]]$AngleBracketOpen[[<]]float$AngleBracketClose[[>]]; + template struct $Class_def[[Tmpl]]$AngleBracketOpen[[<]]double$AngleBracketClose[[>]]; )cpp", // This test is to guard against highlightings disappearing when using // conversion operators as their behaviour in the clang AST differ from @@ -335,17 +335,17 @@ )cpp", R"cpp( class $Class_def[[G]] {}; - template<$Class[[G]] *$TemplateParameter_def_readonly[[U]]> + template$AngleBracketOpen[[<]]$Class[[G]] *$TemplateParameter_def_readonly[[U]]$AngleBracketClose[[>]] class $Class_def[[GP]] {}; - template<$Class[[G]] &$TemplateParameter_def_readonly[[U]]> + template$AngleBracketOpen[[<]]$Class[[G]] &$TemplateParameter_def_readonly[[U]]$AngleBracketClose[[>]] class $Class_def[[GR]] {}; - template + template$AngleBracketOpen[[<]]int *$TemplateParameter_def_readonly[[U]]$AngleBracketClose[[>]] class $Class_def[[IP]] { void $Method_def[[f]]() { $Operator[[*]]$TemplateParameter_readonly[[U]] $Operator[[+=]] 5; } }; - template + template$AngleBracketOpen[[<]]unsigned $TemplateParameter_def_readonly[[U]] = 2$AngleBracketClose[[>]] class $Class_def[[Foo]] { void $Method_def[[f]]() { for(int $LocalVariable_def[[I]] = 0; @@ -355,14 +355,14 @@ $Class[[G]] $Variable_def[[L]]; void $Function_def[[f]]() { - $Class[[Foo]]<123> $LocalVariable_def[[F]]; - $Class[[GP]]<$Operator[[&]]$Variable[[L]]> $LocalVariable_def[[LL]]; - $Class[[GR]]<$Variable[[L]]> $LocalVariable_def[[LLL]]; + $Class[[Foo]]$AngleBracketOpen[[<]]123$AngleBracketClose[[>]] $LocalVariable_def[[F]]; + $Class[[GP]]$AngleBracketOpen[[<]]$Operator[[&]]$Variable[[L]]$AngleBracketClose[[>]] $LocalVariable_def[[LL]]; + $Class[[GR]]$AngleBracketOpen[[<]]$Variable[[L]]$AngleBracketClose[[>]] $LocalVariable_def[[LLL]]; } )cpp", R"cpp( - template + template$AngleBracketOpen[[<]]typename $TemplateParameter_def[[T]], + void ($TemplateParameter[[T]]::*$TemplateParameter_def_readonly[[method]])(int)$AngleBracketClose[[>]] struct $Class_def[[G]] { void $Method_def[[foo]]( $TemplateParameter[[T]] *$Parameter_def[[O]]) { @@ -373,7 +373,7 @@ struct $Class_def[[F]] { void $Method_decl[[f]](int); }; - template + template$AngleBracketOpen[[<]]void (*$TemplateParameter_def_readonly[[Func]])()$AngleBracketClose[[>]] struct $Class_def[[A]] { void $Method_def[[f]]() { ($Operator[[*]]$TemplateParameter_readonly[[Func]])(); @@ -382,9 +382,9 @@ void $Function_def[[foo]]() { $Class[[F]] $LocalVariable_def[[FF]]; - $Class[[G]]<$Class[[F]], $Operator[[&]]$Class[[F]]::$Method[[f]]> $LocalVariable_def[[GG]]; + $Class[[G]]$AngleBracketOpen[[<]]$Class[[F]], $Operator[[&]]$Class[[F]]::$Method[[f]]$AngleBracketClose[[>]] $LocalVariable_def[[GG]]; $LocalVariable[[GG]].$Method[[foo]]($Operator[[&]]$LocalVariable_usedAsMutablePointer[[FF]]); - $Class[[A]]<$Function[[foo]]> $LocalVariable_def[[AA]]; + $Class[[A]]$AngleBracketOpen[[<]]$Function[[foo]]$AngleBracketClose[[>]] $LocalVariable_def[[AA]]; } )cpp", // Tokens that share a source range but have conflicting Kinds are not @@ -472,7 +472,7 @@ } )cpp", R"cpp( - template + template$AngleBracketOpen[[<]]class $TemplateParameter_def[[T]]$AngleBracketClose[[>]] class $Class_def[[A]] { using $TemplateParameter_decl[[TemplateParam1]] = $TemplateParameter[[T]]; typedef $TemplateParameter[[T]] $TemplateParameter_decl[[TemplateParam2]]; @@ -491,9 +491,9 @@ }; )cpp", R"cpp( - template + template $AngleBracketOpen[[<]]class $TemplateParameter_def[[T]]$AngleBracketClose[[>]] void $Function_decl[[phase1]]($TemplateParameter[[T]]); - template + template $AngleBracketOpen[[<]]class $TemplateParameter_def[[T]]$AngleBracketClose[[>]] void $Function_def[[foo]]($TemplateParameter[[T]] $Parameter_def[[P]]) { $Function[[phase1]]($Parameter[[P]]); $Unknown_dependentName[[phase2]]($Parameter[[P]]); @@ -501,22 +501,22 @@ )cpp", R"cpp( class $Class_def[[A]] { - template + template $AngleBracketOpen[[<]]class $TemplateParameter_def[[T]]$AngleBracketClose[[>]] void $Method_decl[[bar]]($TemplateParameter[[T]]); }; - template + template $AngleBracketOpen[[<]]class $TemplateParameter_def[[U]]$AngleBracketClose[[>]] void $Function_def[[foo]]($TemplateParameter[[U]] $Parameter_def[[P]]) { $Class[[A]]().$Method[[bar]]($Parameter[[P]]); } )cpp", R"cpp( struct $Class_def[[A]] { - template + template $AngleBracketOpen[[<]]class $TemplateParameter_def[[T]]$AngleBracketClose[[>]] static void $StaticMethod_decl_static[[foo]]($TemplateParameter[[T]]); }; - template + template $AngleBracketOpen[[<]]class $TemplateParameter_def[[T]]$AngleBracketClose[[>]] struct $Class_def[[B]] { void $Method_def[[bar]]() { $Class[[A]]::$StaticMethod_static[[foo]]($TemplateParameter[[T]]()); @@ -524,18 +524,18 @@ }; )cpp", R"cpp( - template + template $AngleBracketOpen[[<]]class $TemplateParameter_def[[T]]$AngleBracketClose[[>]] void $Function_decl[[foo]](typename $TemplateParameter[[T]]::$Type_dependentName[[Type]] = $TemplateParameter[[T]]::$Unknown_dependentName[[val]]); )cpp", R"cpp( - template + template $AngleBracketOpen[[<]]class $TemplateParameter_def[[T]]$AngleBracketClose[[>]] void $Function_def[[foo]]($TemplateParameter[[T]] $Parameter_def[[P]]) { $Parameter[[P]].$Unknown_dependentName[[Field]]; } )cpp", R"cpp( - template + template $AngleBracketOpen[[<]]class $TemplateParameter_def[[T]]$AngleBracketClose[[>]] class $Class_def[[A]] { int $Method_def[[foo]]() { return $TemplateParameter[[T]]::$Unknown_dependentName[[Field]]; @@ -549,10 +549,10 @@ )cpp", // Highlighting of template template arguments. R"cpp( - template