diff --git a/clang/lib/Sema/SemaInit.cpp b/clang/lib/Sema/SemaInit.cpp --- a/clang/lib/Sema/SemaInit.cpp +++ b/clang/lib/Sema/SemaInit.cpp @@ -3860,8 +3860,20 @@ if (VD->getInit() || VD->getEndLoc().isMacroID()) return false; + SourceLocation EndLoc = VD->getEndLoc(); + if (const auto *VTSD = dyn_cast(VD)) { + if (const auto *VTPSD = + dyn_cast(VD)) { + if (const ASTTemplateArgumentListInfo *Info = + VTPSD->getTemplateArgsAsWritten()) + EndLoc = Info->getRAngleLoc(); + } + if (const ASTTemplateArgumentListInfo *Info = VTSD->getTemplateArgsInfo()) + EndLoc = Info->getRAngleLoc(); + } + QualType VariableTy = VD->getType().getCanonicalType(); - SourceLocation Loc = S.getLocForEndOfToken(VD->getEndLoc()); + SourceLocation Loc = S.getLocForEndOfToken(EndLoc); std::string Init = S.getFixItZeroInitializerForType(VariableTy, Loc); if (!Init.empty()) { Sequence.AddZeroInitializationStep(Entity.getType()); diff --git a/clang/test/FixIt/fixit-const-var-init.cpp b/clang/test/FixIt/fixit-const-var-init.cpp new file mode 100644 --- /dev/null +++ b/clang/test/FixIt/fixit-const-var-init.cpp @@ -0,0 +1,25 @@ +// RUN: not %clang_cc1 -fdiagnostics-parseable-fixits -x c++ -std=c++14 %s 2>&1 | FileCheck %s + +const int a; // expected-error {{default initialization of an object of const type}} +// CHECK: fix-it:"{{.*}}":{3:12-3:12}:" = 0" + +template const int b; // expected-error {{default initialization of an object of const type}} +// CHECK: fix-it:"{{.*}}":{6:36-6:36}:" = 0" + +template const int b; // expected-error {{default initialization of an object of const type}} +// CHECK: fix-it:"{{.*}}":{9:39-9:39}:" = 0" + +template <> const int b; // expected-error {{default initialization of an object of const type}} +// CHECK: fix-it:"{{.*}}":{12:36-12:36}:" = 0" + +constexpr float c; // expected-error {{must be initialized by a constant expression}} +// CHECK: fix-it:"{{.*}}":{15:18-15:18}:" = 0.0" + +template constexpr float d; // expected-error {{must be initialized by a constant expression}} +// CHECK: fix-it:"{{.*}}":{18:42-18:42}:" = 0.0" + +template constexpr float d; // expected-error {{must be initialized by a constant expression}} +// CHECK: fix-it:"{{.*}}":{21:45-21:45}:" = 0.0" + +template <> constexpr float d; // expected-error {{must be initialized by a constant expression}} +// CHECK: fix-it:"{{.*}}":{24:42-24:42}:" = 0.0"