diff --git a/llvm/lib/ObjCopy/ELF/ELFObject.cpp b/llvm/lib/ObjCopy/ELF/ELFObject.cpp --- a/llvm/lib/ObjCopy/ELF/ELFObject.cpp +++ b/llvm/lib/ObjCopy/ELF/ELFObject.cpp @@ -2089,7 +2089,7 @@ Size); } - for (auto it : Obj.getUpdatedSections()) { + for (const auto &it : Obj.getUpdatedSections()) { SectionBase *Sec = it.first; ArrayRef Data = it.second; diff --git a/llvm/lib/Object/COFFImportFile.cpp b/llvm/lib/Object/COFFImportFile.cpp --- a/llvm/lib/Object/COFFImportFile.cpp +++ b/llvm/lib/Object/COFFImportFile.cpp @@ -578,7 +578,7 @@ std::vector NullThunk; Members.push_back(OF.createNullThunk(NullThunk)); - for (COFFShortExport E : Exports) { + for (const COFFShortExport &E : Exports) { if (E.Private) continue; diff --git a/llvm/lib/ObjectYAML/MachOEmitter.cpp b/llvm/lib/ObjectYAML/MachOEmitter.cpp --- a/llvm/lib/ObjectYAML/MachOEmitter.cpp +++ b/llvm/lib/ObjectYAML/MachOEmitter.cpp @@ -426,7 +426,7 @@ void MachOWriter::writeBindOpcodes( raw_ostream &OS, std::vector &BindOpcodes) { - for (auto &Opcode : BindOpcodes) { + for (const auto &Opcode : BindOpcodes) { uint8_t OpByte = Opcode.Opcode | Opcode.Imm; OS.write(reinterpret_cast(&OpByte), 1); for (auto Data : Opcode.ULEBExtraData) { @@ -458,7 +458,7 @@ } } OS.write(static_cast(Entry.Children.size())); - for (auto EE : Entry.Children) { + for (const auto &EE : Entry.Children) { OS << EE.Name; OS.write('\0'); encodeULEB128(EE.NodeOffset, OS); @@ -559,7 +559,7 @@ void MachOWriter::writeRebaseOpcodes(raw_ostream &OS) { MachOYAML::LinkEditData &LinkEdit = Obj.LinkEdit; - for (auto Opcode : LinkEdit.RebaseOpcodes) { + for (const auto &Opcode : LinkEdit.RebaseOpcodes) { uint8_t OpByte = Opcode.Opcode | Opcode.Imm; OS.write(reinterpret_cast(&OpByte), 1); for (auto Data : Opcode.ExtraData) diff --git a/llvm/lib/Support/VirtualFileSystem.cpp b/llvm/lib/Support/VirtualFileSystem.cpp --- a/llvm/lib/Support/VirtualFileSystem.cpp +++ b/llvm/lib/Support/VirtualFileSystem.cpp @@ -489,7 +489,7 @@ if (Type == PrintType::Contents) Type = PrintType::Summary; - for (auto FS : overlays_range()) + for (const auto &FS : overlays_range()) FS->print(OS, Type, IndentLevel + 1); } @@ -552,7 +552,7 @@ public: CombiningDirIterImpl(ArrayRef FileSystems, std::string Dir, std::error_code &EC) { - for (auto FS : FileSystems) { + for (const auto &FS : FileSystems) { std::error_code FEC; directory_iterator Iter = FS->dir_begin(Dir, FEC); if (FEC && FEC != errc::no_such_file_or_directory) { diff --git a/llvm/lib/TextAPI/TextStub.cpp b/llvm/lib/TextAPI/TextStub.cpp --- a/llvm/lib/TextAPI/TextStub.cpp +++ b/llvm/lib/TextAPI/TextStub.cpp @@ -1174,7 +1174,7 @@ std::vector Files; Files.emplace_back(&File); - for (auto Document : File.documents()) + for (const auto &Document : File.documents()) Files.emplace_back(Document.get()); // Stream out yaml. diff --git a/llvm/tools/llvm-pdbutil/llvm-pdbutil.cpp b/llvm/tools/llvm-pdbutil/llvm-pdbutil.cpp --- a/llvm/tools/llvm-pdbutil/llvm-pdbutil.cpp +++ b/llvm/tools/llvm-pdbutil/llvm-pdbutil.cpp @@ -842,7 +842,7 @@ ExitOnErr(DbiBuilder.addModuleSourceFile(ModiBuilder, S)); if (MI.Modi) { const auto &ModiStream = *MI.Modi; - for (auto Symbol : ModiStream.Symbols) { + for (const auto &Symbol : ModiStream.Symbols) { ModiBuilder.addSymbol( Symbol.toCodeViewSymbol(Allocator, CodeViewContainer::Pdb)); } diff --git a/llvm/tools/llvm-readtapi/DiffEngine.cpp b/llvm/tools/llvm-readtapi/DiffEngine.cpp --- a/llvm/tools/llvm-readtapi/DiffEngine.cpp +++ b/llvm/tools/llvm-readtapi/DiffEngine.cpp @@ -224,7 +224,7 @@ Order); diffAttribute("Parent Umbrellas", Output, Interface->umbrellas(), Order); diffAttribute("Symbols", Output, Interface->symbols(), Order); - for (auto Doc : Interface->documents()) { + for (const auto &Doc : Interface->documents()) { DiffOutput Documents("Inlined Reexported Frameworks/Libraries"); Documents.Kind = AD_Inline_Doc; Documents.Values.push_back(std::make_unique( diff --git a/llvm/tools/llvm-xray/xray-converter.cpp b/llvm/tools/llvm-xray/xray-converter.cpp --- a/llvm/tools/llvm-xray/xray-converter.cpp +++ b/llvm/tools/llvm-xray/xray-converter.cpp @@ -190,7 +190,7 @@ SmallVector Siblings{}; if (parent == nullptr) { - for (auto map_iter : StackRootsByThreadId) { + for (const auto &map_iter : StackRootsByThreadId) { // Only look for siblings in other threads. if (map_iter.first != TId) for (auto node_iter : map_iter.second) { diff --git a/llvm/tools/llvm-xray/xray-fdr-dump.cpp b/llvm/tools/llvm-xray/xray-fdr-dump.cpp --- a/llvm/tools/llvm-xray/xray-fdr-dump.cpp +++ b/llvm/tools/llvm-xray/xray-fdr-dump.cpp @@ -101,7 +101,7 @@ // Then we validate while printing each block. BlockVerifier BV; - for (auto ProcessThreadBlocks : Index) { + for (const auto &ProcessThreadBlocks : Index) { auto &Blocks = ProcessThreadBlocks.second; for (auto &B : Blocks) { for (auto *R : B.Records) { diff --git a/llvm/unittests/ADT/IteratorTest.cpp b/llvm/unittests/ADT/IteratorTest.cpp --- a/llvm/unittests/ADT/IteratorTest.cpp +++ b/llvm/unittests/ADT/IteratorTest.cpp @@ -274,7 +274,7 @@ int A[] = {0, 1, 2, 3, 4, 5, 6}; auto Enumerate = llvm::enumerate(A); SmallVector Actual; - for (auto IndexedValue : make_filter_range(Enumerate, IsOdd)) + for (const auto &IndexedValue : make_filter_range(Enumerate, IsOdd)) Actual.push_back(IndexedValue.value()); EXPECT_EQ((SmallVector{1, 3, 5}), Actual); } diff --git a/llvm/unittests/FileCheck/FileCheckTest.cpp b/llvm/unittests/FileCheck/FileCheckTest.cpp --- a/llvm/unittests/FileCheck/FileCheckTest.cpp +++ b/llvm/unittests/FileCheck/FileCheckTest.cpp @@ -1644,7 +1644,7 @@ std::vector Diags; Tester.printVariableDefs(FileCheckDiag::MatchFoundAndExpected, Diags); EXPECT_EQ(Diags.size(), 2ul); - for (FileCheckDiag Diag : Diags) { + for (const FileCheckDiag &Diag : Diags) { EXPECT_EQ(Diag.CheckTy, Check::CheckPlain); EXPECT_EQ(Diag.MatchTy, FileCheckDiag::MatchFoundAndExpected); EXPECT_EQ(Diag.InputStartLine, 1u); diff --git a/llvm/utils/TableGen/IntrinsicEmitter.cpp b/llvm/utils/TableGen/IntrinsicEmitter.cpp --- a/llvm/utils/TableGen/IntrinsicEmitter.cpp +++ b/llvm/utils/TableGen/IntrinsicEmitter.cpp @@ -214,7 +214,7 @@ << " size_t Count;\n" << "};\n"; OS << "static constexpr IntrinsicTargetInfo TargetInfos[] = {\n"; - for (auto Target : Ints.Targets) + for (const auto &Target : Ints.Targets) OS << " {llvm::StringLiteral(\"" << Target.Name << "\"), " << Target.Offset << ", " << Target.Count << "},\n"; OS << "};\n";