diff --git a/clang/lib/Driver/ToolChains/Gnu.cpp b/clang/lib/Driver/ToolChains/Gnu.cpp --- a/clang/lib/Driver/ToolChains/Gnu.cpp +++ b/clang/lib/Driver/ToolChains/Gnu.cpp @@ -331,8 +331,8 @@ if (HasStaticPIE && Args.hasArg(options::OPT_nopie)) { const Driver &D = TC.getDriver(); const llvm::opt::OptTable &Opts = D.getOpts(); - const char *StaticPIEName = Opts.getOptionName(options::OPT_static_pie); - const char *NoPIEName = Opts.getOptionName(options::OPT_nopie); + StringRef StaticPIEName = Opts.getOptionName(options::OPT_static_pie); + StringRef NoPIEName = Opts.getOptionName(options::OPT_nopie); D.Diag(diag::err_drv_cannot_mix_options) << StaticPIEName << NoPIEName; } return HasStaticPIE; diff --git a/llvm/include/llvm/Option/OptTable.h b/llvm/include/llvm/Option/OptTable.h --- a/llvm/include/llvm/Option/OptTable.h +++ b/llvm/include/llvm/Option/OptTable.h @@ -44,7 +44,7 @@ /// A null terminated array of prefix strings to apply to name while /// matching. const char *const *Prefixes; - const char *Name; + StringRef Name; const char *HelpText; const char *MetaVar; unsigned ID; @@ -102,9 +102,7 @@ const Option getOption(OptSpecifier Opt) const; /// Lookup the name of the given option. - const char *getOptionName(OptSpecifier id) const { - return getInfo(id).Name; - } + StringRef getOptionName(OptSpecifier id) const { return getInfo(id).Name; } /// Get the kind of the given option. unsigned getOptionKind(OptSpecifier id) const { @@ -184,7 +182,7 @@ /// takes /// /// \return true in success, and false in fail. - bool addValues(const char *Option, const char *Values); + bool addValues(StringRef Option, const char *Values); /// Parse a single argument; returning the new argument and /// updating Index. diff --git a/llvm/lib/Option/OptTable.cpp b/llvm/lib/Option/OptTable.cpp --- a/llvm/lib/Option/OptTable.cpp +++ b/llvm/lib/Option/OptTable.cpp @@ -87,7 +87,7 @@ // Support lower_bound between info and an option name. static inline bool operator<(const OptTable::Info &I, const char *Name) { - return StrCmpOptionNameIgnoreCase(I.Name, Name) < 0; + return StrCmpOptionNameIgnoreCase(I.Name.data(), Name) < 0; } } // end namespace opt @@ -321,7 +321,7 @@ return BestDistance; } -bool OptTable::addValues(const char *Option, const char *Values) { +bool OptTable::addValues(StringRef Option, const char *Values) { for (size_t I = FirstSearchableIndex, E = OptionInfos.size(); I < E; I++) { Info &In = OptionInfos[I]; if (optionMatches(In, Option)) { diff --git a/llvm/utils/TableGen/OptParserEmitter.cpp b/llvm/utils/TableGen/OptParserEmitter.cpp --- a/llvm/utils/TableGen/OptParserEmitter.cpp +++ b/llvm/utils/TableGen/OptParserEmitter.cpp @@ -54,9 +54,9 @@ static void emitNameUsingSpelling(raw_ostream &OS, const Record &R) { size_t PrefixLength; - OS << "&"; + OS << "llvm::StringRef("; write_cstring(OS, StringRef(getOptionSpelling(R, PrefixLength))); - OS << "[" << PrefixLength << "]"; + OS << ").substr(" << PrefixLength << ")"; } class MarshallingInfo {