Page MenuHomePhabricator

Skip TestMultithread.py on Windows because it times out (and they'd fail anyway)
ClosedPublic

Authored by amccarth on Oct 20 2015, 5:50 PM.

Details

Summary

I'm not sure why this was timing out when running on my machine, since it took only 45 second for the tests to fail and the timeout seem to be set to 240 seconds.

Simply skipping these cases wasn't enough because the inferior was being built 12 times (once for each call to setUp). So I moved the setUp work into the tests themselves. Skipping stops wasting time building and rebuilding the inferiors. It also seems to avoid the last lingering intermittent GNU Make crash.

Before going this route, I spent a lot of time trying to get the inferior to build on Windows. I had to fix some POSIX assumptions in common.h and enable exceptions (which have been disabled on Windows because clang-cl exception support on Windows was lagging). Enabling exceptions caused four other tests to fail, so we have that to look forward to. And I wasn't able to figure out the linking problem where it complained that the -L option was ignored and then complained that it couldn't find liblldb.lib (because it ignored the -L option).

I'm open to other ideas, but this is the best way I can see to get unblocked.

Event Timeline

amccarth updated this revision to Diff 37953.Oct 20 2015, 5:50 PM
amccarth retitled this revision from to Skip TestMultithread.py on Windows because it times out (and they'd fail anyway).
amccarth updated this object.
amccarth added a reviewer: zturner.
amccarth added a subscriber: lldb-commits.
zturner accepted this revision.Oct 20 2015, 8:22 PM
zturner edited edge metadata.
This revision is now accepted and ready to land.Oct 20 2015, 8:22 PM
This revision was automatically updated to reflect the committed changes.