Page MenuHomePhabricator

Minor fix in ToolChainTest.cpp to allow user defined GCC toolchain.
ClosedPublic

Authored by sfantao on Oct 20 2015, 4:09 PM.

Details

Reviewers
bkramer
Summary

If the user configured clang with a custom GCC toolchain that will take precedence on what the ToolChainTest.cpp expects to evaluate. This was causing the test to fail in these cases.

This patch fixes the issue by passing --gcc-toolchain= to the driver, in order to override any user defined GCC toolchain.

Diff Detail

Event Timeline

sfantao updated this revision to Diff 37942.Oct 20 2015, 4:09 PM
sfantao retitled this revision from to Minor fix in ToolChainTest.cpp to allow user defined GCC toolchain..
sfantao updated this object.
sfantao added a reviewer: bkramer.
sfantao added a subscriber: cfe-commits.
bkramer accepted this revision.Oct 27 2015, 11:40 AM
bkramer edited edge metadata.

This should be fine. Sorry for the breakage.

This revision is now accepted and ready to land.Oct 27 2015, 11:40 AM
sfantao closed this revision.Oct 27 2015, 3:23 PM

Committed in r251459.

Thanks!
Samuel