Page MenuHomePhabricator

Roll-back r250822.
ClosedPublic

Authored by angelgarcia on Oct 20 2015, 6:23 AM.

Details

Summary

It breaks the build for the ASTMatchers

Diff Detail

Repository
rL LLVM

Event Timeline

angelgarcia retitled this revision from to Roll-back r250822..
angelgarcia updated this object.
angelgarcia added a subscriber: cfe-commits.
This revision was automatically updated to reflect the committed changes.
ariccio added a subscriber: ariccio.Feb 3 2016, 1:06 PM

Whatever happened to this? What in ASTMatchers did it break? It seems like a good change, and nobody followed up to fix it?

The compiler complained about creating constant instances of classes
without a user provided constructor (which is the case for the ASTMatchers).

I gave up this change because it broke the build for a huge amount of
people and I didn't want that to happen again.

The compiler complained about creating constant instances of classes
without a user provided constructor (which is the case for the ASTMatchers).

I gave up this change because it broke the build for a huge amount of
people and I didn't want that to happen again.

Ahh, ok. I saw one of these in MemRegion.cpp, and noticed this.