This is an archive of the discontinued LLVM Phabricator instance.

mlir/linalg: use std::optional
ClosedPublic

Authored by artagnon on Nov 27 2022, 11:18 AM.

Details

Summary

This is part of an effort to migrate from llvm::Optional to std::optional:

See also: https://discourse.llvm.org/t/deprecating-llvm-optional-x-hasvalue-getvalue-getvalueor/63716

Signed-off-by: Ramkumar Ramachandra <r@artagnon.com>

Diff Detail

Event Timeline

artagnon created this revision.Nov 27 2022, 11:18 AM
artagnon requested review of this revision.Nov 27 2022, 11:18 AM
kazu accepted this revision.Nov 27 2022, 11:29 AM

Thanks a lot for helping with the migration!

This revision is now accepted and ready to land.Nov 27 2022, 11:29 AM

Hi. Ever since the migration to the git monorepo (I know, it's been a while), I don't have commit access. Could you kindly commit this and D138765 for me? Thanks.

kazu added a comment.Nov 27 2022, 1:32 PM

Hi. Ever since the migration to the git monorepo (I know, it's been a while), I don't have commit access. Could you kindly commit this and D138765 for me? Thanks.

Done.

mravishankar accepted this revision.Nov 28 2022, 12:45 PM
artagnon closed this revision.Nov 29 2022, 2:19 AM

Committed as 537137ece1d.