Index: clang/lib/CodeGen/ItaniumCXXABI.cpp =================================================================== --- clang/lib/CodeGen/ItaniumCXXABI.cpp +++ clang/lib/CodeGen/ItaniumCXXABI.cpp @@ -4675,13 +4675,16 @@ /// void @__clang_call_terminate(i8* %exn) nounwind noreturn /// This code is used only in C++. static llvm::FunctionCallee getClangCallTerminateFn(CodeGenModule &CGM) { - llvm::FunctionType *fnTy = - llvm::FunctionType::get(CGM.VoidTy, CGM.Int8PtrTy, /*isVarArg=*/false); + ASTContext &C = CGM.getContext(); + const CGFunctionInfo &FI = CGM.getTypes().arrangeBuiltinFunctionDeclaration( + C.VoidTy, {C.getPointerType(C.CharTy)}); + llvm::FunctionType *fnTy = CGM.getTypes().GetFunctionType(FI); llvm::FunctionCallee fnRef = CGM.CreateRuntimeFunction( fnTy, "__clang_call_terminate", llvm::AttributeList(), /*Local=*/true); llvm::Function *fn = cast(fnRef.getCallee()->stripPointerCasts()); if (fn->empty()) { + CGM.SetLLVMFunctionAttributes(GlobalDecl(), FI, fn, /*IsThunk=*/false); fn->setDoesNotThrow(); fn->setDoesNotReturn(); Index: clang/test/CodeGenCXX/arm-generated-fn-attr.cpp =================================================================== --- /dev/null +++ clang/test/CodeGenCXX/arm-generated-fn-attr.cpp @@ -0,0 +1,36 @@ +// RUN: %clang_cc1 -triple thumbv8.1m.main-none-eabi -target-feature +pacbti -fcxx-exceptions -fexceptions -emit-llvm %s -o - | FileCheck %s --check-prefixes=CHECK,CHECK-PACBTI +// RUN: %clang_cc1 -triple thumbv8.1m.main-none-eabi -target-feature -pacbti -fcxx-exceptions -fexceptions -emit-llvm %s -o - | FileCheck %s --check-prefixes=CHECK,CHECK-NOPACBTI + +// Check that functions generated by clang have the correct attributes + +class Example { +public: + Example(); + int fn(); +}; + +// Initialization of var1 causes __cxx_global_var_init and __tls_init to be generated +thread_local Example var1; +extern thread_local Example var2; +extern void fn(); + +int testfn() noexcept { + // Calling fn in a noexcept function causes __clang_call_terminate to be generated + fn(); + // Use of var1 and var2 causes TLS wrapper functions to be generated + return var1.fn() + var2.fn(); +} + +// CHECK: define {{.*}} @__cxx_global_var_init() [[ATTR1:#[0-9]+]] +// CHECK: define {{.*}} @__clang_call_terminate({{.*}}) [[ATTR2:#[0-9]+]] +// CHECK: define {{.*}} @_ZTW4var1() [[ATTR3:#[0-9]+]] +// CHECK: define {{.*}} @_ZTW4var2() [[ATTR3]] +// CHECK: define {{.*}} @__tls_init() [[ATTR1]] + +// CHECK-PACBTI: attributes [[ATTR1]] = { {{.*}}"target-features"="+armv8.1-m.main,+pacbti,+thumb-mode"{{.*}} } +// CHECK-PACBTI: attributes [[ATTR2]] = { {{.*}}"target-features"="+armv8.1-m.main,+pacbti,+thumb-mode"{{.*}} } +// CHECK-PACBTI: attributes [[ATTR3]] = { {{.*}}"target-features"="+armv8.1-m.main,+pacbti,+thumb-mode"{{.*}} } + +// CHECK-NOPACBTI: attributes [[ATTR1]] = { {{.*}}"target-features"="+armv8.1-m.main,+thumb-mode,-pacbti"{{.*}} } +// CHECK-NOPACBTI: attributes [[ATTR2]] = { {{.*}}"target-features"="+armv8.1-m.main,+thumb-mode,-pacbti"{{.*}} } +// CHECK-NOPACBTI: attributes [[ATTR3]] = { {{.*}}"target-features"="+armv8.1-m.main,+thumb-mode,-pacbti"{{.*}} } Index: clang/test/CodeGenCXX/dllimport-runtime-fns.cpp =================================================================== --- clang/test/CodeGenCXX/dllimport-runtime-fns.cpp +++ clang/test/CodeGenCXX/dllimport-runtime-fns.cpp @@ -28,14 +28,14 @@ // MSVC: declare dso_local void @__std_terminate() // _ZSt9terminatev and __cxa_begin_catch should be marked dllimport. -// ITANIUM-LABEL: define linkonce_odr hidden void @__clang_call_terminate(ptr %0) +// ITANIUM-LABEL: define linkonce_odr hidden void @__clang_call_terminate(ptr noundef %0) // ITANIUM: call ptr @__cxa_begin_catch({{.*}}) // ITANIUM: call void @_ZSt9terminatev() // ITANIUM: declare dllimport ptr @__cxa_begin_catch(ptr) // ITANIUM: declare dllimport void @_ZSt9terminatev() // .. not for mingw. -// GNU-LABEL: define linkonce_odr hidden void @__clang_call_terminate(ptr %0) +// GNU-LABEL: define linkonce_odr hidden void @__clang_call_terminate(ptr noundef %0) // GNU: call ptr @__cxa_begin_catch({{.*}}) // GNU: call void @_ZSt9terminatev() // GNU: declare dso_local ptr @__cxa_begin_catch(ptr) Index: clang/test/CodeGenCXX/exceptions.cpp =================================================================== --- clang/test/CodeGenCXX/exceptions.cpp +++ clang/test/CodeGenCXX/exceptions.cpp @@ -633,4 +633,4 @@ } -// CHECK98: attributes [[NI_NR_NUW]] = { noinline noreturn nounwind } +// CHECK98: attributes [[NI_NR_NUW]] = { noinline noreturn nounwind {{.*}} } Index: clang/test/CodeGenCXX/runtime-dllstorage.cpp =================================================================== --- clang/test/CodeGenCXX/runtime-dllstorage.cpp +++ clang/test/CodeGenCXX/runtime-dllstorage.cpp @@ -116,7 +116,7 @@ // CHECK-IA-DAG: @_ZTH1t = dso_local alias void (), ptr @__tls_init // CHECK-IA-DAG: declare dso_local i32 @__gxx_personality_v0(...) -// CHECK-IA-DAG: define linkonce_odr hidden void @__clang_call_terminate(ptr %0) +// CHECK-IA-DAG: define linkonce_odr hidden void @__clang_call_terminate(ptr noundef %0) // CHECK-DYNAMIC-IA-DAG: declare dllimport i32 @__cxa_thread_atexit(ptr, ptr, ptr) // CHECK-DYNAMIC-IA-DAG: declare dllimport i32 @__cxa_atexit(ptr, ptr, ptr)