diff --git a/llvm/lib/Support/MemoryBuffer.cpp b/llvm/lib/Support/MemoryBuffer.cpp --- a/llvm/lib/Support/MemoryBuffer.cpp +++ b/llvm/lib/Support/MemoryBuffer.cpp @@ -58,12 +58,10 @@ // MemoryBufferMem implementation. //===----------------------------------------------------------------------===// -/// CopyStringRef - Copies contents of a StringRef into a block of memory and -/// null-terminates it. +/// CopyStringRef - Copies contents of a StringRef into a block of memory. static void CopyStringRef(char *Memory, StringRef Data) { if (!Data.empty()) memcpy(Memory, Data.data(), Data.size()); - Memory[Data.size()] = 0; // Null terminate string. } namespace { @@ -77,8 +75,10 @@ SmallString<256> NameBuf; StringRef NameRef = Alloc.Name.toStringRef(NameBuf); - char *Mem = static_cast(operator new(N + NameRef.size() + 1)); - CopyStringRef(Mem + N, NameRef); + char *Mem = + static_cast(operator new(N + sizeof(size_t) + NameRef.size())); + *reinterpret_cast(Mem + N) = NameRef.size(); + CopyStringRef(Mem + N + sizeof(size_t), NameRef); return Mem; } @@ -98,7 +98,8 @@ StringRef getBufferIdentifier() const override { // The name is stored after the class itself. - return StringRef(reinterpret_cast(this + 1)); + return StringRef(reinterpret_cast(this + 1) + sizeof(size_t), + *reinterpret_cast(this + 1)); } MemoryBuffer::BufferKind getBufferKind() const override { @@ -221,7 +222,8 @@ StringRef getBufferIdentifier() const override { // The name is stored after the class itself. - return StringRef(reinterpret_cast(this + 1)); + return StringRef(reinterpret_cast(this + 1) + sizeof(size_t), + *reinterpret_cast(this + 1)); } MemoryBuffer::BufferKind getBufferKind() const override { @@ -301,7 +303,8 @@ // that MemoryBuffer and data are aligned so PointerIntPair works with them. SmallString<256> NameBuf; StringRef NameRef = BufferName.toStringRef(NameBuf); - size_t StringLen = sizeof(MemBuffer) + NameRef.size() + 1; + + size_t StringLen = sizeof(MemBuffer) + sizeof(size_t) + NameRef.size(); size_t RealLen = StringLen + Size + 1 + BufAlign.value(); if (RealLen <= Size) // Check for rollover. return nullptr; @@ -310,13 +313,15 @@ return nullptr; // The name is stored after the class itself. - CopyStringRef(Mem + sizeof(MemBuffer), NameRef); + *reinterpret_cast(Mem + sizeof(MemBuffer)) = + NameRef.size(); // Null terminate buffer. + CopyStringRef(Mem + sizeof(MemBuffer) + sizeof(size_t), NameRef); // The buffer begins after the name and must be aligned. char *Buf = (char *)alignAddr(Mem + StringLen, BufAlign); - Buf[Size] = 0; // Null terminate buffer. auto *Ret = new (Mem) MemBuffer(StringRef(Buf, Size), true); + Buf[Size] = 0; // Null terminate buffer. return std::unique_ptr(Ret); }