Paths

Table of Contentst

Differential D138367

Revert "Revert "[libc++][ranges]Refactor `copy{,_backward}` and `move{,_backward}`""
AbandonedPublicDraft
Actions

Authored by var-const on Nov 19 2022, 4:18 PM.

Tags

Subscribers

Details

Reviewers

None

Group Reviewers

Restricted Project

Summary

This reverts commit a6e1080b87db8fbe0e1afadd96af5a3c0bd5e279.

Fix the conditions when the memmove optimization can be applied, fix and expand the tests.

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed
View All

	Time	Test
	3,030 ms	libcxx CI C++03 > llvm-libc++-shared-cfg-in.libcxx::clang_tidy.sh.cpp Script: -- : 'RUN: at line 15'; clang-tidy /home/libcxx-builder/.buildkite-agent/builds/2f3e9931c1ab-1/llvm-project/libcxx-ci/libcxx/test/libcxx/clang_tidy.sh.cpp --warnings-as-errors=* -header-filter=.* --config-file=/home/libcxx-builder/.buildkite-agent/builds/2f3e9931c1ab-1/llvm-project/libcxx-ci/libcxx/test/libcxx/../../.clang-tidy -- -Wweak-vtables -nostdinc++ -I /home/libcxx-builder/.buildkite-agent/builds/2f3e9931c1ab-1/llvm-project/libcxx-ci/build/generic-cxx03/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/2f3e9931c1ab-1/llvm-project/libcxx-ci/build/generic-cxx03/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/2f3e9931c1ab-1/llvm-project/libcxx-ci/libcxx/test/support -std=c++03 -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_ENABLE_EXPERIMENTAL -D_LIBCPP_DISABLE_AVAILABILITY -fcoroutines-ts -Werror=thread-safety -Wuser-defined-warnings -fno-modules
	3,030 ms	libcxx CI C++03 > llvm-libc++-shared-cfg-in.libcxx::clang_tidy.sh.cpp Script: -- : 'RUN: at line 15'; clang-tidy /home/libcxx-builder/.buildkite-agent/builds/2f3e9931c1ab-1/llvm-project/libcxx-ci/libcxx/test/libcxx/clang_tidy.sh.cpp --warnings-as-errors=* -header-filter=.* --config-file=/home/libcxx-builder/.buildkite-agent/builds/2f3e9931c1ab-1/llvm-project/libcxx-ci/libcxx/test/libcxx/../../.clang-tidy -- -Wweak-vtables -nostdinc++ -I /home/libcxx-builder/.buildkite-agent/builds/2f3e9931c1ab-1/llvm-project/libcxx-ci/build/generic-cxx03/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/2f3e9931c1ab-1/llvm-project/libcxx-ci/build/generic-cxx03/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/2f3e9931c1ab-1/llvm-project/libcxx-ci/libcxx/test/support -std=c++03 -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_ENABLE_EXPERIMENTAL -D_LIBCPP_DISABLE_AVAILABILITY -fcoroutines-ts -Werror=thread-safety -Wuser-defined-warnings -fno-modules
	3,030 ms	libcxx CI C++03 > llvm-libc++-shared-cfg-in.libcxx::clang_tidy.sh.cpp Script: -- : 'RUN: at line 15'; clang-tidy /home/libcxx-builder/.buildkite-agent/builds/2f3e9931c1ab-1/llvm-project/libcxx-ci/libcxx/test/libcxx/clang_tidy.sh.cpp --warnings-as-errors=* -header-filter=.* --config-file=/home/libcxx-builder/.buildkite-agent/builds/2f3e9931c1ab-1/llvm-project/libcxx-ci/libcxx/test/libcxx/../../.clang-tidy -- -Wweak-vtables -nostdinc++ -I /home/libcxx-builder/.buildkite-agent/builds/2f3e9931c1ab-1/llvm-project/libcxx-ci/build/generic-cxx03/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/2f3e9931c1ab-1/llvm-project/libcxx-ci/build/generic-cxx03/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/2f3e9931c1ab-1/llvm-project/libcxx-ci/libcxx/test/support -std=c++03 -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_ENABLE_EXPERIMENTAL -D_LIBCPP_DISABLE_AVAILABILITY -fcoroutines-ts -Werror=thread-safety -Wuser-defined-warnings -fno-modules
	3,030 ms	libcxx CI C++03 > llvm-libc++-shared-cfg-in.libcxx::clang_tidy.sh.cpp Script: -- : 'RUN: at line 15'; clang-tidy /home/libcxx-builder/.buildkite-agent/builds/2f3e9931c1ab-1/llvm-project/libcxx-ci/libcxx/test/libcxx/clang_tidy.sh.cpp --warnings-as-errors=* -header-filter=.* --config-file=/home/libcxx-builder/.buildkite-agent/builds/2f3e9931c1ab-1/llvm-project/libcxx-ci/libcxx/test/libcxx/../../.clang-tidy -- -Wweak-vtables -nostdinc++ -I /home/libcxx-builder/.buildkite-agent/builds/2f3e9931c1ab-1/llvm-project/libcxx-ci/build/generic-cxx03/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/2f3e9931c1ab-1/llvm-project/libcxx-ci/build/generic-cxx03/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/2f3e9931c1ab-1/llvm-project/libcxx-ci/libcxx/test/support -std=c++03 -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_ENABLE_EXPERIMENTAL -D_LIBCPP_DISABLE_AVAILABILITY -fcoroutines-ts -Werror=thread-safety -Wuser-defined-warnings -fno-modules
	3,030 ms	libcxx CI C++03 > llvm-libc++-shared-cfg-in.libcxx::clang_tidy.sh.cpp Script: -- : 'RUN: at line 15'; clang-tidy /home/libcxx-builder/.buildkite-agent/builds/2f3e9931c1ab-1/llvm-project/libcxx-ci/libcxx/test/libcxx/clang_tidy.sh.cpp --warnings-as-errors=* -header-filter=.* --config-file=/home/libcxx-builder/.buildkite-agent/builds/2f3e9931c1ab-1/llvm-project/libcxx-ci/libcxx/test/libcxx/../../.clang-tidy -- -Wweak-vtables -nostdinc++ -I /home/libcxx-builder/.buildkite-agent/builds/2f3e9931c1ab-1/llvm-project/libcxx-ci/build/generic-cxx03/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/2f3e9931c1ab-1/llvm-project/libcxx-ci/build/generic-cxx03/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/2f3e9931c1ab-1/llvm-project/libcxx-ci/libcxx/test/support -std=c++03 -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_ENABLE_EXPERIMENTAL -D_LIBCPP_DISABLE_AVAILABILITY -fcoroutines-ts -Werror=thread-safety -Wuser-defined-warnings -fno-modules
		View Full Test Results (17,550 Failed)

Event Timeline

var-const created this revision.Nov 19 2022, 4:18 PM

Herald added a project: Restricted Project. · View Herald TranscriptNov 19 2022, 4:18 PM

Harbormaster completed remote builds in B198646: Diff 476710.Nov 19 2022, 4:40 PM

var-const abandoned this revision.Mon, Jan 30, 12:31 AM

Herald added a project: Restricted Project. · View Herald TranscriptMon, Jan 30, 12:32 AM

Herald added a reviewer: Restricted Project. · View Herald Transcript

Herald added a subscriber: libcxx-commits. · View Herald Transcript

Revision Contents
Changeset List

Path

Size

libcxx/

include/

1 line

__algorithm/

96 lines

copy_backward.h

72 lines

copy_move_common.h

152 lines

112 lines

move_backward.h

87 lines

5 lines

ranges_copy_backward.h

1 line

ranges_copy_n.h

3 lines

1 line

ranges_move_backward.h

11 lines

ranges_set_difference.h

5 lines

ranges_set_symmetric_difference.h

5 lines

ranges_set_union.h

5 lines

2 lines

set_difference.h

10 lines

set_symmetric_difference.h

9 lines

9 lines

__iterator/

reverse_iterator.h

9 lines

2 lines

module.modulemap.in

1 line

1 line

test/

libcxx/

algorithms/

alg.modifying.operations/

copy_move_nontrivial.pass.cpp

265 lines

copy_move_trivial.pass.cpp

200 lines

private_headers.verify.cpp

1 line

std/

algorithms/

alg.modifying.operations/

alg.copy/

ranges.copy.pass.cpp

2 lines

ranges.copy_backward.pass.cpp

2 lines

alg.move/

ranges.move.pass.cpp

2 lines

ranges.move_backward.pass.cpp

16 lines

Diff 476710

libcxx/include/CMakeLists.txt

Loading...

libcxx/include/__algorithm/copy.h

Loading...

libcxx/include/__algorithm/copy_backward.h

Loading...

libcxx/include/__algorithm/copy_move_common.h

Loading...

libcxx/include/__algorithm/move.h

Loading...

libcxx/include/__algorithm/move_backward.h

Loading...

libcxx/include/__algorithm/ranges_copy.h

Loading...

libcxx/include/__algorithm/ranges_copy_backward.h

Loading...

libcxx/include/__algorithm/ranges_copy_n.h

Loading...

libcxx/include/__algorithm/ranges_move.h

Loading...

libcxx/include/__algorithm/ranges_move_backward.h

Loading...

libcxx/include/__algorithm/ranges_set_difference.h

Loading...

libcxx/include/__algorithm/ranges_set_symmetric_difference.h

Loading...

libcxx/include/__algorithm/ranges_set_union.h

Loading...

libcxx/include/__algorithm/rotate.h

Loading...

libcxx/include/__algorithm/set_difference.h

Loading...

libcxx/include/__algorithm/set_symmetric_difference.h

Loading...

libcxx/include/__algorithm/set_union.h

Loading...

libcxx/include/__iterator/reverse_iterator.h

Loading...

libcxx/include/algorithm

Loading...

libcxx/include/module.modulemap.in

Loading...

libcxx/include/valarray

Loading...

libcxx/test/libcxx/algorithms/alg.modifying.operations/copy.pass.cpp

Loading...

libcxx/test/libcxx/algorithms/alg.modifying.operations/copy_move_nontrivial.pass.cpp

Loading...

libcxx/test/libcxx/algorithms/alg.modifying.operations/copy_move_trivial.pass.cpp

Loading...

libcxx/test/libcxx/private_headers.verify.cpp

Loading...

libcxx/test/std/algorithms/alg.modifying.operations/alg.copy/ranges.copy.pass.cpp

Loading...

libcxx/test/std/algorithms/alg.modifying.operations/alg.copy/ranges.copy_backward.pass.cpp

Loading...

libcxx/test/std/algorithms/alg.modifying.operations/alg.move/ranges.move.pass.cpp

Loading...

libcxx/test/std/algorithms/alg.modifying.operations/alg.move/ranges.move_backward.pass.cpp

Loading...