Page MenuHomePhabricator

Revert "Revert "[libc++][ranges]Refactor `copy{,_backward}` and `move{,_backward}`""
AbandonedPublicDraft

Authored by var-const on Nov 19 2022, 4:18 PM.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

This reverts commit a6e1080b87db8fbe0e1afadd96af5a3c0bd5e279.

Fix the conditions when the memmove optimization can be applied, fix and expand the tests.

Diff Detail

Unit TestsFailed

TimeTest
3,030 mslibcxx CI C++03 > llvm-libc++-shared-cfg-in.libcxx::clang_tidy.sh.cpp
Script: -- : 'RUN: at line 15'; clang-tidy /home/libcxx-builder/.buildkite-agent/builds/2f3e9931c1ab-1/llvm-project/libcxx-ci/libcxx/test/libcxx/clang_tidy.sh.cpp --warnings-as-errors=* -header-filter=.* --config-file=/home/libcxx-builder/.buildkite-agent/builds/2f3e9931c1ab-1/llvm-project/libcxx-ci/libcxx/test/libcxx/../../.clang-tidy -- -Wweak-vtables -nostdinc++ -I /home/libcxx-builder/.buildkite-agent/builds/2f3e9931c1ab-1/llvm-project/libcxx-ci/build/generic-cxx03/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/2f3e9931c1ab-1/llvm-project/libcxx-ci/build/generic-cxx03/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/2f3e9931c1ab-1/llvm-project/libcxx-ci/libcxx/test/support -std=c++03 -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_ENABLE_EXPERIMENTAL -D_LIBCPP_DISABLE_AVAILABILITY -fcoroutines-ts -Werror=thread-safety -Wuser-defined-warnings -fno-modules
3,030 mslibcxx CI C++03 > llvm-libc++-shared-cfg-in.libcxx::clang_tidy.sh.cpp
Script: -- : 'RUN: at line 15'; clang-tidy /home/libcxx-builder/.buildkite-agent/builds/2f3e9931c1ab-1/llvm-project/libcxx-ci/libcxx/test/libcxx/clang_tidy.sh.cpp --warnings-as-errors=* -header-filter=.* --config-file=/home/libcxx-builder/.buildkite-agent/builds/2f3e9931c1ab-1/llvm-project/libcxx-ci/libcxx/test/libcxx/../../.clang-tidy -- -Wweak-vtables -nostdinc++ -I /home/libcxx-builder/.buildkite-agent/builds/2f3e9931c1ab-1/llvm-project/libcxx-ci/build/generic-cxx03/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/2f3e9931c1ab-1/llvm-project/libcxx-ci/build/generic-cxx03/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/2f3e9931c1ab-1/llvm-project/libcxx-ci/libcxx/test/support -std=c++03 -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_ENABLE_EXPERIMENTAL -D_LIBCPP_DISABLE_AVAILABILITY -fcoroutines-ts -Werror=thread-safety -Wuser-defined-warnings -fno-modules
3,030 mslibcxx CI C++03 > llvm-libc++-shared-cfg-in.libcxx::clang_tidy.sh.cpp
Script: -- : 'RUN: at line 15'; clang-tidy /home/libcxx-builder/.buildkite-agent/builds/2f3e9931c1ab-1/llvm-project/libcxx-ci/libcxx/test/libcxx/clang_tidy.sh.cpp --warnings-as-errors=* -header-filter=.* --config-file=/home/libcxx-builder/.buildkite-agent/builds/2f3e9931c1ab-1/llvm-project/libcxx-ci/libcxx/test/libcxx/../../.clang-tidy -- -Wweak-vtables -nostdinc++ -I /home/libcxx-builder/.buildkite-agent/builds/2f3e9931c1ab-1/llvm-project/libcxx-ci/build/generic-cxx03/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/2f3e9931c1ab-1/llvm-project/libcxx-ci/build/generic-cxx03/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/2f3e9931c1ab-1/llvm-project/libcxx-ci/libcxx/test/support -std=c++03 -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_ENABLE_EXPERIMENTAL -D_LIBCPP_DISABLE_AVAILABILITY -fcoroutines-ts -Werror=thread-safety -Wuser-defined-warnings -fno-modules
3,030 mslibcxx CI C++03 > llvm-libc++-shared-cfg-in.libcxx::clang_tidy.sh.cpp
Script: -- : 'RUN: at line 15'; clang-tidy /home/libcxx-builder/.buildkite-agent/builds/2f3e9931c1ab-1/llvm-project/libcxx-ci/libcxx/test/libcxx/clang_tidy.sh.cpp --warnings-as-errors=* -header-filter=.* --config-file=/home/libcxx-builder/.buildkite-agent/builds/2f3e9931c1ab-1/llvm-project/libcxx-ci/libcxx/test/libcxx/../../.clang-tidy -- -Wweak-vtables -nostdinc++ -I /home/libcxx-builder/.buildkite-agent/builds/2f3e9931c1ab-1/llvm-project/libcxx-ci/build/generic-cxx03/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/2f3e9931c1ab-1/llvm-project/libcxx-ci/build/generic-cxx03/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/2f3e9931c1ab-1/llvm-project/libcxx-ci/libcxx/test/support -std=c++03 -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_ENABLE_EXPERIMENTAL -D_LIBCPP_DISABLE_AVAILABILITY -fcoroutines-ts -Werror=thread-safety -Wuser-defined-warnings -fno-modules
3,030 mslibcxx CI C++03 > llvm-libc++-shared-cfg-in.libcxx::clang_tidy.sh.cpp
Script: -- : 'RUN: at line 15'; clang-tidy /home/libcxx-builder/.buildkite-agent/builds/2f3e9931c1ab-1/llvm-project/libcxx-ci/libcxx/test/libcxx/clang_tidy.sh.cpp --warnings-as-errors=* -header-filter=.* --config-file=/home/libcxx-builder/.buildkite-agent/builds/2f3e9931c1ab-1/llvm-project/libcxx-ci/libcxx/test/libcxx/../../.clang-tidy -- -Wweak-vtables -nostdinc++ -I /home/libcxx-builder/.buildkite-agent/builds/2f3e9931c1ab-1/llvm-project/libcxx-ci/build/generic-cxx03/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/2f3e9931c1ab-1/llvm-project/libcxx-ci/build/generic-cxx03/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/2f3e9931c1ab-1/llvm-project/libcxx-ci/libcxx/test/support -std=c++03 -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_ENABLE_EXPERIMENTAL -D_LIBCPP_DISABLE_AVAILABILITY -fcoroutines-ts -Werror=thread-safety -Wuser-defined-warnings -fno-modules
View Full Test Results (17,550 Failed)

Event Timeline

var-const created this revision.Nov 19 2022, 4:18 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 19 2022, 4:18 PM
var-const abandoned this revision.Mon, Jan 30, 12:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptMon, Jan 30, 12:32 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript