Index: llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp =================================================================== --- llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp +++ llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp @@ -2452,7 +2452,7 @@ B.buildCopy(DstRegs[0], SrcRegs[0]); } else { // Extend in the low bits and propagate the sign bit to the high half. - B.buildSExtInReg(DstRegs[0], SrcRegs[0], Amt); + B.buildSExtInReg(DstRegs[0], SrcRegs[0], 64 - (32 + Amt)); } B.buildAShr(DstRegs[1], DstRegs[0], B.buildConstant(S32, 31)); Index: llvm/test/CodeGen/AMDGPU/GlobalISel/ashr.ll =================================================================== --- llvm/test/CodeGen/AMDGPU/GlobalISel/ashr.ll +++ llvm/test/CodeGen/AMDGPU/GlobalISel/ashr.ll @@ -1690,7 +1690,7 @@ ; GFX6-LABEL: v_ashr_i65: ; GFX6: ; %bb.0: ; GFX6-NEXT: s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0) -; GFX6-NEXT: v_bfe_i32 v4, v2, 0, 1 +; GFX6-NEXT: v_bfe_i32 v4, v2, 0, 31 ; GFX6-NEXT: v_ashrrev_i32_e32 v5, 31, v4 ; GFX6-NEXT: v_sub_i32_e32 v8, vcc, 64, v3 ; GFX6-NEXT: v_lshr_b64 v[6:7], v[0:1], v3 @@ -1713,7 +1713,7 @@ ; GFX8-LABEL: v_ashr_i65: ; GFX8: ; %bb.0: ; GFX8-NEXT: s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0) -; GFX8-NEXT: v_bfe_i32 v4, v2, 0, 1 +; GFX8-NEXT: v_bfe_i32 v4, v2, 0, 31 ; GFX8-NEXT: v_ashrrev_i32_e32 v5, 31, v4 ; GFX8-NEXT: v_sub_u32_e32 v8, vcc, 64, v3 ; GFX8-NEXT: v_lshrrev_b64 v[6:7], v3, v[0:1] @@ -1736,7 +1736,7 @@ ; GFX9-LABEL: v_ashr_i65: ; GFX9: ; %bb.0: ; GFX9-NEXT: s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0) -; GFX9-NEXT: v_bfe_i32 v4, v2, 0, 1 +; GFX9-NEXT: v_bfe_i32 v4, v2, 0, 31 ; GFX9-NEXT: v_ashrrev_i32_e32 v5, 31, v4 ; GFX9-NEXT: v_sub_u32_e32 v8, 64, v3 ; GFX9-NEXT: v_lshrrev_b64 v[6:7], v3, v[0:1] @@ -1760,7 +1760,7 @@ ; GFX10: ; %bb.0: ; GFX10-NEXT: s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0) ; GFX10-NEXT: s_waitcnt_vscnt null, 0x0 -; GFX10-NEXT: v_bfe_i32 v4, v2, 0, 1 +; GFX10-NEXT: v_bfe_i32 v4, v2, 0, 31 ; GFX10-NEXT: v_sub_nc_u32_e32 v2, 64, v3 ; GFX10-NEXT: v_subrev_nc_u32_e32 v10, 64, v3 ; GFX10-NEXT: v_lshrrev_b64 v[6:7], v3, v[0:1] @@ -1784,7 +1784,7 @@ ; GFX11: ; %bb.0: ; GFX11-NEXT: s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0) ; GFX11-NEXT: s_waitcnt_vscnt null, 0x0 -; GFX11-NEXT: v_bfe_i32 v4, v2, 0, 1 +; GFX11-NEXT: v_bfe_i32 v4, v2, 0, 31 ; GFX11-NEXT: v_sub_nc_u32_e32 v2, 64, v3 ; GFX11-NEXT: v_subrev_nc_u32_e32 v10, 64, v3 ; GFX11-NEXT: v_lshrrev_b64 v[6:7], v3, v[0:1] @@ -1812,7 +1812,7 @@ ; GFX6: ; %bb.0: ; GFX6-NEXT: s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0) ; GFX6-NEXT: v_mov_b32_e32 v3, v1 -; GFX6-NEXT: v_bfe_i32 v1, v2, 0, 1 +; GFX6-NEXT: v_bfe_i32 v1, v2, 0, 31 ; GFX6-NEXT: v_ashrrev_i32_e32 v2, 31, v1 ; GFX6-NEXT: v_lshl_b64 v[0:1], v[1:2], 31 ; GFX6-NEXT: v_lshrrev_b32_e32 v3, 1, v3 @@ -1824,7 +1824,7 @@ ; GFX8: ; %bb.0: ; GFX8-NEXT: s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0) ; GFX8-NEXT: v_mov_b32_e32 v3, v1 -; GFX8-NEXT: v_bfe_i32 v1, v2, 0, 1 +; GFX8-NEXT: v_bfe_i32 v1, v2, 0, 31 ; GFX8-NEXT: v_ashrrev_i32_e32 v2, 31, v1 ; GFX8-NEXT: v_lshlrev_b64 v[0:1], 31, v[1:2] ; GFX8-NEXT: v_lshrrev_b32_e32 v3, 1, v3 @@ -1836,7 +1836,7 @@ ; GFX9: ; %bb.0: ; GFX9-NEXT: s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0) ; GFX9-NEXT: v_mov_b32_e32 v3, v1 -; GFX9-NEXT: v_bfe_i32 v1, v2, 0, 1 +; GFX9-NEXT: v_bfe_i32 v1, v2, 0, 31 ; GFX9-NEXT: v_ashrrev_i32_e32 v2, 31, v1 ; GFX9-NEXT: v_lshlrev_b64 v[0:1], 31, v[1:2] ; GFX9-NEXT: v_lshrrev_b32_e32 v3, 1, v3 @@ -1849,7 +1849,7 @@ ; GFX10PLUS-NEXT: s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0) ; GFX10PLUS-NEXT: s_waitcnt_vscnt null, 0x0 ; GFX10PLUS-NEXT: v_mov_b32_e32 v3, v1 -; GFX10PLUS-NEXT: v_bfe_i32 v1, v2, 0, 1 +; GFX10PLUS-NEXT: v_bfe_i32 v1, v2, 0, 31 ; GFX10PLUS-NEXT: v_lshrrev_b32_e32 v3, 1, v3 ; GFX10PLUS-NEXT: v_ashrrev_i32_e32 v2, 31, v1 ; GFX10PLUS-NEXT: v_lshlrev_b64 v[0:1], 31, v[1:2] Index: llvm/test/CodeGen/AMDGPU/GlobalISel/sext_inreg.ll =================================================================== --- llvm/test/CodeGen/AMDGPU/GlobalISel/sext_inreg.ll +++ llvm/test/CodeGen/AMDGPU/GlobalISel/sext_inreg.ll @@ -1170,7 +1170,7 @@ ; GCN-LABEL: v_sext_inreg_i64_40: ; GCN: ; %bb.0: ; GCN-NEXT: s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0) -; GCN-NEXT: v_bfe_i32 v0, v0, 0, 24 +; GCN-NEXT: v_bfe_i32 v0, v0, 0, 8 ; GCN-NEXT: v_ashrrev_i32_e32 v1, 31, v0 ; GCN-NEXT: s_setpc_b64 s[30:31] ; @@ -1178,7 +1178,7 @@ ; GFX10PLUS: ; %bb.0: ; GFX10PLUS-NEXT: s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0) ; GFX10PLUS-NEXT: s_waitcnt_vscnt null, 0x0 -; GFX10PLUS-NEXT: v_bfe_i32 v0, v0, 0, 24 +; GFX10PLUS-NEXT: v_bfe_i32 v0, v0, 0, 8 ; GFX10PLUS-NEXT: v_ashrrev_i32_e32 v1, 31, v0 ; GFX10PLUS-NEXT: s_setpc_b64 s[30:31] %shl = shl i64 %value, 40 @@ -1190,7 +1190,7 @@ ; GCN-LABEL: v_sext_inreg_i64_63: ; GCN: ; %bb.0: ; GCN-NEXT: s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0) -; GCN-NEXT: v_bfe_i32 v0, v0, 0, 1 +; GCN-NEXT: v_bfe_i32 v0, v0, 0, 31 ; GCN-NEXT: v_ashrrev_i32_e32 v1, 31, v0 ; GCN-NEXT: s_setpc_b64 s[30:31] ; @@ -1198,7 +1198,7 @@ ; GFX10PLUS: ; %bb.0: ; GFX10PLUS-NEXT: s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0) ; GFX10PLUS-NEXT: s_waitcnt_vscnt null, 0x0 -; GFX10PLUS-NEXT: v_bfe_i32 v0, v0, 0, 1 +; GFX10PLUS-NEXT: v_bfe_i32 v0, v0, 0, 31 ; GFX10PLUS-NEXT: v_ashrrev_i32_e32 v1, 31, v0 ; GFX10PLUS-NEXT: s_setpc_b64 s[30:31] %shl = shl i64 %value, 63 @@ -1210,7 +1210,7 @@ ; GCN-LABEL: v_sext_inreg_i64_33: ; GCN: ; %bb.0: ; GCN-NEXT: s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0) -; GCN-NEXT: v_bfe_i32 v0, v0, 0, 31 +; GCN-NEXT: v_bfe_i32 v0, v0, 0, 1 ; GCN-NEXT: v_ashrrev_i32_e32 v1, 31, v0 ; GCN-NEXT: s_setpc_b64 s[30:31] ; @@ -1218,7 +1218,7 @@ ; GFX10PLUS: ; %bb.0: ; GFX10PLUS-NEXT: s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0) ; GFX10PLUS-NEXT: s_waitcnt_vscnt null, 0x0 -; GFX10PLUS-NEXT: v_bfe_i32 v0, v0, 0, 31 +; GFX10PLUS-NEXT: v_bfe_i32 v0, v0, 0, 1 ; GFX10PLUS-NEXT: v_ashrrev_i32_e32 v1, 31, v0 ; GFX10PLUS-NEXT: s_setpc_b64 s[30:31] %shl = shl i64 %value, 33 @@ -1405,7 +1405,7 @@ ; GFX6-NEXT: v_lshl_b64 v[2:3], v[2:3], 22 ; GFX6-NEXT: v_lshrrev_b32_e32 v3, 10, v1 ; GFX6-NEXT: v_or_b32_e32 v2, v2, v3 -; GFX6-NEXT: v_bfe_i32 v2, v2, 0, 1 +; GFX6-NEXT: v_bfe_i32 v2, v2, 0, 31 ; GFX6-NEXT: v_lshr_b64 v[0:1], v[0:1], 0 ; GFX6-NEXT: v_ashrrev_i32_e32 v3, 31, v2 ; GFX6-NEXT: v_bfe_u32 v1, v1, 0, 10 @@ -1420,7 +1420,7 @@ ; GFX8-NEXT: v_lshlrev_b64 v[2:3], 22, v[2:3] ; GFX8-NEXT: v_lshrrev_b32_e32 v3, 10, v1 ; GFX8-NEXT: v_or_b32_e32 v2, v2, v3 -; GFX8-NEXT: v_bfe_i32 v2, v2, 0, 1 +; GFX8-NEXT: v_bfe_i32 v2, v2, 0, 31 ; GFX8-NEXT: v_lshrrev_b64 v[0:1], 0, v[0:1] ; GFX8-NEXT: v_ashrrev_i32_e32 v3, 31, v2 ; GFX8-NEXT: v_bfe_u32 v1, v1, 0, 10 @@ -1435,7 +1435,7 @@ ; GFX9-NEXT: v_lshlrev_b64 v[2:3], 22, v[2:3] ; GFX9-NEXT: v_lshrrev_b32_e32 v3, 10, v1 ; GFX9-NEXT: v_or_b32_e32 v2, v2, v3 -; GFX9-NEXT: v_bfe_i32 v2, v2, 0, 1 +; GFX9-NEXT: v_bfe_i32 v2, v2, 0, 31 ; GFX9-NEXT: v_lshrrev_b64 v[0:1], 0, v[0:1] ; GFX9-NEXT: v_ashrrev_i32_e32 v3, 31, v2 ; GFX9-NEXT: v_bfe_u32 v1, v1, 0, 10 @@ -1453,7 +1453,7 @@ ; GFX10PLUS-NEXT: v_lshrrev_b64 v[0:1], 0, v[0:1] ; GFX10PLUS-NEXT: v_or_b32_e32 v2, v2, v3 ; GFX10PLUS-NEXT: v_bfe_u32 v1, v1, 0, 10 -; GFX10PLUS-NEXT: v_bfe_i32 v2, v2, 0, 1 +; GFX10PLUS-NEXT: v_bfe_i32 v2, v2, 0, 31 ; GFX10PLUS-NEXT: v_ashrrev_i32_e32 v3, 31, v2 ; GFX10PLUS-NEXT: v_lshlrev_b32_e32 v4, 10, v2 ; GFX10PLUS-NEXT: v_ashrrev_i64 v[2:3], 22, v[2:3] @@ -1469,7 +1469,7 @@ ; GFX6: ; %bb.0: ; GFX6-NEXT: s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0) ; GFX6-NEXT: v_mov_b32_e32 v3, v1 -; GFX6-NEXT: v_bfe_i32 v1, v2, 0, 1 +; GFX6-NEXT: v_bfe_i32 v1, v2, 0, 31 ; GFX6-NEXT: v_ashrrev_i32_e32 v2, 31, v1 ; GFX6-NEXT: v_lshl_b64 v[0:1], v[1:2], 31 ; GFX6-NEXT: v_lshrrev_b32_e32 v3, 1, v3 @@ -1481,7 +1481,7 @@ ; GFX8: ; %bb.0: ; GFX8-NEXT: s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0) ; GFX8-NEXT: v_mov_b32_e32 v3, v1 -; GFX8-NEXT: v_bfe_i32 v1, v2, 0, 1 +; GFX8-NEXT: v_bfe_i32 v1, v2, 0, 31 ; GFX8-NEXT: v_ashrrev_i32_e32 v2, 31, v1 ; GFX8-NEXT: v_lshlrev_b64 v[0:1], 31, v[1:2] ; GFX8-NEXT: v_lshrrev_b32_e32 v3, 1, v3 @@ -1493,7 +1493,7 @@ ; GFX9: ; %bb.0: ; GFX9-NEXT: s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0) ; GFX9-NEXT: v_mov_b32_e32 v3, v1 -; GFX9-NEXT: v_bfe_i32 v1, v2, 0, 1 +; GFX9-NEXT: v_bfe_i32 v1, v2, 0, 31 ; GFX9-NEXT: v_ashrrev_i32_e32 v2, 31, v1 ; GFX9-NEXT: v_lshlrev_b64 v[0:1], 31, v[1:2] ; GFX9-NEXT: v_lshrrev_b32_e32 v3, 1, v3 @@ -1506,7 +1506,7 @@ ; GFX10PLUS-NEXT: s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0) ; GFX10PLUS-NEXT: s_waitcnt_vscnt null, 0x0 ; GFX10PLUS-NEXT: v_mov_b32_e32 v3, v1 -; GFX10PLUS-NEXT: v_bfe_i32 v1, v2, 0, 1 +; GFX10PLUS-NEXT: v_bfe_i32 v1, v2, 0, 31 ; GFX10PLUS-NEXT: v_lshrrev_b32_e32 v3, 1, v3 ; GFX10PLUS-NEXT: v_ashrrev_i32_e32 v2, 31, v1 ; GFX10PLUS-NEXT: v_lshlrev_b64 v[0:1], 31, v[1:2]