Index: clang-tidy/cppcoreguidelines/CMakeLists.txt =================================================================== --- clang-tidy/cppcoreguidelines/CMakeLists.txt +++ clang-tidy/cppcoreguidelines/CMakeLists.txt @@ -6,6 +6,7 @@ ProTypeConstCastCheck.cpp ProTypeReinterpretCastCheck.cpp ProTypeStaticCastDowncastCheck.cpp + ProTypeVarargUseCheck.cpp LINK_LIBS clangAST Index: clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp =================================================================== --- clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp +++ clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp @@ -15,6 +15,7 @@ #include "ProTypeConstCastCheck.h" #include "ProTypeReinterpretCastCheck.h" #include "ProTypeStaticCastDowncastCheck.h" +#include "ProTypeVarargUseCheck.h" namespace clang { namespace tidy { @@ -32,6 +33,8 @@ "cppcoreguidelines-pro-type-reinterpret-cast"); CheckFactories.registerCheck( "cppcoreguidelines-pro-type-static-cast-downcast"); + CheckFactories.registerCheck( + "cppcoreguidelines-pro-type-vararg-use"); CheckFactories.registerCheck( "cppcoreguidelines-c-copy-assignment-signature"); } Index: clang-tidy/cppcoreguidelines/ProTypeVarargUseCheck.h =================================================================== --- /dev/null +++ clang-tidy/cppcoreguidelines/ProTypeVarargUseCheck.h @@ -0,0 +1,34 @@ +//===--- ProTypeVarargUseCheck.h - clang-tidy--------------------*- C++ -*-===// +// +// The LLVM Compiler Infrastructure +// +// This file is distributed under the University of Illinois Open Source +// License. See LICENSE.TXT for details. +// +//===----------------------------------------------------------------------===// + +#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_CPPCOREGUIDELINES_PRO_TYPE_VARARG_USE_H +#define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_CPPCOREGUIDELINES_PRO_TYPE_VARARG_USE_H + +#include "../ClangTidy.h" + +namespace clang { +namespace tidy { + +/// This check flags all calls to c-style variadic functions +/// +/// For the user-facing documentation see: +/// http://clang.llvm.org/extra/clang-tidy/checks/cppcoreguidelines-pro-type-vararg-use.html +class ProTypeVarargUseCheck : public ClangTidyCheck { +public: + ProTypeVarargUseCheck(StringRef Name, ClangTidyContext *Context) + : ClangTidyCheck(Name, Context) {} + void registerMatchers(ast_matchers::MatchFinder *Finder) override; + void check(const ast_matchers::MatchFinder::MatchResult &Result) override; +}; + +} // namespace tidy +} // namespace clang + +#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_CPPCOREGUIDELINES_PRO_TYPE_VARARG_USE_H + Index: clang-tidy/cppcoreguidelines/ProTypeVarargUseCheck.cpp =================================================================== --- /dev/null +++ clang-tidy/cppcoreguidelines/ProTypeVarargUseCheck.cpp @@ -0,0 +1,30 @@ +//===--- ProTypeVarargUseCheck.cpp - clang-tidy----------------------------===// +// +// The LLVM Compiler Infrastructure +// +// This file is distributed under the University of Illinois Open Source +// License. See LICENSE.TXT for details. +// +//===----------------------------------------------------------------------===// + +#include "ProTypeVarargUseCheck.h" +#include "clang/AST/ASTContext.h" +#include "clang/ASTMatchers/ASTMatchFinder.h" + +using namespace clang::ast_matchers; + +namespace clang { +namespace tidy { + +void ProTypeVarargUseCheck::registerMatchers(MatchFinder *Finder) { + Finder->addMatcher(callExpr(callee(functionDecl(isVariadic()))).bind("expr"), this); +} + +void ProTypeVarargUseCheck::check(const MatchFinder::MatchResult &Result) { + const auto *Matched = Result.Nodes.getNodeAs("expr"); + diag(Matched->getExprLoc(),"do not call c-style vararg functions"); +} + +} // namespace tidy +} // namespace clang + Index: docs/clang-tidy/checks/cppcoreguidelines-pro-type-vararg-use.rst =================================================================== --- /dev/null +++ docs/clang-tidy/checks/cppcoreguidelines-pro-type-vararg-use.rst @@ -0,0 +1,9 @@ +cppcoreguidelines-pro-type-vararg-use +===================================== + +This check flags all calls to c-style vararg functions. + +Passing to varargs assumes the correct type will be read. This is fragile because it cannot generally be enforced to be safe in the language and so relies on programmer discipline to get it right. + +This rule is part of the "Type safety" profile of the C++ Core Guidelines, see +https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#-type8-avoid-reading-from-varargs-or-passing-vararg-arguments-prefer-variadic-template-parameters-instead Index: docs/clang-tidy/checks/list.rst =================================================================== --- docs/clang-tidy/checks/list.rst +++ docs/clang-tidy/checks/list.rst @@ -8,6 +8,7 @@ cppcoreguidelines-pro-type-const-cast cppcoreguidelines-pro-type-reinterpret-cast cppcoreguidelines-pro-type-static-cast-downcast + cppcoreguidelines-pro-type-vararg-use google-build-explicit-make-pair google-build-namespaces google-build-using-namespace Index: test/clang-tidy/cppcoreguidelines-pro-type-vararg-use.cpp =================================================================== --- /dev/null +++ test/clang-tidy/cppcoreguidelines-pro-type-vararg-use.cpp @@ -0,0 +1,23 @@ +// RUN: %python %S/check_clang_tidy.py %s cppcoreguidelines-pro-type-vararg-use %t + +void f(int i); +void f_vararg(int i, ...); + +struct C { + void g_vararg(...); + void g(const char*); +} c; + +template +void cpp_vararg(P... p); + +void check() { + f_vararg(1, 7, 9); + // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: do not call c-style vararg functions [cppcoreguidelines-pro-type-vararg-use] + c.g_vararg("foo"); + // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: do not call c-style vararg functions + + f(3); // OK + c.g("foo"); // OK + cpp_vararg(1, 7, 9); // OK +}