diff --git a/flang/include/flang/Optimizer/Dialect/FIROps.td b/flang/include/flang/Optimizer/Dialect/FIROps.td --- a/flang/include/flang/Optimizer/Dialect/FIROps.td +++ b/flang/include/flang/Optimizer/Dialect/FIROps.td @@ -2872,7 +2872,7 @@ } def fir_DeclareOp : fir_Op<"declare", [AttrSizedOperandSegments, - DeclareOpInterfaceMethods]> { + DeclareOpInterfaceMethods]> { let summary = "declare a variable"; let description = [{ diff --git a/flang/include/flang/Optimizer/Dialect/FortranVariableInterface.h b/flang/include/flang/Optimizer/Dialect/FortranVariableInterface.h --- a/flang/include/flang/Optimizer/Dialect/FortranVariableInterface.h +++ b/flang/include/flang/Optimizer/Dialect/FortranVariableInterface.h @@ -19,8 +19,6 @@ #include "mlir/IR/BuiltinTypes.h" #include "mlir/IR/OpDefinition.h" -namespace fir { #include "flang/Optimizer/Dialect/FortranVariableInterface.h.inc" -} // namespace fir #endif // FORTRAN_OPTIMIZER_DIALECT_FORTRANVARIABLEINTERFACE_H diff --git a/flang/include/flang/Optimizer/Dialect/FortranVariableInterface.td b/flang/include/flang/Optimizer/Dialect/FortranVariableInterface.td --- a/flang/include/flang/Optimizer/Dialect/FortranVariableInterface.td +++ b/flang/include/flang/Optimizer/Dialect/FortranVariableInterface.td @@ -16,7 +16,7 @@ include "mlir/IR/OpBase.td" -def FortranVariableOpInterface : OpInterface<"FortranVariableOpInterface"> { +def fir_FortranVariableOpInterface : OpInterface<"FortranVariableOpInterface"> { let description = [{ Interface for operations that create Fortran like variables in order to query about all their Fortran properties. @@ -151,6 +151,8 @@ }]; + let cppNamespace = "fir"; + let verify = [{ return ::mlir::cast<::fir::FortranVariableOpInterface>($_op).verifyImpl(); }]; diff --git a/flang/lib/Optimizer/Dialect/FortranVariableInterface.cpp b/flang/lib/Optimizer/Dialect/FortranVariableInterface.cpp --- a/flang/lib/Optimizer/Dialect/FortranVariableInterface.cpp +++ b/flang/lib/Optimizer/Dialect/FortranVariableInterface.cpp @@ -12,9 +12,7 @@ #include "flang/Optimizer/Dialect/FortranVariableInterface.h" -namespace fir { #include "flang/Optimizer/Dialect/FortranVariableInterface.cpp.inc" -} mlir::LogicalResult fir::FortranVariableOpInterface::verifyImpl() { const unsigned numExplicitTypeParams = getExplicitTypeParams().size();