diff --git a/clang/lib/Parse/ParseExprCXX.cpp b/clang/lib/Parse/ParseExprCXX.cpp --- a/clang/lib/Parse/ParseExprCXX.cpp +++ b/clang/lib/Parse/ParseExprCXX.cpp @@ -1291,7 +1291,23 @@ if (getLangOpts().CUDA) { // In CUDA code, GNU attributes are allowed to appear immediately after the // "[...]", even if there is no "(...)" before the lambda body. - MaybeParseGNUAttributes(D); + // + // Note that we support __noinline__ as a keyword in this mode and thus + // it has to be separately handled. + while (true) { + if (Tok.is(tok::kw___attribute)) { + ParseGNUAttributes(Attr, nullptr, &D); + } else if (Tok.is(tok::kw___noinline__)) { + IdentifierInfo *AttrName = Tok.getIdentifierInfo(); + SourceLocation AttrNameLoc = ConsumeToken(); + Attr.addNew(AttrName, AttrNameLoc, nullptr, AttrNameLoc, nullptr, 0, + ParsedAttr::AS_Keyword); + } else { + break; + } + } + + D.takeAttributes(Attr); } // Helper to emit a warning if we see a CUDA host/device/global attribute diff --git a/clang/test/Parser/lambda-attr.cu b/clang/test/Parser/lambda-attr.cu --- a/clang/test/Parser/lambda-attr.cu +++ b/clang/test/Parser/lambda-attr.cu @@ -18,6 +18,10 @@ ([&](int) __attribute__((device)){ device_fn(); })(0); // expected-warning@-1 {{nvcc does not allow '__device__' to appear after the parameter list in lambdas}} ([&] __attribute__((device)) (int) { device_fn(); })(0); + + // test that noinline can appear anywhere. + ([&] __attribute__((device)) __noinline__ () { device_fn(); })(); + ([&] __noinline__ __attribute__((device)) () { device_fn(); })(); } __attribute__((host)) __attribute__((device)) void host_device_attrs() { @@ -37,6 +41,11 @@ // expected-warning@-1 {{nvcc does not allow '__host__' to appear after the parameter list in lambdas}} // expected-warning@-2 {{nvcc does not allow '__device__' to appear after the parameter list in lambdas}} ([&] __attribute__((host)) __attribute__((device)) (int) { hd_fn(); })(0); + + // test that noinline can also appear anywhere. + ([] __attribute__((host)) __attribute__((device)) () { hd_fn(); })(); + ([] __attribute__((host)) __noinline__ __attribute__((device)) () { hd_fn(); })(); + ([] __attribute__((host)) __attribute__((device)) __noinline__ () { hd_fn(); })(); } // TODO: Add tests for __attribute__((global)) once we support global lambdas.