I see that this is just following the precedent, but could we rather do the verification in LLVM dialect? Dialects have a mechanism for verifying the attributes that use the namespace of the dialect.
Nit: prefer @below to @+1
Thank you for the review, Alex! I hope you do not mind that I move the verification code in a separate change-set.
Yes, I know that this is a long-standing concern (e.g. https://reviews.llvm.org/D121948#inline-1166282). I am taking AR to move them all to LLVM dialect verification code in a separate change-set.