Page MenuHomePhabricator

lldb-server: add support for binary memory reads
ClosedPublic

Authored by labath on Oct 13 2015, 5:02 AM.

Details

Summary

This commit adds support for binary memory reads ($x) to lldb-server. It also removes the "0x"
prefix from the $x client packet, to make it more compatible with the old $m packet. This allows
us to use almost the same code for handling both packet types. I have verified that debugserver
correctly handles $x packets even without the leading "0x".

Diff Detail

Repository
rL LLVM

Event Timeline

labath updated this revision to Diff 37237.Oct 13 2015, 5:02 AM
labath retitled this revision from to lldb-server: add support for binary memory reads.
labath updated this object.
labath added reviewers: tberghammer, jasonmolenda.
labath added subscribers: lldb-commits, iancottrell.
tberghammer accepted this revision.Oct 13 2015, 7:48 AM
tberghammer edited edge metadata.

Look good

This revision is now accepted and ready to land.Oct 13 2015, 7:48 AM

Any tests for this?

labath updated this revision to Diff 37340.Oct 14 2015, 5:44 AM
labath edited edge metadata.

The new functionality gets picked up by the client and automatically used everywhere, so I'm not
really worried about testing it. A more important issue would be making sure that the legacy read
packet does not rot as it is now unused. I have added a test which makes sure both packets return
the same value (modulo hex-encoding), which should prevent that.

labath updated this revision to Diff 37341.Oct 14 2015, 5:46 AM

Remove files which slipped in...

labath requested a review of this revision.Oct 14 2015, 5:47 AM
labath edited edge metadata.
tberghammer accepted this revision.Oct 14 2015, 5:52 AM
tberghammer edited edge metadata.

Looks good

This revision is now accepted and ready to land.Oct 14 2015, 5:52 AM
This revision was automatically updated to reflect the committed changes.