diff --git a/llvm/lib/Target/AArch64/AArch64SVEInstrInfo.td b/llvm/lib/Target/AArch64/AArch64SVEInstrInfo.td --- a/llvm/lib/Target/AArch64/AArch64SVEInstrInfo.td +++ b/llvm/lib/Target/AArch64/AArch64SVEInstrInfo.td @@ -3575,4 +3575,6 @@ let Predicates = [HasSVE2p1_or_HasSME2] in { defm FCLAMP_ZZZ : sve2p1_fclamp<"fclamp">; +def FDOT_ZZZ_S : sve_float_dot<0b0, "fdot">; +def FDOT_ZZZI_S : sve_float_dot_indexed<0b0, "fdot">; } // End HasSVE2p1_or_HasSME2 diff --git a/llvm/lib/Target/AArch64/SVEInstrFormats.td b/llvm/lib/Target/AArch64/SVEInstrFormats.td --- a/llvm/lib/Target/AArch64/SVEInstrFormats.td +++ b/llvm/lib/Target/AArch64/SVEInstrFormats.td @@ -8202,29 +8202,51 @@ let ElementSize = ElementSizeH; } -class sve_bfloat_dot -: sve_bfloat_dot_base<0b10, asm, "\t$Zda, $Zn, $Zm", - (ins ZPR32:$_Zda, ZPR16:$Zn, ZPR16:$Zm)> { +class sve_float_dot +: I<(outs ZPR32:$Zda), (ins ZPR32:$_Zda, ZPR16:$Zn, ZPR16:$Zm), + asm, "\t$Zda, $Zn, $Zm", "", []>, Sched<[]> { + bits<5> Zda; + bits<5> Zn; bits<5> Zm; + let Inst{31-23} = 0b011001000; + let Inst{22} = bf; + let Inst{21} = 0b1; let Inst{20-16} = Zm; + let Inst{15-10} = 0b100000; + let Inst{9-5} = Zn; + let Inst{4-0} = Zda; + + let Constraints = "$Zda = $_Zda"; + let DestructiveInstType = DestructiveOther; } multiclass sve_bfloat_dot { - def NAME : sve_bfloat_dot; + def NAME : sve_float_dot<0b1, asm>; def : SVE_3_Op_Pat(NAME)>; } -class sve_bfloat_dot_indexed -: sve_bfloat_dot_base<0b01, asm, "\t$Zda, $Zn, $Zm$iop", - (ins ZPR32:$_Zda, ZPR16:$Zn, ZPR3b16:$Zm, VectorIndexS:$iop)> { - bits<2> iop; +class sve_float_dot_indexed +: I<(outs ZPR32:$Zda), (ins ZPR32:$_Zda, ZPR16:$Zn, ZPR3b16:$Zm, VectorIndexS:$iop), + asm, "\t$Zda, $Zn, $Zm$iop", "", []>, Sched<[]> { + bits<5> Zda; + bits<5> Zn; bits<3> Zm; + bits<2> iop; + let Inst{31-23} = 0b011001000; + let Inst{22} = bf; + let Inst{21} = 0b1; let Inst{20-19} = iop; let Inst{18-16} = Zm; + let Inst{15-10} = 0b010000; + let Inst{9-5} = Zn; + let Inst{4-0} = Zda; + + let Constraints = "$Zda = $_Zda"; + let DestructiveInstType = DestructiveOther; } multiclass sve_bfloat_dot_indexed { - def NAME : sve_bfloat_dot_indexed; + def NAME : sve_float_dot_indexed<0b1, asm>; def : SVE_4_Op_Imm_Pat(NAME)>; } diff --git a/llvm/test/MC/AArch64/SVE2p1/fdot-diagnostics.s b/llvm/test/MC/AArch64/SVE2p1/fdot-diagnostics.s new file mode 100644 --- /dev/null +++ b/llvm/test/MC/AArch64/SVE2p1/fdot-diagnostics.s @@ -0,0 +1,27 @@ +// RUN: not llvm-mc -triple=aarch64 -show-encoding -mattr=+sve2p1 2>&1 < %s | FileCheck %s + +// --------------------------------------------------------------------------// +// Invalid vector lane index + +fdot z0.s, z0.h, z0.h[8] +// CHECK: [[@LINE-1]]:{{[0-9]+}}: error: vector lane must be an integer in range [0, 3]. +// CHECK-NEXT: fdot z0.s, z0.h, z0.h[8] +// CHECK-NOT: [[@LINE-1]]:{{[0-9]+}}: + +fdot z0.s, z0.h, z0.h[-1] +// CHECK: [[@LINE-1]]:{{[0-9]+}}: error: vector lane must be an integer in range [0, 3]. +// CHECK-NEXT: fdot z0.s, z0.h, z0.h[-1] +// CHECK-NOT: [[@LINE-1]]:{{[0-9]+}}: + +// --------------------------------------------------------------------------// +// Invalid vector suffix + +fdot z0.h, z0.s, z0.s +// CHECK: [[@LINE-1]]:{{[0-9]+}}: error: invalid element width +// CHECK-NEXT: fdot z0.h, z0.s, z0.s +// CHECK-NOT: [[@LINE-1]]:{{[0-9]+}}: + +fdot z0.d, z0.h, z0.h[0] +// CHECK: [[@LINE-1]]:{{[0-9]+}}: error: invalid element width +// CHECK-NEXT: fdot z0.d, z0.h, z0.h[0] +// CHECK-NOT: [[@LINE-1]]:{{[0-9]+}}: diff --git a/llvm/test/MC/AArch64/SVE2p1/fdot.s b/llvm/test/MC/AArch64/SVE2p1/fdot.s new file mode 100644 --- /dev/null +++ b/llvm/test/MC/AArch64/SVE2p1/fdot.s @@ -0,0 +1,78 @@ +// RUN: llvm-mc -triple=aarch64 -show-encoding -mattr=+sme2 < %s \ +// RUN: | FileCheck %s --check-prefixes=CHECK-ENCODING,CHECK-INST +// RUN: llvm-mc -triple=aarch64 -show-encoding -mattr=+sve2p1 < %s \ +// RUN: | FileCheck %s --check-prefixes=CHECK-ENCODING,CHECK-INST +// RUN: not llvm-mc -triple=aarch64 -show-encoding < %s 2>&1 \ +// RUN: | FileCheck %s --check-prefix=CHECK-ERROR +// RUN: llvm-mc -triple=aarch64 -filetype=obj -mattr=+sme2 < %s \ +// RUN: | llvm-objdump -d --mattr=+sme2 - | FileCheck %s --check-prefix=CHECK-INST +// RUN: llvm-mc -triple=aarch64 -filetype=obj -mattr=+sme2 < %s \ +// RUN: | llvm-objdump -d - | FileCheck %s --check-prefix=CHECK-UNKNOWN +// RUN: llvm-mc -triple=aarch64 -show-encoding -mattr=+sme2 < %s \ +// RUN: | sed '/.text/d' | sed 's/.*encoding: //g' \ +// RUN: | llvm-mc -triple=aarch64 -mattr=+sme2 -disassemble -show-encoding \ +// RUN: | FileCheck %s --check-prefixes=CHECK-ENCODING,CHECK-INST + +movprfx z23, z31 +fdot z23.s, z13.h, z8.h // 01100100-00101000-10000001-10110111 +// CHECK-INST: movprfx z23, z31 +// CHECK-INST: fdot z23.s, z13.h, z8.h +// CHECK-ENCODING: [0xb7,0x81,0x28,0x64] +// CHECK-ERROR: instruction requires: sme2 or sve2p1 +// CHECK-UNKNOWN: 642881b7 + +fdot z0.s, z0.h, z0.h // 01100100-00100000-10000000-00000000 +// CHECK-INST: fdot z0.s, z0.h, z0.h +// CHECK-ENCODING: [0x00,0x80,0x20,0x64] +// CHECK-ERROR: instruction requires: sme2 or sve2p1 +// CHECK-UNKNOWN: 64208000 + +fdot z21.s, z10.h, z21.h // 01100100-00110101-10000001-01010101 +// CHECK-INST: fdot z21.s, z10.h, z21.h +// CHECK-ENCODING: [0x55,0x81,0x35,0x64] +// CHECK-ERROR: instruction requires: sme2 or sve2p1 +// CHECK-UNKNOWN: 64358155 + +fdot z23.s, z13.h, z8.h // 01100100-00101000-10000001-10110111 +// CHECK-INST: fdot z23.s, z13.h, z8.h +// CHECK-ENCODING: [0xb7,0x81,0x28,0x64] +// CHECK-ERROR: instruction requires: sme2 or sve2p1 +// CHECK-UNKNOWN: 642881b7 + +fdot z31.s, z31.h, z31.h // 01100100-00111111-10000011-11111111 +// CHECK-INST: fdot z31.s, z31.h, z31.h +// CHECK-ENCODING: [0xff,0x83,0x3f,0x64] +// CHECK-ERROR: instruction requires: sme2 or sve2p1 +// CHECK-UNKNOWN: 643f83ff + +movprfx z23, z31 +fdot z23.s, z13.h, z0.h[1] // 01100100-00101000-01000001-10110111 +// CHECK-INST: movprfx z23, z31 +// CHECK-INST: fdot z23.s, z13.h, z0.h[1] +// CHECK-ENCODING: [0xb7,0x41,0x28,0x64] +// CHECK-ERROR: instruction requires: sme2 or sve2p1 +// CHECK-UNKNOWN: 642841b7 + +fdot z0.s, z0.h, z0.h[0] // 01100100-00100000-01000000-00000000 +// CHECK-INST: fdot z0.s, z0.h, z0.h[0] +// CHECK-ENCODING: [0x00,0x40,0x20,0x64] +// CHECK-ERROR: instruction requires: sme2 or sve2p1 +// CHECK-UNKNOWN: 64204000 + +fdot z21.s, z10.h, z5.h[2] // 01100100-00110101-01000001-01010101 +// CHECK-INST: fdot z21.s, z10.h, z5.h[2] +// CHECK-ENCODING: [0x55,0x41,0x35,0x64] +// CHECK-ERROR: instruction requires: sme2 or sve2p1 +// CHECK-UNKNOWN: 64354155 + +fdot z23.s, z13.h, z0.h[1] // 01100100-00101000-01000001-10110111 +// CHECK-INST: fdot z23.s, z13.h, z0.h[1] +// CHECK-ENCODING: [0xb7,0x41,0x28,0x64] +// CHECK-ERROR: instruction requires: sme2 or sve2p1 +// CHECK-UNKNOWN: 642841b7 + +fdot z31.s, z31.h, z7.h[3] // 01100100-00111111-01000011-11111111 +// CHECK-INST: fdot z31.s, z31.h, z7.h[3] +// CHECK-ENCODING: [0xff,0x43,0x3f,0x64] +// CHECK-ERROR: instruction requires: sme2 or sve2p1 +// CHECK-UNKNOWN: 643f43ff