diff --git a/llvm/lib/Transforms/IPO/FunctionSpecialization.cpp b/llvm/lib/Transforms/IPO/FunctionSpecialization.cpp --- a/llvm/lib/Transforms/IPO/FunctionSpecialization.cpp +++ b/llvm/lib/Transforms/IPO/FunctionSpecialization.cpp @@ -552,11 +552,9 @@ // inlined so that we shouldn't specialize it. if (Metrics.notDuplicatable || !Metrics.NumInsts.isValid() || (!ForceFunctionSpecialization && - Metrics.NumInsts < SmallFunctionThreshold)) { - InstructionCost C{}; - C.setInvalid(); - return C; - } + !F->hasFnAttribute(Attribute::NoInline) && + Metrics.NumInsts < SmallFunctionThreshold)) + return InstructionCost::getInvalid(); // Otherwise, set the specialization cost to be the cost of all the // instructions in the function and penalty for specializing more functions. diff --git a/llvm/test/Transforms/FunctionSpecialization/noinline.ll b/llvm/test/Transforms/FunctionSpecialization/noinline.ll new file mode 100644 --- /dev/null +++ b/llvm/test/Transforms/FunctionSpecialization/noinline.ll @@ -0,0 +1,35 @@ +; RUN: opt -S --passes=function-specialization < %s | FileCheck %s +define dso_local i32 @p0(i32 noundef %x) { +entry: + %add = add nsw i32 %x, 1 + ret i32 %add +} + +define dso_local i32 @p1(i32 noundef %x) { +entry: + %sub = add nsw i32 %x, -1 + ret i32 %sub +} + +define internal fastcc i32 @f(i32 noundef %x, ptr nocapture noundef readonly %p) noinline { +entry: + %call = tail call i32 %p(i32 noundef %x) + %add = add nsw i32 %call, %x + ret i32 %add +} + +define dso_local i32 @g0(i32 noundef %x) { +entry: + %call = tail call fastcc i32 @f(i32 noundef %x, ptr noundef nonnull @p0) + ret i32 %call +} + +define dso_local i32 @g1(i32 noundef %x) { +entry: + %call = tail call fastcc i32 @f(i32 noundef %x, ptr noundef nonnull @p1) + ret i32 %call +} + +; Check that a noinline function is specialized, even if it's small. +; CHECK: @f.1 +; CHECK: @f.2