diff --git a/clang-tools-extra/clangd/CMakeLists.txt b/clang-tools-extra/clangd/CMakeLists.txt --- a/clang-tools-extra/clangd/CMakeLists.txt +++ b/clang-tools-extra/clangd/CMakeLists.txt @@ -194,7 +194,7 @@ endif () if (CLANGD_ENABLE_REMOTE) - include(FindGRPC) + include(AddGRPC) endif() if(CLANG_INCLUDE_TESTS) diff --git a/clang-tools-extra/clangd/index/remote/CMakeLists.txt b/clang-tools-extra/clangd/index/remote/CMakeLists.txt --- a/clang-tools-extra/clangd/index/remote/CMakeLists.txt +++ b/clang-tools-extra/clangd/index/remote/CMakeLists.txt @@ -1,8 +1,8 @@ if (CLANGD_ENABLE_REMOTE) - generate_protos(clangdRemoteIndexProto "Index.proto") - generate_protos(clangdMonitoringServiceProto "MonitoringService.proto" + generate_clang_protos_library(clangdRemoteIndexProto "Index.proto") + generate_clang_protos_library(clangdMonitoringServiceProto "MonitoringService.proto" GRPC) - generate_protos(clangdRemoteIndexServiceProto "Service.proto" + generate_clang_protos_library(clangdRemoteIndexServiceProto "Service.proto" DEPENDS "Index.proto" GRPC) # FIXME: Move this into generate_protos. Currently we only mention proto diff --git a/clang/cmake/modules/AddGRPC.cmake b/clang/cmake/modules/AddGRPC.cmake new file mode 100644 --- /dev/null +++ b/clang/cmake/modules/AddGRPC.cmake @@ -0,0 +1,11 @@ +include(FindGRPC) + +function(generate_clang_protos_library LibraryName ProtoFile) + # Take the first two args and forward the remaining to generate_proto_sources. + cmake_parse_arguments(PARSE_ARGV 2 PROTO "" "" "") + generate_proto_sources(ProtoSource ${ProtoFile} ${PROTO_UNPARSED_ARGUMENTS}) + + add_clang_library(${LibraryName} ${ProtoSource} + PARTIAL_SOURCES_INTENDED + LINK_LIBS PUBLIC grpc++ protobuf) +endfunction() diff --git a/llvm/cmake/modules/FindGRPC.cmake b/cmake/Modules/FindGRPC.cmake rename from llvm/cmake/modules/FindGRPC.cmake rename to cmake/Modules/FindGRPC.cmake --- a/llvm/cmake/modules/FindGRPC.cmake +++ b/cmake/Modules/FindGRPC.cmake @@ -108,7 +108,7 @@ # If the "GRPC" argument is given, services are also generated. # The DEPENDS list should name *.proto source files that are imported. # They may be relative to the source dir or absolute (for generated protos). -function(generate_protos LibraryName ProtoFile) +function(generate_proto_sources GeneratedSource ProtoFile) cmake_parse_arguments(PARSE_ARGV 2 PROTO "GRPC" "" "DEPENDS") get_filename_component(ProtoSourceAbsolutePath "${CMAKE_CURRENT_SOURCE_DIR}/${ProtoFile}" ABSOLUTE) get_filename_component(ProtoSourcePath ${ProtoSourceAbsolutePath} PATH) @@ -132,9 +132,7 @@ ARGS ${Flags} "${ProtoSourceAbsolutePath}" DEPENDS "${ProtoSourceAbsolutePath}") - add_llvm_library(${LibraryName} ${GeneratedProtoSource} - PARTIAL_SOURCES_INTENDED - LINK_LIBS PUBLIC grpc++ protobuf) + set(${GeneratedSource} ${GeneratedProtoSource} PARENT_SCOPE) # Ensure dependency headers are generated before dependent protos are built. # DEPENDS arg is a list of "Foo.proto". While they're logically relative to