diff --git a/lldb/include/lldb/Utility/RegisterValue.h b/lldb/include/lldb/Utility/RegisterValue.h --- a/lldb/include/lldb/Utility/RegisterValue.h +++ b/lldb/include/lldb/Utility/RegisterValue.h @@ -84,7 +84,7 @@ void SetType(RegisterValue::Type type) { m_type = type; } - RegisterValue::Type SetType(const RegisterInfo *reg_info); + RegisterValue::Type SetType(const RegisterInfo ®_info); bool GetData(DataExtractor &data) const; diff --git a/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux.cpp b/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux.cpp --- a/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux.cpp +++ b/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux.cpp @@ -75,7 +75,7 @@ memcpy(dst + (reg_info->byte_offset & 0x1), src, src_size); // Set this full register as the value to write. value_to_write.SetBytes(dst, full_value.GetByteSize(), byte_order); - value_to_write.SetType(full_reg_info); + value_to_write.SetType(*full_reg_info); reg_to_write = full_reg; } } diff --git a/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.cpp b/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.cpp --- a/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.cpp +++ b/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.cpp @@ -136,7 +136,7 @@ // then use the type specified by reg_info rather than the uint64_t // default if (reg_value.GetByteSize() > reg_info->byte_size) - reg_value.SetType(reg_info); + reg_value.SetType(*reg_info); } return error; } diff --git a/lldb/source/Utility/RegisterValue.cpp b/lldb/source/Utility/RegisterValue.cpp --- a/lldb/source/Utility/RegisterValue.cpp +++ b/lldb/source/Utility/RegisterValue.cpp @@ -149,13 +149,12 @@ void RegisterValue::Clear() { m_type = eTypeInvalid; } -RegisterValue::Type RegisterValue::SetType(const RegisterInfo *reg_info) { - assert(reg_info && "Expected non null reg_info."); +RegisterValue::Type RegisterValue::SetType(const RegisterInfo ®_info) { // To change the type, we simply copy the data in again, using the new format RegisterValue copy; DataExtractor copy_data; if (copy.CopyValue(*this) && copy.GetData(copy_data)) { - Status error = SetValueFromData(*reg_info, copy_data, 0, true); + Status error = SetValueFromData(reg_info, copy_data, 0, true); assert(error.Success() && "Expected SetValueFromData to succeed."); UNUSED_IF_ASSERT_DISABLED(error); }