Index: clang/lib/AST/Interp/ByteCodeExprGen.h =================================================================== --- clang/lib/AST/Interp/ByteCodeExprGen.h +++ clang/lib/AST/Interp/ByteCodeExprGen.h @@ -90,6 +90,8 @@ bool VisitArrayInitIndexExpr(const ArrayInitIndexExpr *E); bool VisitOpaqueValueExpr(const OpaqueValueExpr *E); bool VisitAbstractConditionalOperator(const AbstractConditionalOperator *E); + bool VisitStringLiteral(const StringLiteral *E); + bool VisitCharacterLiteral(const CharacterLiteral *E); protected: bool visitExpr(const Expr *E) override; Index: clang/lib/AST/Interp/ByteCodeExprGen.cpp =================================================================== --- clang/lib/AST/Interp/ByteCodeExprGen.cpp +++ clang/lib/AST/Interp/ByteCodeExprGen.cpp @@ -433,6 +433,21 @@ return true; } +template +bool ByteCodeExprGen::VisitStringLiteral(const StringLiteral *E) { + unsigned StringIndex = P.createGlobalString(E); + return this->emitGetPtrGlobal(StringIndex, E); +} + +template +bool ByteCodeExprGen::VisitCharacterLiteral( + const CharacterLiteral *E) { + if (Optional T = classify(E->getType())) + return this->emitConst(E, E->getValue()); + + return this->bail(E); +} + template bool ByteCodeExprGen::discard(const Expr *E) { OptionScope Scope(this, /*NewDiscardResult=*/true); return this->Visit(E); Index: clang/test/AST/Interp/arrays.cpp =================================================================== --- clang/test/AST/Interp/arrays.cpp +++ clang/test/AST/Interp/arrays.cpp @@ -117,3 +117,27 @@ // expected-error {{must be initialized by a constant expression}} \ // expected-note {{cannot refer to element -2 of array of 10}} }; + +namespace strings { + constexpr const char *S = "abc"; + static_assert(S[0] == 'a', ""); + static_assert(S[1] == 'b', ""); + static_assert(S[2] == 'c', ""); + static_assert(S[3] == '\0', ""); + + static_assert("foobar"[2] == 'o', ""); + static_assert(2["foobar"] == 'o', ""); + + constexpr const wchar_t *wide = L"bar"; + static_assert(wide[0] == L'b', ""); + + constexpr const char32_t *u32 = U"abc"; + static_assert(u32[1] == U'b', ""); + + constexpr char32_t c = U'\U0001F60E'; + static_assert(c == U'😎'); + + constexpr char k = -1; + static_assert(k == -1); + +};